From: Paul Wisbey
Date: Thu, 11 Aug 2016 16:06:27 +0000 (-0700)
Subject: Merge "Multilanguage support cache issue fix." into devel/master
X-Git-Tag: dali_1.2.1~2
X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=commitdiff_plain;h=1de507cb9f77667b67b269abfe25769205c9817e;hp=190217c8f02a9a1703dedfe38eb1974b6830e5ac
Merge "Multilanguage support cache issue fix." into devel/master
---
diff --git a/dali-toolkit/internal/text/multi-language-support-impl.cpp b/dali-toolkit/internal/text/multi-language-support-impl.cpp
index 750fab7..ae9a68b 100644
--- a/dali-toolkit/internal/text/multi-language-support-impl.cpp
+++ b/dali-toolkit/internal/text/multi-language-support-impl.cpp
@@ -67,27 +67,34 @@ FontId DefaultFonts::FindFont( TextAbstraction::FontClient& fontClient,
const TextAbstraction::FontDescription& description,
PointSize26Dot6 size ) const
{
- for( Vector::ConstIterator it = mFonts.Begin(),
- endIt = mFonts.End();
+ for( std::vector::const_iterator it = mFonts.begin(),
+ endIt = mFonts.end();
it != endIt;
++it )
{
- const FontId fontId = *it;
- TextAbstraction::FontDescription fontDescription;
- fontClient.GetDescription( fontId, fontDescription );
-
- if( ( size == fontClient.GetPointSize( fontId ) ) &&
- ( description.weight == fontDescription.weight ) &&
- ( description.width == fontDescription.width ) &&
- ( description.slant == fontDescription.slant ) )
+ const CacheItem& item = *it;
+
+ if( ( ( TextAbstraction::FontWeight::NONE == description.weight ) || ( description.weight == item.description.weight ) ) &&
+ ( ( TextAbstraction::FontWidth::NONE == description.width ) || ( description.width == item.description.width ) ) &&
+ ( ( TextAbstraction::FontSlant::NONE == description.slant ) || ( description.slant == item.description.slant ) ) &&
+ ( size == fontClient.GetPointSize( item.fontId ) ) &&
+ ( description.family.empty() || ( description.family == item.description.family ) ) )
{
- return fontId;
+ return item.fontId;
}
}
return 0u;
}
+void DefaultFonts::Cache( const TextAbstraction::FontDescription& description, FontId fontId )
+{
+ CacheItem item;
+ item.description = description;
+ item.fontId = fontId;
+ mFonts.push_back( item );
+}
+
MultilanguageSupport::MultilanguageSupport()
: mDefaultFontPerScriptCache(),
mValidFontsPerScriptCache()
@@ -654,7 +661,7 @@ void MultilanguageSupport::ValidateFonts( const Vector& text,
*( defaultFontPerScriptCacheBuffer + script ) = defaultFontsPerScript;
}
}
- defaultFontsPerScript->mFonts.PushBack( fontId );
+ defaultFontsPerScript->Cache( currentFontDescription, fontId );
}
} // !isValidFont (3)
} // !isValidFont (2)
diff --git a/dali-toolkit/internal/text/multi-language-support-impl.h b/dali-toolkit/internal/text/multi-language-support-impl.h
index 3f568a2..afbeb23 100644
--- a/dali-toolkit/internal/text/multi-language-support-impl.h
+++ b/dali-toolkit/internal/text/multi-language-support-impl.h
@@ -77,6 +77,12 @@ struct ValidateFontsPerScript
*/
struct DefaultFonts
{
+ struct CacheItem
+ {
+ TextAbstraction::FontDescription description;
+ FontId fontId ;
+ };
+
/**
* Default constructor.
*/
@@ -103,7 +109,9 @@ struct DefaultFonts
const TextAbstraction::FontDescription& description,
PointSize26Dot6 size ) const;
- Vector mFonts;
+ void Cache( const TextAbstraction::FontDescription& description, FontId fontId );
+
+ std::vector mFonts;
};
/**