remove logic for comparing clipped state. 91/289591/1
authorHosang Kim <hosang12.kim@samsung.com>
Mon, 6 Mar 2023 10:24:39 +0000 (19:24 +0900)
committerHosang Kim <hosang12.kim@samsung.com>
Fri, 10 Mar 2023 04:40:03 +0000 (13:40 +0900)
A child can be visible even if clip mode outside of parent.
So a object is actually shown on screen but SHOWING state is false.

Change-Id: I74b59f99783c6ade8029a3be5166cf9a8de36011

automated-tests/src/dali-toolkit-internal/utc-Dali-Accessibility-Accessible.cpp
dali-toolkit/devel-api/controls/control-accessible.cpp

index 60e1892..f76c4a0 100644 (file)
@@ -114,7 +114,7 @@ int UtcDaliAccessibilityCheckShowingState(void)
   q = Dali::Accessibility::Accessible::Get(buttonB);
   DALI_TEST_CHECK(q);
   states = q->GetStates();
-  DALI_TEST_EQUALS((int) states[Dali::Accessibility::State::SHOWING], (int) false, TEST_LOCATION);
+  DALI_TEST_EQUALS((int) states[Dali::Accessibility::State::SHOWING], (int) true, TEST_LOCATION);
 
   q = Dali::Accessibility::Accessible::Get(buttonC);
   DALI_TEST_CHECK(q);
index 719657d..5ac6317 100644 (file)
@@ -195,7 +195,6 @@ bool ControlAccessible::IsShowing()
     return true;
   }
 
-  auto childExtent = child->GetExtents(Dali::Accessibility::CoordinateType::WINDOW);
   while(parent)
   {
     auto control = Dali::Toolkit::Control::DownCast(parent->Self());
@@ -203,12 +202,6 @@ bool ControlAccessible::IsShowing()
     {
       return false;
     }
-    auto clipMode     = control.GetProperty(Actor::Property::CLIPPING_MODE).Get<bool>();
-    auto parentExtent = parent->GetExtents(Dali::Accessibility::CoordinateType::WINDOW);
-    if((clipMode != ClippingMode::DISABLED) && !parentExtent.Intersects(childExtent))
-    {
-      return false;
-    }
     parent = dynamic_cast<Toolkit::DevelControl::ControlAccessible*>(parent->GetParent());
   }