Fix coverity issue in text layout-engine 80/261680/1
authorBowon Ryu <bowon.ryu@samsung.com>
Thu, 22 Jul 2021 09:14:32 +0000 (18:14 +0900)
committerBowon Ryu <bowon.ryu@samsung.com>
Thu, 22 Jul 2021 09:14:32 +0000 (18:14 +0900)
middleLineIndex is always bigger than 0u by the while condition (0u < middleLineIndex).
therefore execution cannot reach the expression 0u inside the statement below.
: ellipsisLineIndex = middleLineIndex > 0u ? middleLineIndex - 1u : 0u;

Change-Id: I1f2f85768ba638d3493f62a22b3d89a75ef462ae
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
dali-toolkit/internal/text/layouts/layout-engine.cpp

index 077b598..cee3a09 100644 (file)
@@ -1881,7 +1881,7 @@ struct Engine::Impl
             linesBuffer[lineIndex].ellipsis = false;
           }
           numberOfLines--;
             linesBuffer[lineIndex].ellipsis = false;
           }
           numberOfLines--;
-          ellipsisLineIndex = middleLineIndex > 0u ? middleLineIndex - 1u : 0u;
+          ellipsisLineIndex = middleLineIndex - 1u;
           middleLineIndex   = (numberOfLines) / 2u;
         }
 
           middleLineIndex   = (numberOfLines) / 2u;
         }