(ScrollView)Fix the double bouncing of the overshoot actor 54/46754/2
authorXiangyin Ma <x1.ma@samsung.com>
Tue, 25 Aug 2015 14:51:24 +0000 (15:51 +0100)
committerXiangyin Ma <x1.ma@samsung.com>
Tue, 25 Aug 2015 14:53:39 +0000 (15:53 +0100)
Remove ClearOvershoot, as the overshoot actor is updated with the change of OVERSHOOT_X / OVERSHOOT_Y through property noticification,
the clear animation is redundant which causes the double bouncing

Change-Id: I3a377928f1e18ded3a87882dd57b7e9e9ffeea51

dali-toolkit/internal/controls/scrollable/scroll-view/scroll-overshoot-indicator-impl.cpp
dali-toolkit/internal/controls/scrollable/scroll-view/scroll-overshoot-indicator-impl.h
dali-toolkit/internal/controls/scrollable/scroll-view/scroll-view-impl.cpp

index 592fefc..0420830 100644 (file)
@@ -112,18 +112,6 @@ void ScrollOvershootIndicator::SetOvershootEffectColor( const Vector4& color )
   }
 }
 
   }
 }
 
-void ScrollOvershootIndicator::ClearOvershoot()
-{
-  if(mEffectX)
-  {
-    mEffectX->SetOvershoot(0.0f);
-  }
-  if(mEffectY)
-  {
-    mEffectY->SetOvershoot(0.0f);
-  }
-}
-
 ScrollOvershootEffect::ScrollOvershootEffect( bool vertical ) :
     mVertical(vertical)
 {
 ScrollOvershootEffect::ScrollOvershootEffect( bool vertical ) :
     mVertical(vertical)
 {
index f19e39c..7eebe4b 100644 (file)
@@ -76,11 +76,6 @@ public:
   void Reset();
 
   /**
   void Reset();
 
   /**
-   * Clears the overshoot
-   */
-  void ClearOvershoot();
-
-  /**
    * Create an initialized ScrollOvershootIndicator
    *
    * @return A pointer to the created ScrollOvershootIndicator.
    * Create an initialized ScrollOvershootIndicator
    *
    * @return A pointer to the created ScrollOvershootIndicator.
index 86e9173..a8bd61e 100644 (file)
@@ -2439,11 +2439,6 @@ void ScrollView::OnPan( const PanGesture& gesture )
         {
           mScrollMainInternalPrePositionConstraint.Remove();
         }
         {
           mScrollMainInternalPrePositionConstraint.Remove();
         }
-
-        if( mOvershootIndicator )
-        {
-          mOvershootIndicator->ClearOvershoot();
-        }
       }
       else
       {
       }
       else
       {