Add log for font load validation

Add log when isValidFont is false for easy debugging.
It is usually false if the platform couldn't find a suitable glyph.

Change-Id: Icdc1e929a7c11ee3033c877b35ba7048e44bbd17
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>

diff --git a/automated-tests/src/dali-toolkit/utc-Dali-TextLabel.cpp b/automated-tests/src/dali-toolkit/utc-Dali-TextLabel.cpp
index 2ff4a7d..f7bf429 100644 (file)
--- a/automated-tests/src/dali-toolkit/utc-Dali-TextLabel.cpp
+++ b/automated-tests/src/dali-toolkit/utc-Dali-TextLabel.cpp
@@ -1140,6 +1140,7 @@ int UtcDaliToolkitTextLabelEmojisP(void)
 
   // EMOJI Sequences case for coverage.
   std::string emojiSequences =
 
   // EMOJI Sequences case for coverage.
   std::string emojiSequences =

+    "Glyphs not included in the font \n"   //case for coverage when glyph is not included in the font

     "Text VS15 ☪︎\n"                                                         //text presentation sequence and selector
     "Color VS16 ☪️\n"                                                        //emoji presentation sequence and selector
     "Default ☪ \n"                                                                  //default presentation
     "Text VS15 ☪︎\n"                                                         //text presentation sequence and selector
     "Color VS16 ☪️\n"                                                        //emoji presentation sequence and selector
     "Default ☪ \n"                                                                  //default presentation

diff --git a/dali-toolkit/internal/text/multi-language-support-impl.cpp b/dali-toolkit/internal/text/multi-language-support-impl.cpp
index 96210ca..f24d427 100644 (file)
--- a/dali-toolkit/internal/text/multi-language-support-impl.cpp
+++ b/dali-toolkit/internal/text/multi-language-support-impl.cpp
@@ -542,7 +542,7 @@ void MultilanguageSupport::ValidateFonts(const Vector<Character>&
     }
 
     bool isCommonScript = false;
     }
 
     bool isCommonScript = false;

-    bool isEmojiScript  = TextAbstraction::IsEmojiScript(script) || TextAbstraction::IsEmojiColorScript(script) || TextAbstraction::IsEmojiTextScript(script);
+    bool isEmojiScript  = TextAbstraction::IsOneOfEmojiScripts(script);

 
     if(isEmojiScript && (previousScript == script))
     {
 
     if(isEmojiScript && (previousScript == script))
     {


@@ -628,6 +628,7 @@ void MultilanguageSupport::ValidateFonts(const Vector<Character>&
           {
             // Use the cached default font for the script if there is one.
             fontId = cachedDefaultFontId;
           {
             // Use the cached default font for the script if there is one.
             fontId = cachedDefaultFontId;

+            isValidFont = true;

           }
           else
           {
           }
           else
           {


@@ -660,6 +661,7 @@ void MultilanguageSupport::ValidateFonts(const Vector<Character>&
                 }
               }
               defaultFontsPerScript->Cache(currentFontDescription, fontId);
                 }
               }
               defaultFontsPerScript->Cache(currentFontDescription, fontId);

+              isValidFont = true;

             }
           }
         } // !isValidFont (3)
             }
           }
         } // !isValidFont (3)


@@ -729,6 +731,15 @@ void MultilanguageSupport::ValidateFonts(const Vector<Character>&
                     description.path.c_str());
     }
 #endif
                     description.path.c_str());
     }
 #endif

+    if(!isValidFont && !isCommonScript)
+    {
+      Dali::TextAbstraction::FontDescription descriptionForLog;
+      fontClient.GetDescription(fontId, descriptionForLog);
+      DALI_LOG_RELEASE_INFO("Validated font set fail : Character : %x, Script : %s, Font : %s \n",
+                            character,
+                            Dali::TextAbstraction::ScriptName[script],
+                            descriptionForLog.path.c_str());
+    }

 
     // Whether bols style is required.
     isBoldRequired = (currentFontDescription.weight >= TextAbstraction::FontWeight::BOLD);
 
     // Whether bols style is required.
     isBoldRequired = (currentFontDescription.weight >= TextAbstraction::FontWeight::BOLD);