Text auto scroll animation bug fix 44/158144/2
authorJinho, Lee <jeano.lee@samsung.com>
Mon, 30 Oct 2017 05:58:19 +0000 (14:58 +0900)
committerJinho, Lee <jeano.lee@samsung.com>
Fri, 3 Nov 2017 04:14:12 +0000 (13:14 +0900)
 Before this patch,
 That code played scroll animation.
    textLabel = TextLabel::New( "Hello World" );
    textLabel.SetProperty( Toolkit::TextLabel::Property::AUTO_SCROLL_STOP_MODE, TextLabel::AutoScrollStopMode::IMMEDIATE);
    textLabel.SetProperty( Toolkit::TextLabel::Property::ENABLE_AUTO_SCROLL,true);
    textLabel.SetProperty( Toolkit::TextLabel::Property::ENABLE_AUTO_SCROLL,false);
    stage.Add(textLabel);

 So I added code for stopping animation when mScrollAnimation was Null.

Change-Id: I4fa881215c4c30228e2cb0fb6f9f80e7060bf6b2

automated-tests/src/dali-toolkit/utc-Dali-TextLabel.cpp
dali-toolkit/internal/text/text-scroller.cpp

index 31b147b..659eb54 100644 (file)
@@ -630,6 +630,12 @@ int UtcDaliToolkitTextlabelScrollingP(void)
     // Render some text with the shared atlas backend
     labelImmediate.SetProperty( TextLabel::Property::ENABLE_AUTO_SCROLL, true );
     labelFinished.SetProperty( TextLabel::Property::ENABLE_AUTO_SCROLL, true );
+
+    labelImmediate.SetProperty( TextLabel::Property::ENABLE_AUTO_SCROLL, false );
+    labelFinished.SetProperty( TextLabel::Property::ENABLE_AUTO_SCROLL, false );
+
+    labelImmediate.SetProperty( TextLabel::Property::ENABLE_AUTO_SCROLL, true );
+    labelFinished.SetProperty( TextLabel::Property::ENABLE_AUTO_SCROLL, true );
     application.SendNotification();
     application.Render();
 
index 466bfa6..f8089a2 100644 (file)
@@ -233,6 +233,10 @@ void TextScroller::StopScrolling()
       }
     }
   }
+  else
+  {
+    mScrollerInterface.ScrollingFinished();
+  }
 }
 
 TextLabel::AutoScrollStopMode::Type TextScroller::GetStopMode() const