Minor coverity issue fixes 55/282555/24
authorEunki, Hong <eunkiki.hong@samsung.com>
Wed, 5 Oct 2022 14:02:09 +0000 (23:02 +0900)
committerEunki, Hong <eunkiki.hong@samsung.com>
Mon, 19 Dec 2022 19:25:28 +0000 (04:25 +0900)
commit0801dbcf061d67f317bae129fa8a9013f43a8127
treed8f86072ddb7f626f254905d247e42858a77309b
parent9c9c7e28c052746ade264c9d0522d090674a78a3
Minor coverity issue fixes

Fix some minor coverity issues that might has meanful

1. Implement missing move operation.
2. Remove float equal checks by ==, != operator.
3. Remove useless std::move.
4. Remove const keyword for function return value.
5. Resolve some value has same name.
6. Use referenced iterator so we don't copy value.
7. Remove cyclic header include (a.k.a gltf-loader.h -> scene3d-view-impl.h -> gltf-loader.h)

Change-Id: I57ad541310b43413ee0d52b1f8c56a95df12bbd9
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
87 files changed:
automated-tests/src/dali-toolkit-internal/utc-Dali-VisualUrl.cpp
dali-scene3d/internal/controls/model/model-impl.cpp
dali-scene3d/internal/controls/scene-view/scene-view-impl.cpp
dali-scene3d/public-api/loader/dli-loader.cpp
dali-scene3d/public-api/loader/material-definition.cpp
dali-scene3d/public-api/loader/material-definition.h
dali-scene3d/public-api/loader/mesh-definition.cpp
dali-scene3d/public-api/loader/mesh-definition.h
dali-scene3d/public-api/loader/scene-definition.cpp
dali-scene3d/public-api/loader/shader-definition.cpp
dali-toolkit/devel-api/controls/bloom-view/bloom-view.cpp
dali-toolkit/devel-api/controls/bloom-view/bloom-view.h
dali-toolkit/devel-api/controls/bubble-effect/bubble-emitter.cpp
dali-toolkit/devel-api/controls/bubble-effect/bubble-emitter.h
dali-toolkit/devel-api/controls/control-accessible.cpp
dali-toolkit/devel-api/controls/effects-view/effects-view.cpp
dali-toolkit/devel-api/controls/effects-view/effects-view.h
dali-toolkit/devel-api/controls/magnifier/magnifier.cpp
dali-toolkit/devel-api/controls/magnifier/magnifier.h
dali-toolkit/devel-api/controls/navigation-view/navigation-view.cpp
dali-toolkit/devel-api/controls/navigation-view/navigation-view.h
dali-toolkit/devel-api/controls/popup/confirmation-popup.cpp
dali-toolkit/devel-api/controls/popup/confirmation-popup.h
dali-toolkit/devel-api/controls/popup/popup.cpp
dali-toolkit/devel-api/controls/popup/popup.h
dali-toolkit/devel-api/controls/scene3d-view/scene3d-view.cpp
dali-toolkit/devel-api/controls/scene3d-view/scene3d-view.h
dali-toolkit/devel-api/controls/shadow-view/shadow-view.cpp
dali-toolkit/devel-api/controls/shadow-view/shadow-view.h
dali-toolkit/devel-api/controls/super-blur-view/super-blur-view.cpp
dali-toolkit/devel-api/controls/super-blur-view/super-blur-view.h
dali-toolkit/devel-api/controls/text-controls/text-anchor-devel.cpp
dali-toolkit/devel-api/controls/text-controls/text-anchor-devel.h
dali-toolkit/devel-api/controls/text-controls/text-selection-popup.cpp
dali-toolkit/devel-api/controls/text-controls/text-selection-popup.h
dali-toolkit/devel-api/controls/text-controls/text-selection-toolbar.cpp
dali-toolkit/devel-api/controls/text-controls/text-selection-toolbar.h
dali-toolkit/devel-api/controls/tool-bar/tool-bar.cpp
dali-toolkit/devel-api/controls/tool-bar/tool-bar.h
dali-toolkit/internal/builder/builder-impl.cpp
dali-toolkit/internal/builder/tree-node-manipulator.cpp
dali-toolkit/internal/controls/control/control-data-impl.cpp
dali-toolkit/internal/controls/image-view/image-view-impl.cpp
dali-toolkit/internal/controls/model3d-view/obj-loader.h
dali-toolkit/internal/controls/popup/popup-impl.cpp
dali-toolkit/internal/controls/popup/popup-impl.h
dali-toolkit/internal/controls/progress-bar/progress-bar-impl.cpp
dali-toolkit/internal/controls/scene3d-view/gltf-loader.cpp
dali-toolkit/internal/controls/scene3d-view/gltf-loader.h
dali-toolkit/internal/controls/scene3d-view/scene3d-view-impl.cpp
dali-toolkit/internal/controls/scene3d-view/scene3d-view-impl.h
dali-toolkit/internal/controls/scroll-bar/scroll-bar-impl.cpp
dali-toolkit/internal/controls/text-controls/common-text-utils.cpp
dali-toolkit/internal/controls/text-controls/text-editor-impl.cpp
dali-toolkit/internal/text/controller/text-controller-impl-model-updater.cpp
dali-toolkit/internal/text/controller/text-controller-relayouter.cpp
dali-toolkit/internal/text/controller/text-controller-text-updater.cpp
dali-toolkit/internal/text/controller/text-controller.cpp
dali-toolkit/internal/text/controller/text-controller.h
dali-toolkit/internal/text/input-style.h
dali-toolkit/internal/text/multi-language-support.h
dali-toolkit/internal/text/rendering/atlas/atlas-glyph-manager.h
dali-toolkit/internal/text/rendering/atlas/atlas-manager.h
dali-toolkit/internal/text/rendering/atlas/text-atlas-renderer.cpp
dali-toolkit/internal/text/rendering/text-backend.cpp
dali-toolkit/internal/text/rendering/text-backend.h
dali-toolkit/internal/text/rendering/text-typesetter.cpp
dali-toolkit/internal/text/rendering/vector-based/vector-blob-atlas-share.h
dali-toolkit/internal/text/rendering/view-model.cpp
dali-toolkit/internal/text/rendering/view-model.h
dali-toolkit/internal/text/strikethrough-style-properties.h
dali-toolkit/internal/text/text-effects-style.cpp
dali-toolkit/internal/text/text-geometry.cpp
dali-toolkit/internal/text/text-model-interface.h
dali-toolkit/internal/text/text-model.cpp
dali-toolkit/internal/text/text-model.h
dali-toolkit/internal/text/text-view-interface.h
dali-toolkit/internal/text/text-view.cpp
dali-toolkit/internal/text/text-view.h
dali-toolkit/internal/text/underline-style-properties.h
dali-toolkit/internal/transition/slide-transition-impl.cpp
dali-toolkit/internal/visuals/animated-vector-image/animated-vector-image-visual.cpp
dali-toolkit/internal/visuals/visual-base-impl.cpp
dali-toolkit/internal/visuals/visual-factory-cache.cpp
dali-toolkit/internal/visuals/visual-url.cpp
dali-toolkit/internal/visuals/visual-url.h
dali-toolkit/public-api/controls/control-impl.cpp