Fix doxygen error + Minor coverity issue resolve 68/286968/1
authorEunki Hong <eunkiki.hong@samsung.com>
Tue, 17 Jan 2023 20:42:41 +0000 (05:42 +0900)
committerEunki Hong <eunkiki.hong@samsung.com>
Tue, 17 Jan 2023 20:42:41 +0000 (05:42 +0900)
commit64cbda8b449c9095e967c6acf065fcaed8394d35
tree66e1a0ee0f60929f16bb8f40e198a80aabe3c39d
parent6696a3703d6c139476cc40b8b39802c71510c6eb
Fix doxygen error + Minor coverity issue resolve

Due to the unknown issue, If we set SpanType::Value as enum class +
If we return const Value, doxygen compiled failed at Accessibility::Value.

Error message :

Configuration file '/home/leaf/work/dali-toolkit/build/tizen/docs/dali.doxy' updated.

/home/leaf/work/dali-env/opt/include/dali/devel-api/atspi-interfaces/value.h:88: warning: no matching file member found for
Value * Dali::Accessibility::Value::DownCast(Accessible *obj)
Possible candidates:
 'T DownCast(BaseHandle handle)' at line 275 of file /home/leaf/work/dali-env/opt/include/dali/public-api/object/base-handle.h
 'Application DownCast(Dali::RefObject *refObject)' at line 83 of file /home/leaf/work/dali-env/opt/include/dali/devel-api/adaptor-framework/application-devel.h

Since human cannot read this error, just avoid it.

+

Due to the doxygen make trouble since const value return,
I also try to remove all const return keyword that coverity issue will be occured..

TODO : Should FontSpan::GetFamilyName return const std::string& instead of const std::string?
That API is also kind of meanless const keyword btw.

See https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-toolkit/+/282555/ 's case 4.

Change-Id: I6e087e66a3de3ee4a5981bdc540616910ab04b6e
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
30 files changed:
dali-toolkit/devel-api/text/spans/background-color-span.cpp
dali-toolkit/devel-api/text/spans/background-color-span.h
dali-toolkit/devel-api/text/spans/base-span.cpp
dali-toolkit/devel-api/text/spans/base-span.h
dali-toolkit/devel-api/text/spans/character-spacing-span.cpp
dali-toolkit/devel-api/text/spans/character-spacing-span.h
dali-toolkit/devel-api/text/spans/font-span.cpp
dali-toolkit/devel-api/text/spans/font-span.h
dali-toolkit/devel-api/text/spans/foreground-color-span.cpp
dali-toolkit/devel-api/text/spans/foreground-color-span.h
dali-toolkit/devel-api/text/spans/span-enumerations.h
dali-toolkit/devel-api/text/spans/strikethrough-span.cpp
dali-toolkit/devel-api/text/spans/strikethrough-span.h
dali-toolkit/devel-api/text/spans/underline-span.cpp
dali-toolkit/devel-api/text/spans/underline-span.h
dali-toolkit/internal/text/controller/text-controller.h
dali-toolkit/internal/text/spannable/spans/background-color-span-impl.cpp
dali-toolkit/internal/text/spannable/spans/background-color-span-impl.h
dali-toolkit/internal/text/spannable/spans/base-span-impl.cpp
dali-toolkit/internal/text/spannable/spans/base-span-impl.h
dali-toolkit/internal/text/spannable/spans/character-spacing-span-impl.cpp
dali-toolkit/internal/text/spannable/spans/character-spacing-span-impl.h
dali-toolkit/internal/text/spannable/spans/font-span-impl.cpp
dali-toolkit/internal/text/spannable/spans/font-span-impl.h
dali-toolkit/internal/text/spannable/spans/foreground-color-span-impl.cpp
dali-toolkit/internal/text/spannable/spans/foreground-color-span-impl.h
dali-toolkit/internal/text/spannable/spans/strikethrough-span-impl.cpp
dali-toolkit/internal/text/spannable/spans/strikethrough-span-impl.h
dali-toolkit/internal/text/spannable/spans/underline-span-impl.cpp
dali-toolkit/internal/text/spannable/spans/underline-span-impl.h