X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=blobdiff_plain;f=dali-toolkit%2Finternal%2Fcontrols%2Fimage-view%2Fimage-view-impl.cpp;h=835bb4ecb2cb96722f599bf85da437d0edfc9745;hp=65e043ebf74f198190061c7eac76ff2434dd2ea3;hb=3ea0c6dd8536cc1ebd948f47f569bc8f09547e27;hpb=c207c7aae76e4a6111656669fbed81052513b460 diff --git a/dali-toolkit/internal/controls/image-view/image-view-impl.cpp b/dali-toolkit/internal/controls/image-view/image-view-impl.cpp index 65e043e..835bb4e 100644 --- a/dali-toolkit/internal/controls/image-view/image-view-impl.cpp +++ b/dali-toolkit/internal/controls/image-view/image-view-impl.cpp @@ -27,7 +27,7 @@ // INTERNAL INCLUDES #include #include -#include +#include #include #include #include @@ -87,6 +87,13 @@ Toolkit::ImageView ImageView::New() ///////////////////////////////////////////////////////////// +void ImageView::OnInitialize() +{ + // ImageView can relayout in the OnImageReady, alternative to a signal would be to have a upcall from the Control to ImageView + Dali::Toolkit::Control handle( GetOwner() ); + handle.ResourceReadySignal().Connect( this, &ImageView::OnResourceReady ); +} + void ImageView::SetImage( Image image ) { // Don't bother comparing if we had a visual previously, just drop old visual and create new one @@ -94,10 +101,24 @@ void ImageView::SetImage( Image image ) mUrl.clear(); mPropertyMap.Clear(); - mVisual = Toolkit::VisualFactory::Get().CreateVisual( image ); - DevelControl::RegisterVisual( *this, Toolkit::ImageView::Property::IMAGE, mVisual ); + Toolkit::Visual::Base visual = Toolkit::VisualFactory::Get().CreateVisual( image ); + if( visual ) + { + if( !mVisual ) + { + mVisual = visual; + } + + DevelControl::RegisterVisual( *this, Toolkit::ImageView::Property::IMAGE, visual ); + } + else + { + // Unregister the exsiting visual + DevelControl::UnregisterVisual( *this, Toolkit::ImageView::Property::IMAGE ); - RelayoutRequest(); + // Trigger a size negotiation request that may be needed when unregistering a visual. + RelayoutRequest(); + } } void ImageView::SetImage( const Property::Map& map ) @@ -107,10 +128,25 @@ void ImageView::SetImage( const Property::Map& map ) mUrl.clear(); mImage.Reset(); - mVisual = Toolkit::VisualFactory::Get().CreateVisual( mPropertyMap ); - DevelControl::RegisterVisual( *this, Toolkit::ImageView::Property::IMAGE, mVisual ); + Toolkit::Visual::Base visual = Toolkit::VisualFactory::Get().CreateVisual( mPropertyMap ); + if( visual ) + { + // Don't set mVisual until it is ready and shown. Getters will still use current visual. + if( !mVisual ) + { + mVisual = visual; + } + + DevelControl::RegisterVisual( *this, Toolkit::ImageView::Property::IMAGE, visual ); + } + else + { + // Unregister the exsiting visual + DevelControl::UnregisterVisual( *this, Toolkit::ImageView::Property::IMAGE ); - RelayoutRequest(); + // Trigger a size negotiation request that may be needed when unregistering a visual. + RelayoutRequest(); + } } void ImageView::SetImage( const std::string& url, ImageDimensions size ) @@ -120,10 +156,25 @@ void ImageView::SetImage( const std::string& url, ImageDimensions size ) mImage.Reset(); mPropertyMap.Clear(); - mVisual = Toolkit::VisualFactory::Get().CreateVisual( url, size ); - DevelControl::RegisterVisual( *this, Toolkit::ImageView::Property::IMAGE, mVisual ); + // Don't set mVisual until it is ready and shown. Getters will still use current visual. + Toolkit::Visual::Base visual = Toolkit::VisualFactory::Get().CreateVisual( url, size ); + if( visual ) + { + if( !mVisual ) + { + mVisual = visual; + } + + DevelControl::RegisterVisual( *this, Toolkit::ImageView::Property::IMAGE, visual ); + } + else + { + // Unregister the exsiting visual + DevelControl::UnregisterVisual( *this, Toolkit::ImageView::Property::IMAGE ); - RelayoutRequest(); + // Trigger a size negotiation request that may be needed when unregistering a visual. + RelayoutRequest(); + } } Image ImageView::GetImage() const @@ -162,6 +213,12 @@ Vector3 ImageView::GetNaturalSize() { Vector2 rendererNaturalSize; mVisual.GetNaturalSize( rendererNaturalSize ); + + Extents padding; + padding = Self().GetProperty( Toolkit::Control::Property::PADDING ); + + rendererNaturalSize.width += ( padding.start + padding.end ); + rendererNaturalSize.height += ( padding.top + padding.bottom ); return Vector3( rendererNaturalSize ); } @@ -171,25 +228,31 @@ Vector3 ImageView::GetNaturalSize() float ImageView::GetHeightForWidth( float width ) { + Extents padding; + padding = Self().GetProperty( Toolkit::Control::Property::PADDING ); + if( mVisual ) { - return mVisual.GetHeightForWidth( width ); + return mVisual.GetHeightForWidth( width ) + padding.top + padding.bottom; } else { - return Control::GetHeightForWidth( width ); + return Control::GetHeightForWidth( width ) + padding.top + padding.bottom; } } float ImageView::GetWidthForHeight( float height ) { + Extents padding; + padding = Self().GetProperty( Toolkit::Control::Property::PADDING ); + if( mVisual ) { - return mVisual.GetWidthForHeight( height ); + return mVisual.GetWidthForHeight( height ) + padding.start + padding.end; } else { - return Control::GetWidthForHeight( height ); + return Control::GetWidthForHeight( height ) + padding.start + padding.end; } } @@ -199,12 +262,30 @@ void ImageView::OnRelayout( const Vector2& size, RelayoutContainer& container ) if( mVisual ) { - // Pass in an empty map which uses default transform values meaning our visual fills the control + Extents padding; + padding = Self().GetProperty( Toolkit::Control::Property::PADDING ); + + Property::Map transformMap = Property::Map(); + + if( ( padding.start != 0 ) || ( padding.end != 0 ) || ( padding.top != 0 ) || ( padding.bottom != 0 ) ) + { + transformMap.Add( Toolkit::Visual::Transform::Property::OFFSET, Vector2( padding.start, padding.top ) ) + .Add( Toolkit::Visual::Transform::Property::OFFSET_POLICY, Vector2( Toolkit::Visual::Transform::Policy::ABSOLUTE, Toolkit::Visual::Transform::Policy::ABSOLUTE ) ) + .Add( Toolkit::Visual::Transform::Property::ORIGIN, Toolkit::Align::TOP_BEGIN ) + .Add( Toolkit::Visual::Transform::Property::ANCHOR_POINT, Toolkit::Align::TOP_BEGIN ); + } + // Should provide a transform that handles aspect ratio according to image size - mVisual.SetTransformAndSize( Property::Map(), size ); + mVisual.SetTransformAndSize( transformMap, size ); } } +void ImageView::OnResourceReady( Toolkit::Control control ) +{ + // Visual ready so update visual attached to this ImageView, following call to RelayoutRequest will use this visual. + mVisual = DevelControl::GetVisual( *this, Toolkit::ImageView::Property::IMAGE ); +} + /////////////////////////////////////////////////////////// // // Properties @@ -243,7 +324,7 @@ void ImageView::SetProperty( BaseObject* object, Property::Index index, const Pr map = value.GetMap(); if( map ) { - Property::Value* shaderValue = map->Find( Toolkit::DevelVisual::Property::SHADER, CUSTOM_SHADER ); + Property::Value* shaderValue = map->Find( Toolkit::Visual::Property::SHADER, CUSTOM_SHADER ); // set image only if property map contains image information other than custom shader if( map->Count() > 1u || !shaderValue ) {