X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=blobdiff_plain;f=dali-toolkit%2Finternal%2Fcontrols%2Fbuttons%2Fradio-button-impl.cpp;h=c20fe2365a566a91d95aa20f34c15dc2eb4929a0;hp=142dba1b241ea0d29fc4766b6d596d53e6ad52e0;hb=e5dbcae1f8ee31b14d675793ab86161eeeefb029;hpb=e1c67e5c294862493a3ac0fd1dd0f442e8bf0af8 diff --git a/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp b/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp index 142dba1..c20fe23 100644 --- a/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp +++ b/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp @@ -20,9 +20,14 @@ #include "radio-button-impl.h" // EXTERNAL INCLUDES +#include #include #include +#if defined(DEBUG_ENABLED) + extern Debug::Filter* gLogButtonFilter; +#endif + namespace Dali { @@ -42,12 +47,6 @@ BaseHandle Create() TypeRegistration typeRegistration( typeid( Toolkit::RadioButton ), typeid( Toolkit::Button ), Create); -const char* const UNSELECTED_BUTTON_IMAGE_DIR = DALI_IMAGE_DIR "radio-button-unselected.png"; -const char* const SELECTED_BUTTON_IMAGE_DIR = DALI_IMAGE_DIR "radio-button-selected.png"; -const char* const DISABLED_UNSELECTED_BUTTON_IMAGE_DIR = DALI_IMAGE_DIR "radio-button-unselected-disabled.png"; -const char* const DISABLED_SELECTED_BUTTON_IMAGE_DIR = DALI_IMAGE_DIR "radio-button-selected-disabled.png"; - -const float DISTANCE_BETWEEN_IMAGE_AND_LABEL( 5.0f ); } Dali::Toolkit::RadioButton RadioButton::New() @@ -77,105 +76,47 @@ RadioButton::~RadioButton() void RadioButton::OnInitialize() { Button::OnInitialize(); - - Actor self = Self(); - - // Wrap size of radio button around all its children - self.SetResizePolicy( ResizePolicy::FIT_TO_CHILDREN, Dimension::ALL_DIMENSIONS ); - - SetUnselectedImage( UNSELECTED_BUTTON_IMAGE_DIR ); - SetSelectedImage( SELECTED_BUTTON_IMAGE_DIR ); - SetDisabledImage( DISABLED_UNSELECTED_BUTTON_IMAGE_DIR ); - SetDisabledSelectedImage( DISABLED_SELECTED_BUTTON_IMAGE_DIR ); - - RelayoutRequest(); } void RadioButton::OnButtonUp() { - if( ButtonDown == GetState() ) - { - // Don't allow selection on an already selected radio button - if( !IsSelected() ) - { - SetSelected( !IsSelected() ); - } - } -} - -void RadioButton::OnLabelSet( bool noPadding ) -{ - Actor& label = GetLabelActor(); + DALI_LOG_INFO( gLogButtonFilter, Debug::Verbose, "RadioButton::OnStateChange selecting:%s\n", ( (!IsSelected())?"true":"false" ) ); - if( label ) + // Don't allow un-selection on an already selected radio button, can only un-select by selecting a sibling radio button + if( !IsSelected() ) { - label.SetParentOrigin( ParentOrigin::CENTER_LEFT ); - label.SetAnchorPoint( AnchorPoint::CENTER_LEFT ); - - // Radio button width is FIT_TO_CHILDREN, so the label must have a sensible policy to fill out the space - if( label.GetResizePolicy( Dimension::WIDTH ) == ResizePolicy::FILL_TO_PARENT ) - { - label.SetResizePolicy( ResizePolicy::USE_NATURAL_SIZE, Dimension::WIDTH ); - } - - if( IsSelected() && GetSelectedImage() ) - { - label.SetX( GetSelectedImage().GetNaturalSize().width + DISTANCE_BETWEEN_IMAGE_AND_LABEL ); - } - else if( GetUnselectedImage() ) - { - label.SetX( GetUnselectedImage().GetNaturalSize().width + DISTANCE_BETWEEN_IMAGE_AND_LABEL ); - } - else - { - label.SetX( DISTANCE_BETWEEN_IMAGE_AND_LABEL ); - } + SetSelected( !IsSelected() ); } } -void RadioButton::OnSelected() +void RadioButton::OnStateChange( State newState ) { - Actor& label = GetLabelActor(); - - PaintState paintState = GetPaintState(); - switch( paintState ) - { - case UnselectedState: - { - Actor parent = Self().GetParent(); - if( parent ) - { - for( unsigned int i = 0; i < parent.GetChildCount(); ++i ) - { - Dali::Toolkit::RadioButton radioButtonChild = Dali::Toolkit::RadioButton::DownCast( parent.GetChildAt( i ) ); - if( radioButtonChild && radioButtonChild != Self() ) - { - radioButtonChild.SetSelected( false ); - } - } - } - - Actor& selectedImage = GetSelectedImage(); - if( label && selectedImage ) - { - label.SetX( selectedImage.GetNaturalSize().width + DISTANCE_BETWEEN_IMAGE_AND_LABEL ); - } - break; - } - case SelectedState: - { - Actor& buttonImage = GetUnselectedImage(); - if( label && buttonImage ) - { - label.SetX( buttonImage.GetNaturalSize().width + DISTANCE_BETWEEN_IMAGE_AND_LABEL ); - } - break; - } - default: - { - break; - } - } + // Radio button can be part of a group, if a button in the group is selected then all others should be unselected + DALI_LOG_INFO( gLogButtonFilter, Debug::Verbose, "RadioButton::OnStateChange state(%d)\n", newState ); + + switch( newState ) + { + case SELECTED_STATE: + { + Actor parent = Self().GetParent(); + if( parent ) + { + for( unsigned int i = 0; i < parent.GetChildCount(); ++i ) + { + Dali::Toolkit::RadioButton radioButtonChild = Dali::Toolkit::RadioButton::DownCast( parent.GetChildAt( i ) ); + if( radioButtonChild && radioButtonChild != Self() ) + { + radioButtonChild.SetSelected( false ); + } + } + } + } + + default: + { + break; + } + } } } // namespace Internal