X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=blobdiff_plain;f=dali-toolkit%2Finternal%2Fcontrols%2Fbuttons%2Fradio-button-impl.cpp;h=4b4e0708357cb7fcf31a4c428d1c7a3845081d8f;hp=c20fe2365a566a91d95aa20f34c15dc2eb4929a0;hb=f4b327350bf7873847f8f08bb27d11361f60f759;hpb=e5dbcae1f8ee31b14d675793ab86161eeeefb029 diff --git a/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp b/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp index c20fe23..4b4e070 100644 --- a/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp +++ b/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp @@ -15,44 +15,38 @@ * */ - // CLASS HEADER #include "radio-button-impl.h" // EXTERNAL INCLUDES #include #include -#include #if defined(DEBUG_ENABLED) - extern Debug::Filter* gLogButtonFilter; +extern Debug::Filter* gLogButtonFilter; #endif namespace Dali { - namespace Toolkit { - namespace Internal { - namespace { - BaseHandle Create() { return Toolkit::RadioButton::New(); } -TypeRegistration typeRegistration( typeid( Toolkit::RadioButton ), typeid( Toolkit::Button ), Create); +TypeRegistration typeRegistration(typeid(Toolkit::RadioButton), typeid(Toolkit::Button), Create); -} +} // namespace Dali::Toolkit::RadioButton RadioButton::New() { // Create the implementation, temporarily owned on stack - IntrusivePtr< RadioButton > internalRadioButton = new RadioButton(); + IntrusivePtr internalRadioButton = new RadioButton(); // Pass ownership to CustomActor Dali::Toolkit::RadioButton radioButton(*internalRadioButton); @@ -76,47 +70,60 @@ RadioButton::~RadioButton() void RadioButton::OnInitialize() { Button::OnInitialize(); + + DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { + return std::unique_ptr( + new AccessibleImpl(actor, Dali::Accessibility::Role::RADIO_BUTTON)); + }); } -void RadioButton::OnButtonUp() +bool RadioButton::OnToggleReleased() { - DALI_LOG_INFO( gLogButtonFilter, Debug::Verbose, "RadioButton::OnStateChange selecting:%s\n", ( (!IsSelected())?"true":"false" ) ); + // Radio button overrides toggle release (button up) as doesn't allow un-selection to be performed on it directly. + return false; +} - // Don't allow un-selection on an already selected radio button, can only un-select by selecting a sibling radio button - if( !IsSelected() ) +void RadioButton::OnStateChange(State newState) +{ + // Radio button can be part of a group, if a button in the group is selected then all others should be unselected + DALI_LOG_INFO(gLogButtonFilter, Debug::Verbose, "RadioButton::OnStateChange state(%d)\n", newState); + + if(SELECTED_STATE == newState) { - SetSelected( !IsSelected() ); + Actor parent = Self().GetParent(); + if(parent) + { + for(unsigned int i = 0; i < parent.GetChildCount(); ++i) + { + Dali::Toolkit::RadioButton radioButtonChild = Dali::Toolkit::RadioButton::DownCast(parent.GetChildAt(i)); + if(radioButtonChild && radioButtonChild != Self()) + { + radioButtonChild.SetProperty(Toolkit::Button::Property::SELECTED, false); + } + } + } + } + + // TODO: replace it with OnPropertySet hook once Button::Property::SELECTED will be consistently used + if(Dali::Accessibility::IsUp() && (Dali::Accessibility::Accessible::GetCurrentlyHighlightedActor() == Self()) + && (newState == SELECTED_STATE || newState == UNSELECTED_STATE)) + { + Dali::Accessibility::Accessible::Get(Self())->EmitStateChanged(Dali::Accessibility::State::CHECKED, newState == SELECTED_STATE ? 1 : 0, 0); } } -void RadioButton::OnStateChange( State newState ) +Dali::Accessibility::States RadioButton::AccessibleImpl::CalculateStates() { - // Radio button can be part of a group, if a button in the group is selected then all others should be unselected - DALI_LOG_INFO( gLogButtonFilter, Debug::Verbose, "RadioButton::OnStateChange state(%d)\n", newState ); - - switch( newState ) - { - case SELECTED_STATE: - { - Actor parent = Self().GetParent(); - if( parent ) - { - for( unsigned int i = 0; i < parent.GetChildCount(); ++i ) - { - Dali::Toolkit::RadioButton radioButtonChild = Dali::Toolkit::RadioButton::DownCast( parent.GetChildAt( i ) ); - if( radioButtonChild && radioButtonChild != Self() ) - { - radioButtonChild.SetSelected( false ); - } - } - } - } - - default: - { - break; - } - } + auto state = Button::AccessibleImpl::CalculateStates(); + auto self = Toolkit::Button::DownCast(Self()); + + if(self.GetProperty(Toolkit::Button::Property::SELECTED)) + { + state[Dali::Accessibility::State::CHECKED] = true; + } + + state[Dali::Accessibility::State::SELECTABLE] = true; + return state; } } // namespace Internal