X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git;a=blobdiff_plain;f=dali-toolkit%2Finternal%2Fcontrols%2Fbuttons%2Fradio-button-impl.cpp;h=4b4e0708357cb7fcf31a4c428d1c7a3845081d8f;hp=1e51ce3259ee49859a597a320f7f2ab57c0ba375;hb=19179e76939a18697e6919177a4c561586e8d30b;hpb=0d7ddec50cf09372fb2a830c6e8cdc7af70d362f diff --git a/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp b/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp index 1e51ce3..4b4e070 100644 --- a/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp +++ b/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp @@ -15,45 +15,38 @@ * */ - // CLASS HEADER #include "radio-button-impl.h" // EXTERNAL INCLUDES +#include #include -#include + +#if defined(DEBUG_ENABLED) +extern Debug::Filter* gLogButtonFilter; +#endif namespace Dali { - namespace Toolkit { - namespace Internal { - namespace { - BaseHandle Create() { return Toolkit::RadioButton::New(); } -TypeRegistration typeRegistration( typeid( Toolkit::RadioButton ), typeid( Toolkit::Button ), Create); +TypeRegistration typeRegistration(typeid(Toolkit::RadioButton), typeid(Toolkit::Button), Create); -const char* const UNSELECTED_BUTTON_IMAGE_DIR = DALI_IMAGE_DIR "radio-button-unselected.png"; -const char* const SELECTED_BUTTON_IMAGE_DIR = DALI_IMAGE_DIR "radio-button-selected.png"; -const char* const DISABLED_UNSELECTED_BUTTON_IMAGE_DIR = DALI_IMAGE_DIR "radio-button-unselected-disabled.png"; -const char* const DISABLED_SELECTED_BUTTON_IMAGE_DIR = DALI_IMAGE_DIR "radio-button-selected-disabled.png"; - -const float DISTANCE_BETWEEN_IMAGE_AND_LABEL( 5.0f ); -} +} // namespace Dali::Toolkit::RadioButton RadioButton::New() { // Create the implementation, temporarily owned on stack - IntrusivePtr< RadioButton > internalRadioButton = new RadioButton(); + IntrusivePtr internalRadioButton = new RadioButton(); // Pass ownership to CustomActor Dali::Toolkit::RadioButton radioButton(*internalRadioButton); @@ -74,111 +67,63 @@ RadioButton::~RadioButton() { } -void RadioButton::OnButtonInitialize() +void RadioButton::OnInitialize() { - Actor self = Self(); - - // Wrap size of radio button around all its children - self.SetResizePolicy( ResizePolicy::FIT_TO_CHILDREN, Dimension::ALL_DIMENSIONS ); - - Image buttonImage = Dali::ResourceImage::New( UNSELECTED_BUTTON_IMAGE_DIR, ResourceImage::ON_DEMAND, ResourceImage::NEVER ); - Image selectedImage = Dali::ResourceImage::New( SELECTED_BUTTON_IMAGE_DIR, ResourceImage::ON_DEMAND, ResourceImage::NEVER ); - Image disabledImage = Dali::ResourceImage::New( DISABLED_UNSELECTED_BUTTON_IMAGE_DIR, ResourceImage::ON_DEMAND, ResourceImage::NEVER ); - Image disabledSelectedImage = Dali::ResourceImage::New( DISABLED_SELECTED_BUTTON_IMAGE_DIR, ResourceImage::ON_DEMAND, ResourceImage::NEVER ); - - SetButtonImage( ImageActor::New( buttonImage ) ); - SetSelectedImage( ImageActor::New( selectedImage ) ); - SetDisabledImage( ImageActor::New( disabledImage ) ); - SetDisabledSelectedImage( ImageActor::New( disabledSelectedImage ) ); + Button::OnInitialize(); - RelayoutRequest(); + DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { + return std::unique_ptr( + new AccessibleImpl(actor, Dali::Accessibility::Role::RADIO_BUTTON)); + }); } -void RadioButton::OnButtonUp() +bool RadioButton::OnToggleReleased() { - if( ButtonDown == GetState() ) - { - // Don't allow selection on an already selected radio button - if( !IsSelected() ) - { - SetSelected( !IsSelected() ); - } - } + // Radio button overrides toggle release (button up) as doesn't allow un-selection to be performed on it directly. + return false; } -void RadioButton::OnLabelSet() +void RadioButton::OnStateChange(State newState) { - Actor& label = GetLabel(); + // Radio button can be part of a group, if a button in the group is selected then all others should be unselected + DALI_LOG_INFO(gLogButtonFilter, Debug::Verbose, "RadioButton::OnStateChange state(%d)\n", newState); - if( label ) + if(SELECTED_STATE == newState) { - label.SetParentOrigin( ParentOrigin::CENTER_LEFT ); - label.SetAnchorPoint( AnchorPoint::CENTER_LEFT ); - - // Radio button width is FIT_TO_CHILDREN, so the label must have a sensible policy to fill out the space - if( label.GetResizePolicy( Dimension::WIDTH ) == ResizePolicy::FILL_TO_PARENT ) + Actor parent = Self().GetParent(); + if(parent) { - label.SetResizePolicy( ResizePolicy::USE_NATURAL_SIZE, Dimension::WIDTH ); + for(unsigned int i = 0; i < parent.GetChildCount(); ++i) + { + Dali::Toolkit::RadioButton radioButtonChild = Dali::Toolkit::RadioButton::DownCast(parent.GetChildAt(i)); + if(radioButtonChild && radioButtonChild != Self()) + { + radioButtonChild.SetProperty(Toolkit::Button::Property::SELECTED, false); + } + } } + } - if( IsSelected() && GetSelectedImage() ) - { - label.SetX( GetSelectedImage().GetNaturalSize().width + DISTANCE_BETWEEN_IMAGE_AND_LABEL ); - } - else if( GetButtonImage() ) - { - label.SetX( GetButtonImage().GetNaturalSize().width + DISTANCE_BETWEEN_IMAGE_AND_LABEL ); - } - else - { - label.SetX( DISTANCE_BETWEEN_IMAGE_AND_LABEL ); - } + // TODO: replace it with OnPropertySet hook once Button::Property::SELECTED will be consistently used + if(Dali::Accessibility::IsUp() && (Dali::Accessibility::Accessible::GetCurrentlyHighlightedActor() == Self()) + && (newState == SELECTED_STATE || newState == UNSELECTED_STATE)) + { + Dali::Accessibility::Accessible::Get(Self())->EmitStateChanged(Dali::Accessibility::State::CHECKED, newState == SELECTED_STATE ? 1 : 0, 0); } } -void RadioButton::OnSelected() +Dali::Accessibility::States RadioButton::AccessibleImpl::CalculateStates() { - Actor& label = GetLabel(); + auto state = Button::AccessibleImpl::CalculateStates(); + auto self = Toolkit::Button::DownCast(Self()); - PaintState paintState = GetPaintState(); - switch( paintState ) + if(self.GetProperty(Toolkit::Button::Property::SELECTED)) { - case UnselectedState: - { - Actor parent = Self().GetParent(); - if( parent ) - { - for( unsigned int i = 0; i < parent.GetChildCount(); ++i ) - { - Dali::Toolkit::RadioButton radioButtonChild = Dali::Toolkit::RadioButton::DownCast( parent.GetChildAt( i ) ); - if( radioButtonChild && radioButtonChild != Self() ) - { - radioButtonChild.SetSelected( false ); - } - } - } - - Actor& selectedImage = GetSelectedImage(); - if( label && selectedImage ) - { - label.SetX( selectedImage.GetNaturalSize().width + DISTANCE_BETWEEN_IMAGE_AND_LABEL ); - } - break; - } - case SelectedState: - { - Actor& buttonImage = GetButtonImage(); - if( label && buttonImage ) - { - label.SetX( buttonImage.GetNaturalSize().width + DISTANCE_BETWEEN_IMAGE_AND_LABEL ); - } - break; - } - default: - { - break; - } + state[Dali::Accessibility::State::CHECKED] = true; } + + state[Dali::Accessibility::State::SELECTABLE] = true; + return state; } } // namespace Internal