Promote Control::Impl::AccessibleImpl to DevelControl
[platform/core/uifw/dali-toolkit.git] / dali-toolkit / internal / controls / image-view / image-view-impl.cpp
index 4183b89..513960f 100644 (file)
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 Samsung Electronics Co., Ltd.
+ * Copyright (c) 2021 Samsung Electronics Co., Ltd.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
 #include "image-view-impl.h"
 
 // EXTERNAL INCLUDES
-#include <dali/public-api/images/resource-image.h>
-#include <dali/public-api/object/type-registry.h>
-#include <dali/public-api/object/type-registry-helper.h>
 #include <dali/devel-api/scripting/scripting.h>
+#include <dali/public-api/object/type-registry-helper.h>
+#include <dali/public-api/object/type-registry.h>
 
 // INTERNAL INCLUDES
-#include <dali-toolkit/public-api/controls/image-view/image-view.h>
 #include <dali-toolkit/devel-api/controls/control-devel.h>
-#include <dali-toolkit/devel-api/visuals/visual-properties-devel.h>
 #include <dali-toolkit/devel-api/visual-factory/visual-factory.h>
-#include <dali-toolkit/internal/visuals/visual-string-constants.h>
-#include <dali-toolkit/internal/visuals/visual-base-impl.h>
+#include <dali-toolkit/internal/controls/control/control-data-impl.h>
 #include <dali-toolkit/internal/visuals/visual-base-data-impl.h>
+#include <dali-toolkit/internal/visuals/visual-base-impl.h>
+#include <dali-toolkit/internal/visuals/visual-string-constants.h>
+#include <dali-toolkit/public-api/controls/image-view/image-view.h>
+#include <dali-toolkit/public-api/visuals/visual-properties.h>
 
 namespace Dali
 {
-
 namespace Toolkit
 {
-
 namespace Internal
 {
-
 namespace
 {
+const Vector4 FULL_TEXTURE_RECT(0.f, 0.f, 1.f, 1.f);
 
 BaseHandle Create()
 {
@@ -51,12 +49,11 @@ BaseHandle Create()
 }
 
 // Setup properties, signals and actions using the type-registry.
-DALI_TYPE_REGISTRATION_BEGIN( Toolkit::ImageView, Toolkit::Control, Create );
-DALI_PROPERTY_REGISTRATION( Toolkit, ImageView, "resourceUrl", STRING, RESOURCE_URL )
-DALI_PROPERTY_REGISTRATION( Toolkit, ImageView, "image", MAP, IMAGE )
-DALI_PROPERTY_REGISTRATION( Toolkit, ImageView, "preMultipliedAlpha", BOOLEAN, PRE_MULTIPLIED_ALPHA )
+DALI_TYPE_REGISTRATION_BEGIN(Toolkit::ImageView, Toolkit::Control, Create);
+DALI_PROPERTY_REGISTRATION(Toolkit, ImageView, "image", MAP, IMAGE)
+DALI_PROPERTY_REGISTRATION(Toolkit, ImageView, "preMultipliedAlpha", BOOLEAN, PRE_MULTIPLIED_ALPHA)
 
-DALI_ANIMATABLE_PROPERTY_REGISTRATION_WITH_DEFAULT( Toolkit, ImageView, "pixelArea", Vector4(0.f, 0.f, 1.f, 1.f), PIXEL_AREA )
+DALI_ANIMATABLE_PROPERTY_REGISTRATION_WITH_DEFAULT(Toolkit, ImageView, "pixelArea", Vector4(0.f, 0.f, 1.f, 1.f), PIXEL_AREA)
 DALI_TYPE_REGISTRATION_END()
 
 } // anonymous namespace
@@ -64,7 +61,10 @@ DALI_TYPE_REGISTRATION_END()
 using namespace Dali;
 
 ImageView::ImageView()
-: Control( ControlBehaviour( CONTROL_BEHAVIOUR_DEFAULT ) )
+: Control(ControlBehaviour(CONTROL_BEHAVIOUR_DEFAULT)),
+  mImageSize(),
+  mImageVisualPaddingSetByTransform(false),
+  mImageViewPixelAreaSetByFittingMode(false)
 {
 }
 
@@ -76,7 +76,7 @@ Toolkit::ImageView ImageView::New()
 {
   ImageView* impl = new ImageView();
 
-  Toolkit::ImageView handle = Toolkit::ImageView( *impl );
+  Toolkit::ImageView handle = Toolkit::ImageView(*impl);
 
   // Second-phase init of the implementation
   // This can only be done after the CustomActor connection has been made...
@@ -90,143 +90,334 @@ Toolkit::ImageView ImageView::New()
 void ImageView::OnInitialize()
 {
   // ImageView can relayout in the OnImageReady, alternative to a signal would be to have a upcall from the Control to ImageView
-  Dali::Toolkit::Control handle( GetOwner() );
-  Toolkit::DevelControl::ResourceReadySignal( handle ).Connect( this, &ImageView::OnResourceReady );
-}
+  Dali::Toolkit::Control handle(GetOwner());
+  handle.ResourceReadySignal().Connect(this, &ImageView::OnResourceReady);
 
-void ImageView::SetImage( Image image )
-{
-  // Don't bother comparing if we had a visual previously, just drop old visual and create new one
-  mImage = image;
-  mUrl.clear();
-  mPropertyMap.Clear();
-
-  Toolkit::Visual::Base visual =  Toolkit::VisualFactory::Get().CreateVisual( image );
-  if (!mVisual)
-  {
-    mVisual = visual;
-  }
+  DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) {
+    return std::unique_ptr<Dali::Accessibility::Accessible>(
+      new DevelControl::AccessibleImpl(actor, Dali::Accessibility::Role::IMAGE));
+  });
 
-  DevelControl::RegisterVisual( *this, Toolkit::ImageView::Property::IMAGE, visual  );
+  //Enable highightability
+  Self().SetProperty(Toolkit::DevelControl::Property::ACCESSIBILITY_HIGHLIGHTABLE, true);
 }
 
-void ImageView::SetImage( const Property::Map& map )
+void ImageView::SetImage(const Property::Map& map)
 {
   // Comparing a property map is too expensive so just creating a new visual
   mPropertyMap = map;
   mUrl.clear();
-  mImage.Reset();
-  Toolkit::Visual::Base visual =  Toolkit::VisualFactory::Get().CreateVisual( mPropertyMap );
-  // Don't set mVisual until it is ready and shown. Getters will still use current visual.
-  if (!mVisual)
+
+  Toolkit::Visual::Base visual = Toolkit::VisualFactory::Get().CreateVisual(mPropertyMap);
+  if(visual)
   {
-    mVisual = visual;
+    // Don't set mVisual until it is ready and shown. Getters will still use current visual.
+    if(!mVisual)
+    {
+      mVisual = visual;
+    }
+
+    if(!mShaderMap.Empty())
+    {
+      Internal::Visual::Base& visualImpl = Toolkit::GetImplementation(visual);
+      visualImpl.SetCustomShader(mShaderMap);
+    }
+
+    DevelControl::RegisterVisual(*this, Toolkit::ImageView::Property::IMAGE, visual);
   }
+  else
+  {
+    // Unregister the exsiting visual
+    DevelControl::UnregisterVisual(*this, Toolkit::ImageView::Property::IMAGE);
 
-  DevelControl::RegisterVisual( *this, Toolkit::ImageView::Property::IMAGE, visual  );
+    // Trigger a size negotiation request that may be needed when unregistering a visual.
+    RelayoutRequest();
+  }
+
+  // Signal that a Relayout may be needed
 }
 
-void ImageView::SetImage( const std::string& url, ImageDimensions size )
+void ImageView::SetImage(const std::string& url, ImageDimensions size)
 {
   // Don't bother comparing if we had a visual previously, just drop old visual and create new one
-  mUrl = url;
-  mImage.Reset();
+  mUrl       = url;
+  mImageSize = size;
   mPropertyMap.Clear();
 
   // Don't set mVisual until it is ready and shown. Getters will still use current visual.
-  Toolkit::Visual::Base visual =  Toolkit::VisualFactory::Get().CreateVisual( url, size );
-  if (!mVisual)
+  Toolkit::Visual::Base visual = Toolkit::VisualFactory::Get().CreateVisual(url, size);
+  if(visual)
   {
-    mVisual = visual;
+    if(!mVisual)
+    {
+      mVisual = visual;
+    }
+
+    if(!mShaderMap.Empty())
+    {
+      Internal::Visual::Base& visualImpl = Toolkit::GetImplementation(visual);
+      visualImpl.SetCustomShader(mShaderMap);
+    }
+
+    DevelControl::RegisterVisual(*this, Toolkit::ImageView::Property::IMAGE, visual);
   }
+  else
+  {
+    // Unregister the exsiting visual
+    DevelControl::UnregisterVisual(*this, Toolkit::ImageView::Property::IMAGE);
 
-  DevelControl::RegisterVisual( *this, Toolkit::ImageView::Property::IMAGE, visual );
-}
+    // Trigger a size negotiation request that may be needed when unregistering a visual.
+    RelayoutRequest();
+  }
 
-Image ImageView::GetImage() const
-{
-  return mImage;
+  // Signal that a Relayout may be needed
 }
 
-void ImageView::EnablePreMultipliedAlpha( bool preMultipled )
+void ImageView::EnablePreMultipliedAlpha(bool preMultipled)
 {
-  if( mVisual )
+  if(mVisual)
   {
-    Toolkit::GetImplementation( mVisual ).EnablePreMultipliedAlpha( preMultipled );
+    Toolkit::GetImplementation(mVisual).EnablePreMultipliedAlpha(preMultipled);
   }
 }
 
 bool ImageView::IsPreMultipliedAlphaEnabled() const
 {
-  if( mVisual )
+  if(mVisual)
   {
-    return Toolkit::GetImplementation( mVisual ).IsPreMultipliedAlphaEnabled();
+    return Toolkit::GetImplementation(mVisual).IsPreMultipliedAlphaEnabled();
   }
   return false;
 }
 
-void ImageView::SetDepthIndex( int depthIndex )
+void ImageView::SetDepthIndex(int depthIndex)
 {
-  if( mVisual )
+  if(mVisual)
   {
-    mVisual.SetDepthIndex( depthIndex );
+    mVisual.SetDepthIndex(depthIndex);
   }
 }
 
 Vector3 ImageView::GetNaturalSize()
 {
-  if( mVisual )
+  if(mVisual)
   {
     Vector2 rendererNaturalSize;
-    mVisual.GetNaturalSize( rendererNaturalSize );
-    return Vector3( rendererNaturalSize );
+    mVisual.GetNaturalSize(rendererNaturalSize);
+
+    Extents padding;
+    padding = Self().GetProperty<Extents>(Toolkit::Control::Property::PADDING);
+
+    rendererNaturalSize.width += (padding.start + padding.end);
+    rendererNaturalSize.height += (padding.top + padding.bottom);
+    return Vector3(rendererNaturalSize);
   }
 
   // if no visual then use Control's natural size
   return Control::GetNaturalSize();
 }
 
-float ImageView::GetHeightForWidth( float width )
+float ImageView::GetHeightForWidth(float width)
 {
-  if( mVisual )
+  Extents padding;
+  padding = Self().GetProperty<Extents>(Toolkit::Control::Property::PADDING);
+
+  if(mVisual)
   {
-    return mVisual.GetHeightForWidth( width );
+    return mVisual.GetHeightForWidth(width) + padding.top + padding.bottom;
   }
   else
   {
-    return Control::GetHeightForWidth( width );
+    return Control::GetHeightForWidth(width) + padding.top + padding.bottom;
   }
 }
 
-float ImageView::GetWidthForHeight( float height )
+float ImageView::GetWidthForHeight(float height)
 {
-  if( mVisual )
+  Extents padding;
+  padding = Self().GetProperty<Extents>(Toolkit::Control::Property::PADDING);
+
+  if(mVisual)
   {
-    return mVisual.GetWidthForHeight( height );
+    return mVisual.GetWidthForHeight(height) + padding.start + padding.end;
   }
   else
   {
-    return Control::GetWidthForHeight( height );
+    return Control::GetWidthForHeight(height) + padding.start + padding.end;
   }
 }
 
-void ImageView::OnRelayout( const Vector2& size, RelayoutContainer& container )
+void ImageView::OnRelayout(const Vector2& size, RelayoutContainer& container)
 {
-  Control::OnRelayout( size, container );
+  Control::OnRelayout(size, container);
+  if(mVisual)
+  {
+    Property::Map transformMap = Property::Map();
+
+    Extents padding = Self().GetProperty<Extents>(Toolkit::Control::Property::PADDING);
 
-  // If visual is being replaced then mVisual will be the replacement visual even if not ready.
-  mVisual = DevelControl::GetVisual( *this, Toolkit::ImageView::Property::IMAGE );
+    bool zeroPadding = (padding == Extents());
+
+    Vector2 naturalSize;
+    mVisual.GetNaturalSize(naturalSize);
+
+    Dali::LayoutDirection::Type layoutDirection = static_cast<Dali::LayoutDirection::Type>(
+      Self().GetProperty(Dali::Actor::Property::LAYOUT_DIRECTION).Get<int>());
+    if(Dali::LayoutDirection::RIGHT_TO_LEFT == layoutDirection)
+    {
+      std::swap(padding.start, padding.end);
+    }
 
-  if( mVisual )
+    // remove padding from the size to know how much is left for the visual
+    Vector2 finalSize   = size - Vector2(padding.start + padding.end, padding.top + padding.bottom);
+    Vector2 finalOffset = Vector2(padding.start, padding.top);
+
+    ApplyFittingMode(finalSize, naturalSize, finalOffset, zeroPadding, transformMap);
+
+    mVisual.SetTransformAndSize(transformMap, size);
+
+    // mVisual is not updated util the resource is ready in the case of visual replacement.
+    // in this case, the Property Map must be initialized so that the previous value is not reused.
+    // after mVisual is updated, the correct value will be reset.
+    Toolkit::Visual::Base visual = DevelControl::GetVisual(*this, Toolkit::ImageView::Property::IMAGE);
+    if(visual && visual != mVisual)
+    {
+      visual.SetTransformAndSize(Property::Map(), size);
+    }
+  }
+}
+
+void ImageView::OnResourceReady(Toolkit::Control control)
+{
+  // Visual ready so update visual attached to this ImageView, following call to RelayoutRequest will use this visual.
+  mVisual = DevelControl::GetVisual(*this, Toolkit::ImageView::Property::IMAGE);
+  // Signal that a Relayout may be needed
+}
+
+void ImageView::SetTransformMapForFittingMode(Vector2 finalSize, Vector2 naturalSize, Vector2 finalOffset, Visual::FittingMode fittingMode, Property::Map& transformMap)
+{
+  switch(fittingMode)
   {
-    // Pass in an empty map which uses default transform values meaning our visual fills the control
-    // Should provide a transform that handles aspect ratio according to image size
-    mVisual.SetTransformAndSize( Property::Map(), size );
+    case Visual::FittingMode::FIT_KEEP_ASPECT_RATIO:
+    {
+      auto availableVisualSize = finalSize;
+
+      // scale to fit the padded area
+      finalSize = naturalSize * std::min((naturalSize.width ? (availableVisualSize.width / naturalSize.width) : 0),
+                                         (naturalSize.height ? (availableVisualSize.height / naturalSize.height) : 0));
+
+      // calculate final offset within the padded area
+      finalOffset += (availableVisualSize - finalSize) * .5f;
+
+      // populate the transform map
+      transformMap.Add(Toolkit::Visual::Transform::Property::OFFSET, finalOffset)
+        .Add(Toolkit::Visual::Transform::Property::SIZE, finalSize);
+      break;
+    }
+    case Visual::FittingMode::OVER_FIT_KEEP_ASPECT_RATIO:
+    {
+      mImageViewPixelAreaSetByFittingMode = true;
+      auto availableVisualSize            = finalSize;
+      finalSize                           = naturalSize * std::max((naturalSize.width ? (availableVisualSize.width / naturalSize.width) : 0),
+                                         (naturalSize.height ? (availableVisualSize.height / naturalSize.height) : 0));
+
+      auto originalOffset = finalOffset;
+      finalOffset += (availableVisualSize - finalSize) * .5f;
+
+      float   x           = abs((availableVisualSize.width - finalSize.width) / finalSize.width) * .5f;
+      float   y           = abs((availableVisualSize.height - finalSize.height) / finalSize.height) * .5f;
+      float   widthRatio  = 1.f - abs((availableVisualSize.width - finalSize.width) / finalSize.width);
+      float   heightRatio = 1.f - abs((availableVisualSize.height - finalSize.height) / finalSize.height);
+      Vector4 pixelArea   = Vector4(x, y, widthRatio, heightRatio);
+      Self().SetProperty(Toolkit::ImageView::Property::PIXEL_AREA, pixelArea);
+
+      // populate the transform map
+      transformMap.Add(Toolkit::Visual::Transform::Property::OFFSET, originalOffset)
+        .Add(Toolkit::Visual::Transform::Property::SIZE, availableVisualSize);
+      break;
+    }
+    case Visual::FittingMode::CENTER:
+    {
+      auto availableVisualSize = finalSize;
+      if(availableVisualSize.width > naturalSize.width && availableVisualSize.height > naturalSize.height)
+      {
+        finalSize = naturalSize;
+      }
+      else
+      {
+        finalSize = naturalSize * std::min((naturalSize.width ? (availableVisualSize.width / naturalSize.width) : 0),
+                                           (naturalSize.height ? (availableVisualSize.height / naturalSize.height) : 0));
+      }
+
+      finalOffset += (availableVisualSize - finalSize) * .5f;
+
+      // populate the transform map
+      transformMap.Add(Toolkit::Visual::Transform::Property::OFFSET, finalOffset)
+        .Add(Toolkit::Visual::Transform::Property::SIZE, finalSize);
+      break;
+    }
+    case Visual::FittingMode::FILL:
+    {
+      transformMap.Add(Toolkit::Visual::Transform::Property::OFFSET, finalOffset)
+        .Add(Toolkit::Visual::Transform::Property::SIZE, finalSize);
+      break;
+    }
+    case Visual::FittingMode::FIT_WIDTH:
+    case Visual::FittingMode::FIT_HEIGHT:
+    {
+      // This FittingMode already converted
+      break;
+    }
   }
 }
 
-void ImageView::OnResourceReady( Toolkit::Control control )
+void ImageView::ApplyFittingMode(Vector2 finalSize, Vector2 naturalSize, Vector2 finalOffset, bool zeroPadding, Property::Map& transformMap)
 {
+  Visual::FittingMode fittingMode = Toolkit::GetImplementation(mVisual).GetFittingMode();
+
+  // Reset PIXEL_AREA after using OVER_FIT_KEEP_ASPECT_RATIO
+  if(mImageViewPixelAreaSetByFittingMode)
+  {
+    Self().SetProperty(Toolkit::ImageView::Property::PIXEL_AREA, FULL_TEXTURE_RECT);
+    mImageViewPixelAreaSetByFittingMode = false;
+  }
+
+  if((!zeroPadding) || // If padding is not zero
+     (fittingMode != Visual::FittingMode::FILL))
+  {
+    mImageVisualPaddingSetByTransform = true;
+
+    // If FittingMode use FIT_WIDTH or FIT_HEIGTH, it need to change proper fittingMode
+    if(fittingMode == Visual::FittingMode::FIT_WIDTH)
+    {
+      fittingMode = (finalSize.height / naturalSize.height) < (finalSize.width / naturalSize.width) ? Visual::FittingMode::OVER_FIT_KEEP_ASPECT_RATIO : Visual::FittingMode::FIT_KEEP_ASPECT_RATIO;
+    }
+    else if(fittingMode == Visual::FittingMode::FIT_HEIGHT)
+    {
+      fittingMode = (finalSize.height / naturalSize.height) < (finalSize.width / naturalSize.width) ? Visual::FittingMode::FIT_KEEP_ASPECT_RATIO : Visual::FittingMode::OVER_FIT_KEEP_ASPECT_RATIO;
+    }
+
+    SetTransformMapForFittingMode(finalSize, naturalSize, finalOffset, fittingMode, transformMap);
+
+    // Set extra value for applying transformMap
+    transformMap.Add(Toolkit::Visual::Transform::Property::OFFSET_POLICY,
+                     Vector2(Toolkit::Visual::Transform::Policy::ABSOLUTE, Toolkit::Visual::Transform::Policy::ABSOLUTE))
+      .Add(Toolkit::Visual::Transform::Property::ORIGIN, Toolkit::Align::TOP_BEGIN)
+      .Add(Toolkit::Visual::Transform::Property::ANCHOR_POINT, Toolkit::Align::TOP_BEGIN)
+      .Add(Toolkit::Visual::Transform::Property::SIZE_POLICY,
+           Vector2(Toolkit::Visual::Transform::Policy::ABSOLUTE, Toolkit::Visual::Transform::Policy::ABSOLUTE));
+  }
+  else if(mImageVisualPaddingSetByTransform && zeroPadding) // Reset offset to zero only if padding applied previously
+  {
+    mImageVisualPaddingSetByTransform = false;
+    // Reset the transform map
+    transformMap.Add(Toolkit::Visual::Transform::Property::OFFSET, Vector2::ZERO)
+      .Add(Toolkit::Visual::Transform::Property::OFFSET_POLICY,
+           Vector2(Toolkit::Visual::Transform::Policy::RELATIVE, Toolkit::Visual::Transform::Policy::RELATIVE))
+      .Add(Toolkit::Visual::Transform::Property::SIZE, Vector2::ONE)
+      .Add(Toolkit::Visual::Transform::Property::SIZE_POLICY,
+           Vector2(Toolkit::Visual::Transform::Policy::RELATIVE, Toolkit::Visual::Transform::Policy::RELATIVE));
+  }
 }
 
 ///////////////////////////////////////////////////////////
@@ -234,58 +425,50 @@ void ImageView::OnResourceReady( Toolkit::Control control )
 // Properties
 //
 
-void ImageView::SetProperty( BaseObject* object, Property::Index index, const Property::Value& value )
+void ImageView::SetProperty(BaseObject* object, Property::Index index, const Property::Value& value)
 {
-  Toolkit::ImageView imageView = Toolkit::ImageView::DownCast( Dali::BaseHandle( object ) );
+  Toolkit::ImageView imageView = Toolkit::ImageView::DownCast(Dali::BaseHandle(object));
 
-  if ( imageView )
+  if(imageView)
   {
-    ImageView& impl = GetImpl( imageView );
-    switch ( index )
+    ImageView& impl = GetImpl(imageView);
+    switch(index)
     {
-      case Toolkit::ImageView::Property::RESOURCE_URL:
-      {
-        std::string imageUrl;
-        if( value.Get( imageUrl ) )
-        {
-          impl.SetImage( imageUrl, ImageDimensions() );
-        }
-        break;
-      }
-
       case Toolkit::ImageView::Property::IMAGE:
       {
-        std::string imageUrl;
-        Property::Map* map;
-        if( value.Get( imageUrl ) )
+        std::string          imageUrl;
+        const Property::Map* map;
+        if(value.Get(imageUrl))
         {
-          impl.SetImage( imageUrl, ImageDimensions() );
+          impl.SetImage(imageUrl, ImageDimensions());
         }
         // if its not a string then get a Property::Map from the property if possible.
         else
         {
           map = value.GetMap();
-          if( map )
+          if(map)
           {
-            Property::Value* shaderValue = map->Find( Toolkit::DevelVisual::Property::SHADER, CUSTOM_SHADER );
+            Property::Value* shaderValue = map->Find(Toolkit::Visual::Property::SHADER, CUSTOM_SHADER);
             // set image only if property map contains image information other than custom shader
-            if( map->Count() > 1u ||  !shaderValue )
+            if(map->Count() > 1u || !shaderValue)
             {
-              impl.SetImage( *map );
+              impl.SetImage(*map);
             }
             // the property map contains only the custom shader
-            else if( ( impl.mVisual )&&( map->Count() == 1u )&&( shaderValue ) )
+            else if((map->Count() == 1u) && (shaderValue))
             {
               Property::Map* shaderMap = shaderValue->GetMap();
-              if( shaderMap )
+              if(shaderMap)
               {
-                Internal::Visual::Base& visual = Toolkit::GetImplementation( impl.mVisual );
-                visual.SetCustomShader( *shaderMap );
-                if( imageView.OnStage() )
+                impl.mShaderMap = *shaderMap;
+
+                if(!impl.mUrl.empty())
+                {
+                  impl.SetImage(impl.mUrl, impl.mImageSize);
+                }
+                else if(!impl.mPropertyMap.Empty())
                 {
-                  // force to create new core renderer to use the newly set shader
-                  visual.SetOffStage( imageView );
-                  visual.SetOnStage( imageView );
+                  impl.SetImage(impl.mPropertyMap);
                 }
               }
             }
@@ -297,9 +480,9 @@ void ImageView::SetProperty( BaseObject* object, Property::Index index, const Pr
       case Toolkit::ImageView::Property::PRE_MULTIPLIED_ALPHA:
       {
         bool isPre;
-        if( value.Get( isPre ) )
+        if(value.Get(isPre))
         {
-          impl.EnablePreMultipliedAlpha( isPre );
+          impl.EnablePreMultipliedAlpha(isPre);
         }
         break;
       }
@@ -307,42 +490,33 @@ void ImageView::SetProperty( BaseObject* object, Property::Index index, const Pr
   }
 }
 
-Property::Value ImageView::GetProperty( BaseObject* object, Property::Index propertyIndex )
+Property::Value ImageView::GetProperty(BaseObject* object, Property::Index propertyIndex)
 {
   Property::Value value;
 
-  Toolkit::ImageView imageview = Toolkit::ImageView::DownCast( Dali::BaseHandle( object ) );
+  Toolkit::ImageView imageview = Toolkit::ImageView::DownCast(Dali::BaseHandle(object));
 
-  if ( imageview )
+  if(imageview)
   {
-    ImageView& impl = GetImpl( imageview );
-    switch ( propertyIndex )
+    ImageView& impl = GetImpl(imageview);
+    switch(propertyIndex)
     {
-      case Toolkit::ImageView::Property::RESOURCE_URL:
-      {
-        if ( !impl.mUrl.empty() )
-        {
-          value = impl.mUrl;
-        }
-        break;
-      }
-
       case Toolkit::ImageView::Property::IMAGE:
       {
-        if ( !impl.mUrl.empty() )
+        if(!impl.mUrl.empty())
         {
           value = impl.mUrl;
         }
-        else if( impl.mImage )
+        else
         {
-          Property::Map map;
-          Scripting::CreatePropertyMap( impl.mImage, map );
+          Property::Map         map;
+          Toolkit::Visual::Base visual = DevelControl::GetVisual(impl, Toolkit::ImageView::Property::IMAGE);
+          if(visual)
+          {
+            visual.CreatePropertyMap(map);
+          }
           value = map;
         }
-        else if( !impl.mPropertyMap.Empty() )
-        {
-          value = impl.mPropertyMap;
-        }
         break;
       }