Fix svace issue : Need to check Property::Value.Get() return It is possible that user set invalid value type. If then, we need to skip given value setter. Change-Id: I8bc339f30b969c049a0b07bda152c4d24593bb48 Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
(A11y) Let we make some way to do not create new Accessible Add some API that we will not create new Accessible() object anymore. It will be useful when we ignore some Disposed view's accessible action. Change-Id: I6186f95eacf3c7d3cdb9c4ff9543edc019096552 Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Minor coverity issue fixes Fix some minor coverity issues that might has meanful 1. Implement missing move operation. 2. Remove float equal checks by ==, != operator. 3. Remove useless std::move. 4. Remove const keyword for function return value. 5. Resolve some value has same name. 6. Use referenced iterator so we don't copy value. 7. Remove cyclic header include (a.k.a gltf-loader.h -> scene3d-view-impl.h -> gltf-loader.h) Change-Id: I57ad541310b43413ee0d52b1f8c56a95df12bbd9 Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
[AT-SPI] Remove SetAccessibilityConstructor() This function is replaced by a new Control virtual method, CreateAccessibleObject(), which allows to achieve the same goal using less eccentric syntax. A slight reduction in memory usage is also expected, thanks to the fact that there is now no need to store a 'mAccessibilityConstructor' functor in every Control::Impl instance. Change-Id: I6399a6ca9acefb1648086b17d154541535f6bd2d
[AT-SPI] Require ControlAccessible for Control This change narrows down the type used in GetAccessibilityObject() and SetAccessibilityConstructor() from Accessible to ControlAccessible. It has always been the case that a Control is represented by either a ControlAccessible or a more derived type, and this fact is now reaffirmed in the API. Change-Id: Iae5f87845d951ac9affe2eb8589ec4aa3ea274e6
[AT-SPI] Rename AccessibleImpl to <Control>Accessible This change finishes establishing the new naming convention for Accessible objects, which now mirror the names of DALi/NUI classes, e.g. ActorAccessible, ControlAccessible (previously AccessibleImpl), NUIViewAccessible (previously AccessibleImpl_NUI), and now <Control>::AccessibleImpl becomes <Control>::<Control>Accessible. Change-Id: I8ba65736da4527d19107cee877541f776ba017ca
[AT-SPI] Synchronize with AT-SPI cleanup in dali-adaptor A related dali-adaptor change adds const-correctness and introduces a new, more coherent naming convention for Accessible objects. The name ControlAccessible now matches ApplicationAccessible, ProxyAccessible etc. and the upcoming ActorAccessible. Change-Id: I63a6887e1c291fbfb475fd8c2384126a31981d6b
Update ATSPI code according to DALi coding rule - Updated accessibility and bridge code, such as description or coding style. - Changed 'Caret' to 'Cursor' for dali text style. The patches below should be applied together. https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-adaptor/+/260281/ https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-csharp-binder/+/260322/ Change-Id: Id29163ab035efdcea6a06314bfcbf2826b2f09f2 Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
[AT-SPI] Use WeakHandle<Actor> in Accessible objects This breaks a strong reference cycle between Control::Impl, Actor, and AccessibleImpl. AccessibleImpl objects are stored as a std::unique_ptr in Control::Impl, so they do not need a strong actor handle. Change-Id: Iadf366dde0fe9cf1ca41128b027bc8add0717b39
[AT-SPI] Emit ObjectPropertyChangeEvent::VALUE While this could be done inside SetProperty handlers, it would not yield the desired effect, since the implementation often updates values directly, not via a SetProperty call. Change-Id: I2fed4b2d8ee7384bc5484c9af50d4b62a506a23a
Const correctness improvements for Property::Value. - instead of using its parameter as in-out (and perhaps erroneously modifying the original), TextVisual returns the new map, which is then merged with the existing properties in ButtonImpl::SetProperty(); Change-Id: I974535fd017416dc60225a1f511e71d81a2a86de Signed-off-by: György Straub <g.straub@partner.samsung.com>