Minor coverity issue fixes Fix some minor coverity issues that might has meanful 1. Implement missing move operation. 2. Remove float equal checks by ==, != operator. 3. Remove useless std::move. 4. Remove const keyword for function return value. 5. Resolve some value has same name. 6. Use referenced iterator so we don't copy value. 7. Remove cyclic header include (a.k.a gltf-loader.h -> scene3d-view-impl.h -> gltf-loader.h) Change-Id: I57ad541310b43413ee0d52b1f8c56a95df12bbd9 Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
[AT-SPI] Remove SetAccessibilityConstructor() This function is replaced by a new Control virtual method, CreateAccessibleObject(), which allows to achieve the same goal using less eccentric syntax. A slight reduction in memory usage is also expected, thanks to the fact that there is now no need to store a 'mAccessibilityConstructor' functor in every Control::Impl instance. Change-Id: I6399a6ca9acefb1648086b17d154541535f6bd2d
[AT-SPI] Require ControlAccessible for Control This change narrows down the type used in GetAccessibilityObject() and SetAccessibilityConstructor() from Accessible to ControlAccessible. It has always been the case that a Control is represented by either a ControlAccessible or a more derived type, and this fact is now reaffirmed in the API. Change-Id: Iae5f87845d951ac9affe2eb8589ec4aa3ea274e6
[AT-SPI] Synchronize with AT-SPI cleanup in dali-adaptor A related dali-adaptor change adds const-correctness and introduces a new, more coherent naming convention for Accessible objects. The name ControlAccessible now matches ApplicationAccessible, ProxyAccessible etc. and the upcoming ActorAccessible. Change-Id: I63a6887e1c291fbfb475fd8c2384126a31981d6b
Changed image loaders to use new PixelBuffer class. Migrating from PixelData to PixelBuffer internally. Public API still offers PixelData where needed. Through DevelAPI, it is now possible to retrieve a PixelBuffer from AsyncImageLoader. Removed BitmapLoader usage in favour of LoadImageFromFile(). Change-Id: Ib9e7b96cb6d643c0fb13e24b598131a3642a4b7c Signed-off-by: David Steele <david.steele@samsung.com>
Make Up calls to control consistent so they are called at the end by derived classes - This makes the most sense in the majority of use cases and by defining this, it's an easy rule for control developers to follow. Change-Id: Icb1701fbefcca70d8f81436b6d70a318e3e6fc76
Changed control defaults to listen to style change Not all controls listen to style change events, thus they can't be re-styled through the style system. Changed the default behaviour of all controls to listen to style change events. Added a new enum CONTROL_BEHAVIOUR_DEFAULT (value = 0) to show this. Change-Id: Ice26d98ba53a9950d941b74d2ed7816130bec040 Signed-off-by: David Steele <david.steele@samsung.com>