Fix svace issue phase2 : Need to check Property::Value.Get() return It is possible that user set invalid value type. If then, we need to skip given value setter. Change-Id: I1d3074c6bf7ee061cb195195a90f8b07fe04db7f Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Fix many svace issues at dali-toolkit (integer overflow + etc) This is a combination of 3 commits. Let we remove many cases of dali-toolkit when we can be call 0u - 1u, which is undefined behavior. Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com> (Scene3D) Fix svace issue : convert uint32_t to std::streamoff + minor Fix svace issue when we try to convert from 32bit unsigned integer to (might) 64bit signed integer. + Fix the name of function collision issue Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com> Fix svace issue : Avoid to divide by zero cases Change-Id: If11884693253cd86f89cb98704e93473166faca1 Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Do not call malloc during terminate There was some strange crash issue during application terminate. That crash comes at malloc.c during destruct JsonParser. So, let we just remove some potential of mallocate memory during terminate, what might not neccessary. Change-Id: I93dc70b0c069f90a94e526f7916f9c54e1565a7f Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Replace std::string global variables with C-style string. A std::string global variable would allocate a memory in heap, then copy the string from .text section to the heap. This patch may reduce loading time & memory a little. Change-Id: I2ce22c98695cee6edea088d98b9569e11fc6c837
Minor coverity issue fixes Fix some minor coverity issues that might has meanful 1. Implement missing move operation. 2. Remove float equal checks by ==, != operator. 3. Remove useless std::move. 4. Remove const keyword for function return value. 5. Resolve some value has same name. 6. Use referenced iterator so we don't copy value. 7. Remove cyclic header include (a.k.a gltf-loader.h -> scene3d-view-impl.h -> gltf-loader.h) Change-Id: I57ad541310b43413ee0d52b1f8c56a95df12bbd9 Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Replace obsolete safe bool idiom with explicit operator bool C++11 introduces 'explicit operator bool' to prevent unintended implicit conversions to 'bool', thus making the trick with converting to a pointer-to-member (a.k.a. "safe bool idiom") obsolete. The explicit operator is more restrictive than 'safe bool', and it helped uncover a bug in the test suite where object handles were implicitly converted to bool before being sent to an std::ostream. Change-Id: I2bbb60d6b97e920dc08b641031304b1e07f8a2cd
Updated all header files to new format Change-Id: I68b3cf032fa1758fff92509f463101bdfd36cce1
Updated all cpp files to new format Change-Id: If92183926ff6584c5d05efda672b422b9dd9a322
Overriding virtual destructors are marked as 'override'. - so are functions missed from If046270d3b6036f8566a9c48e4064425c1498daa; - affected files that were the wrong mode have that fixed too (-x); Change-Id: I476600848bb789ae7e660d130be723604453c674 Signed-off-by: György Straub <g.straub@partner.samsung.com>
Changes after Stage moved to Devel API Change-Id: I196c1948a7f87cd2a04f04e31fe901284170d48e