Trace use scope macro instead of begin-end 73/286173/1
authorEunki Hong <eunkiki.hong@samsung.com>
Thu, 29 Dec 2022 15:45:29 +0000 (00:45 +0900)
committerEunki Hong <eunkiki.hong@samsung.com>
Thu, 29 Dec 2022 15:45:29 +0000 (00:45 +0900)
Since we don't need to follow functions usecase,
use trace scope macro instead of begin-end.

Change-Id: I958cb1d97089cafeac507613068b1c574c3ebb0e
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
dali/internal/common/core-impl.cpp
dali/internal/event/common/notification-manager.cpp
dali/internal/event/events/key-event-processor.cpp
dali/internal/event/size-negotiation/relayout-controller-impl.cpp
dali/internal/update/manager/frame-callback-processor.cpp

index 28b8a6c..a5cea80 100644 (file)
@@ -375,7 +375,7 @@ void Core::RunProcessors()
 {
   if(mProcessors.Count() != 0)
   {
-    DALI_TRACE_BEGIN(gTraceFilter, "DALI_CORE_RUN_PROCESSORS");
+    DALI_TRACE_SCOPE(gTraceFilter, "DALI_CORE_RUN_PROCESSORS");
 
     // Copy processor pointers to prevent changes to vector affecting loop iterator.
     Dali::Vector<Integration::Processor*> processors(mProcessors);
@@ -403,7 +403,6 @@ void Core::RunProcessors()
         }
       }
     }
-    DALI_TRACE_END(gTraceFilter, "DALI_CORE_RUN_PROCESSORS");
   }
 }
 
@@ -411,7 +410,7 @@ void Core::RunPostProcessors()
 {
   if(mPostProcessors.Count() != 0)
   {
-    DALI_TRACE_BEGIN(gTraceFilter, "DALI_CORE_RUN_POST_PROCESSORS");
+    DALI_TRACE_SCOPE(gTraceFilter, "DALI_CORE_RUN_POST_PROCESSORS");
 
     // Copy processor pointers to prevent changes to vector affecting loop iterator.
     Dali::Vector<Integration::Processor*> processors(mPostProcessors);
@@ -439,7 +438,6 @@ void Core::RunPostProcessors()
         }
       }
     }
-    DALI_TRACE_END(gTraceFilter, "DALI_CORE_RUN_POST_PROCESSORS");
   }
 }
 
index 828586a..d20ec05 100644 (file)
@@ -170,12 +170,11 @@ void NotificationManager::ProcessMessages()
   const MessageContainer::Iterator end  = mImpl->eventMessageQueue.End();
   if(iter != end)
   {
-    DALI_TRACE_BEGIN(gTraceFilter, "DALI_NOTIFICATION_PROCESS_MESSAGE");
+    DALI_TRACE_SCOPE(gTraceFilter, "DALI_NOTIFICATION_PROCESS_MESSAGE");
     for(; iter != end; ++iter)
     {
       (*iter)->Process(0u /*ignored*/);
     }
-    DALI_TRACE_END(gTraceFilter, "DALI_NOTIFICATION_PROCESS_MESSAGE");
   }
   // release the processed messages from event side queue
   mImpl->eventMessageQueue.Clear();
@@ -184,7 +183,7 @@ void NotificationManager::ProcessMessages()
   const InterfaceContainer::Iterator end2  = mImpl->eventInterfaceQueue.End();
   if(iter2 != end2)
   {
-    DALI_TRACE_BEGIN(gTraceFilter, "DALI_NOTIFICATION_NOTIFY_COMPLETED");
+    DALI_TRACE_SCOPE(gTraceFilter, "DALI_NOTIFICATION_NOTIFY_COMPLETED");
     for(; iter2 != end2; ++iter2)
     {
       CompleteNotificationInterface* interface = *iter2;
@@ -193,7 +192,6 @@ void NotificationManager::ProcessMessages()
         interface->NotifyCompleted();
       }
     }
-    DALI_TRACE_END(gTraceFilter, "DALI_NOTIFICATION_NOTIFY_COMPLETED");
   }
   // just clear the container, we dont own the objects
   mImpl->eventInterfaceQueue.Clear();
index 4b6ef61..60fee2e 100644 (file)
@@ -46,14 +46,7 @@ void KeyEventProcessor::ProcessKeyEvent(const Integration::KeyEvent& event)
   KeyEventPtr    keyEvent(new KeyEvent(event.keyName, event.logicalKey, event.keyString, event.keyCode, event.keyModifier, event.time, static_cast<Dali::KeyEvent::State>(event.state), event.compose, event.deviceName, event.deviceClass, event.deviceSubclass));
   Dali::KeyEvent keyEventHandle(keyEvent.Get());
 
-#ifdef TRACE_ENABLED
-  std::ostringstream stream;
-  if(gTraceFilter->IsTraceEnabled())
-  {
-    stream << "DALI_PROCESS_KEY_EVENT [" << event.keyName << ", " << event.state << "]";
-    DALI_TRACE_BEGIN(gTraceFilter, stream.str().c_str());
-  }
-#endif
+  DALI_TRACE_SCOPE(gTraceFilter, "DALI_PROCESS_KEY_EVENT");
 
   // Emit the key event signal from the scene.
   bool consumed = mScene.EmitInterceptKeyEventSignal(keyEventHandle);
@@ -65,13 +58,6 @@ void KeyEventProcessor::ProcessKeyEvent(const Integration::KeyEvent& event)
   {
     mScene.EmitKeyEventSignal(keyEventHandle);
   }
-
-#ifdef TRACE_ENABLED
-  if(gTraceFilter->IsTraceEnabled())
-  {
-    DALI_TRACE_END(gTraceFilter, stream.str().c_str());
-  }
-#endif
 }
 
 } // namespace Internal
index dd0f98d..c32cebe 100644 (file)
@@ -439,7 +439,7 @@ void RelayoutController::Relayout()
     // 2. Iterate through the stack until it's empty.
     if(mRelayoutStack->Size() > 0)
     {
-      DALI_TRACE_BEGIN(gTraceFilter, "DALI_RELAYOUT");
+      DALI_TRACE_SCOPE(gTraceFilter, "DALI_RELAYOUT");
       PRINT_HIERARCHY;
 
       while(mRelayoutStack->Size() > 0)
@@ -464,7 +464,6 @@ void RelayoutController::Relayout()
       mRelayoutInfoAllocator.ResetMemoryPool();
 
       PRINT_HIERARCHY;
-      DALI_TRACE_END(gTraceFilter, "DALI_RELAYOUT");
     }
 
     mPerformingRelayout = false;
index 10e7d8d..ad4e495 100644 (file)
@@ -67,7 +67,7 @@ void FrameCallbackProcessor::Update(BufferIndex bufferIndex, float elapsedSecond
 {
   if(!mFrameCallbacks.empty())
   {
-    DALI_TRACE_BEGIN(gTraceFilter, "DALI_FRAME_CALLBACK_UPDATE");
+    DALI_TRACE_SCOPE(gTraceFilter, "DALI_FRAME_CALLBACK_UPDATE");
 
     // If any of the FrameCallback::Update calls returns false, then they are no longer required & can be removed.
     auto iter = std::remove_if(
@@ -75,8 +75,6 @@ void FrameCallbackProcessor::Update(BufferIndex bufferIndex, float elapsedSecond
         return !frameCallback->Update(bufferIndex, elapsedSeconds, mNodeHierarchyChanged);
       });
     mFrameCallbacks.erase(iter, mFrameCallbacks.end());
-
-    DALI_TRACE_END(gTraceFilter, "DALI_FRAME_CALLBACK_UPDATE");
   }
 
   mNodeHierarchyChanged = false;