From 729cae1ffd3623874fe114c433a380612202ca6e Mon Sep 17 00:00:00 2001 From: "Seungho, Baek" Date: Mon, 15 Jul 2019 14:58:04 +0900 Subject: [PATCH] Revert "[Tizen] Fix video underlay issue" This reverts commit 9482a7dd818129bd7d1c4d8dd53a1ca770046f7d. --- dali/internal/graphics/gles/egl-implementation.cpp | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/dali/internal/graphics/gles/egl-implementation.cpp b/dali/internal/graphics/gles/egl-implementation.cpp index b8a42f7..68d7925 100755 --- a/dali/internal/graphics/gles/egl-implementation.cpp +++ b/dali/internal/graphics/gles/egl-implementation.cpp @@ -341,6 +341,8 @@ bool EglImplementation::ChooseConfig( bool isWindowType, ColorDepth depth ) return true; } + bool isTransparent = ( depth == COLOR_DEPTH_32 ); + mColorDepth = depth; mIsWindow = isWindowType; @@ -381,10 +383,18 @@ bool EglImplementation::ChooseConfig( bool isWindowType, ColorDepth depth ) configAttribs.PushBack( EGL_BLUE_SIZE ); configAttribs.PushBack( 8 ); - // In the previous code, there was a branch for ARM. - // If there is an issue in only ARM, we need to check here again. - configAttribs.PushBack( EGL_ALPHA_SIZE ); - configAttribs.PushBack( 8 ); + if ( isTransparent ) + { + configAttribs.PushBack( EGL_ALPHA_SIZE ); +#ifdef _ARCH_ARM_ + // For underlay video playback, we also need to set the alpha value of the 24/32bit window. + configAttribs.PushBack( 8 ); +#else + // There is a bug in the desktop emulator + // setting EGL_ALPHA_SIZE to 8 results in eglChooseConfig failing + configAttribs.PushBack( 8 ); +#endif // _ARCH_ARM_ + } configAttribs.PushBack( EGL_DEPTH_SIZE ); configAttribs.PushBack( mDepthBufferRequired ? 24 : 0 ); -- 2.7.4