From: suhyung Eom Date: Wed, 4 Jan 2017 07:39:54 +0000 (+0900) Subject: [3.0] Fixed crash issue by buffer overflow X-Git-Tag: accepted/tizen/3.0/common/20170109.200037^0 X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-adaptor.git;a=commitdiff_plain;h=b236de8b26be03f58aa0502fe6c1a6828e2a6bc2 [3.0] Fixed crash issue by buffer overflow Signed-off-by: suhyung Eom Change-Id: I81b72f672528d173c53299575887fbdc9fc44dcc --- diff --git a/adaptors/ecore/wayland/clipboard-impl-ecore-wl.cpp b/adaptors/ecore/wayland/clipboard-impl-ecore-wl.cpp index aad03a3..684f61b 100644 --- a/adaptors/ecore/wayland/clipboard-impl-ecore-wl.cpp +++ b/adaptors/ecore/wayland/clipboard-impl-ecore-wl.cpp @@ -39,7 +39,7 @@ #endif /* CBHM_DBUS_INTERFACE */ #define CLIPBOARD_STR "CLIPBOARD_STR" -#define CLIPBOARD_BUFFER_SIZE 512 +#define CLIPBOARD_BUFFER_SIZE 3000 /////////////////////////////////////////////////////////////////////////////////////////////////// // Clipboard @@ -143,9 +143,7 @@ struct Clipboard::Impl { Ecore_Wl_Event_Selection_Data_Ready *ev = (Ecore_Wl_Event_Selection_Data_Ready *)event; - strncpy(mReceiveBuf, (char *)ev->data, ev->len); - mReceiveBuf[ev->len] = '\0'; - return (char *)mReceiveBuf; + return (char *)ev->data; } int GetCount() @@ -214,8 +212,7 @@ struct Clipboard::Impl Eldbus_Proxy *eldbus_proxy; Eldbus_Connection *cbhm_conn; - char mSendBuf[CLIPBOARD_BUFFER_SIZE]; - char mReceiveBuf[CLIPBOARD_BUFFER_SIZE]; + char mSendBuf[CLIPBOARD_BUFFER_SIZE+1]; bool mVisible; bool mIsFirstTimeHidden; };