From: Seungho, Baek <sbsh.baek@samsung.com>
Date: Mon, 15 Jul 2019 05:57:48 +0000 (+0900)
Subject: Revert "[Tizen] Fix Coverity issues"
X-Git-Tag: accepted/tizen/unified/20190716.111332~12
X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fdali-adaptor.git;a=commitdiff_plain;h=1009c0ddd9febabbebe63d937cc7ffa824bd22d6

Revert "[Tizen] Fix Coverity issues"

This reverts commit f0892bcdbf47f364fea3ee8f7fc8b5cb79a11cb2.
---

diff --git a/dali/internal/input/tizen-wayland/autofill-manager-impl-ecore-wl.cpp b/dali/internal/input/tizen-wayland/autofill-manager-impl-ecore-wl.cpp
index a00e3e2..2483ae1 100755
--- a/dali/internal/input/tizen-wayland/autofill-manager-impl-ecore-wl.cpp
+++ b/dali/internal/input/tizen-wayland/autofill-manager-impl-ecore-wl.cpp
@@ -336,26 +336,27 @@ void AutofillManagerEcoreWl::ReceiveAuthInfo( autofill_auth_info_h authInfoHandl
                                                 serviceName, serviceLogoImagePath, serviceMessage );
 
     // Sets the authentication service information in order to use in other components.
-    if( serviceName )
-    {
-      mAuthenticationServiceName = serviceName;
-      free( serviceName );
-    }
+    mAuthenticationServiceName = serviceName;
+    mAuthenticationServiceMessage = serviceMessage;
+    mAuthenticationServiceImagePath = serviceLogoImagePath;
+
+    // Emits the signal to receive the authentication information.
+    mAuthReceivedSignal.Emit();
 
     if( serviceMessage )
     {
-      mAuthenticationServiceMessage = serviceMessage;
       free( serviceMessage );
     }
 
+    if( serviceName )
+    {
+      free( serviceName );
+    }
+
     if( serviceLogoImagePath )
     {
-      mAuthenticationServiceImagePath = serviceLogoImagePath;
       free( serviceLogoImagePath );
     }
-
-    // Emits the signal to receive the authentication information.
-    mAuthReceivedSignal.Emit();
   }
   else
   {
@@ -380,31 +381,32 @@ void AutofillManagerEcoreWl::FillGroupItem( autofill_fill_response_item_h itemHa
                                               id, value, presentationText );
 
   // Sets the fill response information in order to use in other components.
+  mFillItemId = id;
+  mFillItemPresentationText = presentationText;
+  mFillItemValue = value;
+
+  Dali::AutofillItem item = mAutofillGroup.GetAutofillItem( id );
+  Internal::Adaptor::AutofillItem& itemImpl = Internal::Adaptor::GetImplementation( item );
+  itemImpl.AddPresentationList( presentationText );
+  itemImpl.AddFillValueList( value );
+
+  // Emits the signal to fill the data in text input field.
+  mFillReceivedSignal.Emit( item );
+
   if( id )
   {
-    mFillItemId = id;
     free( id );
   }
 
-  if( presentationText )
-  {
-    mFillItemPresentationText = presentationText;
-    free( presentationText );
-  }
-
   if( value )
   {
-    mFillItemValue = value;
     free( value );
   }
 
-  Dali::AutofillItem item = mAutofillGroup.GetAutofillItem( mFillItemId );
-  Internal::Adaptor::AutofillItem& itemImpl = Internal::Adaptor::GetImplementation( item );
-  itemImpl.AddPresentationList( mFillItemPresentationText );
-  itemImpl.AddFillValueList( mFillItemValue );
-
-  // Emits the signal to fill the data in text input field.
-  mFillReceivedSignal.Emit( item );
+  if( presentationText )
+  {
+    free( presentationText );
+  }
 
 }
 
@@ -424,29 +426,29 @@ void AutofillManagerEcoreWl::FillMultipleGroupItem( autofill_fill_response_item_
                                               id, value, presentationText );
 
   // Sets the fill response information in order to use in other components.
+  mFillItemId = id;
+  mFillItemPresentationText = presentationText;
+  mFillItemValue = value;
+
+  Dali::AutofillItem item = mAutofillGroup.GetAutofillItem( id );
+  Internal::Adaptor::AutofillItem& itemImpl = Internal::Adaptor::GetImplementation( item );
+  itemImpl.AddPresentationList( presentationText );
+  itemImpl.AddFillValueList( value );
+
   if( id )
   {
-    mFillItemId = id;
     free( id );
   }
 
-  if( presentationText )
-  {
-    mFillItemPresentationText = presentationText;
-    free( presentationText );
-  }
-
   if( value )
   {
-    mFillItemValue = value;
     free( value );
   }
 
-  Dali::AutofillItem item = mAutofillGroup.GetAutofillItem( mFillItemId );
-  Internal::Adaptor::AutofillItem& itemImpl = Internal::Adaptor::GetImplementation( item );
-  itemImpl.AddPresentationList( mFillItemPresentationText );
-  itemImpl.AddFillValueList( mFillItemValue );
-
+  if( presentationText )
+  {
+    free( presentationText );
+  }
 }
 #endif // CAPI_AUTOFILL_SUPPORT