From 031946b5b7ec90279ae60bbf974f23979979ea78 Mon Sep 17 00:00:00 2001 From: Mike Gorse Date: Fri, 3 May 2013 09:48:50 -0500 Subject: [PATCH] Add a NULL check into register_reply Register_reply could access invalid memory if it is called after atk_bridge_adaptor_cleanup() has been called. This code should probably be refactored to make the instance act as a GObject, but committing this for now to fix the crash. https://bugzilla.gnome.org/show_bug.cgi?id=699554 --- atk-adaptor/bridge.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/atk-adaptor/bridge.c b/atk-adaptor/bridge.c index 1a36f14..e59c834 100644 --- a/atk-adaptor/bridge.c +++ b/atk-adaptor/bridge.c @@ -235,6 +235,14 @@ register_reply (DBusPendingCall *pending, void *user_data) reply = dbus_pending_call_steal_reply (pending); dbus_pending_call_unref (pending); + + if (!spi_global_app_data) + { + if (reply) + dbus_message_unref (reply); + return; + } + if (reply) { gchar *app_name, *obj_path; -- 2.7.4