From: Matthias Clasen <mclasen@redhat.com>
Date: Wed, 19 Oct 2011 22:42:18 +0000 (-0400)
Subject: Don't leave va_args dangling
X-Git-Tag: AT_SPI2_ATK_2_12_0~174
X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fat-spi2-atk.git;a=commitdiff_plain;h=e648f8220905b17632f7d4b2f16deac1b0aff7d0

Don't leave va_args dangling

spi_dbus_message_iter_append_struct has an early exit where it
forgets to call va_end(). Harmless most of the time, but it
upsets static analyzers.

https://bugzilla.gnome.org/show_bug.cgi?id=662248
---

diff --git a/atk-adaptor/spi-dbus.c b/atk-adaptor/spi-dbus.c
index b448510..e4fa49a 100644
--- a/atk-adaptor/spi-dbus.c
+++ b/atk-adaptor/spi-dbus.c
@@ -125,8 +125,8 @@ dbus_bool_t spi_dbus_message_iter_append_struct(DBusMessageIter *iter, ...)
     ptr = va_arg(args, void *);
     dbus_message_iter_append_basic(&iter_struct, type, ptr);
   }
-  if (!dbus_message_iter_close_container(iter, &iter_struct)) return FALSE;
   va_end(args);
+  if (!dbus_message_iter_close_container(iter, &iter_struct)) return FALSE;
   return TRUE;
 }