X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fuifw%2Fat-spi2-atk.git;a=blobdiff_plain;f=droute%2Fdroute.c;h=838aacdeeb1a7e65700ba4ceaffef038e623d5e0;hp=1567fc7bdc3d47cf9524dd6619f17ad6eb61cdca;hb=c45b58703c60511c9ed94734573cdf44c3f4eedc;hpb=a110d6bf5aac4a11541521c568d9a8f85aecca05 diff --git a/droute/droute.c b/droute/droute.c index 1567fc7..838aacd 100644 --- a/droute/droute.c +++ b/droute/droute.c @@ -107,7 +107,7 @@ path_new (DRouteContext *cnx, new_path->properties = g_hash_table_new_full ((GHashFunc)str_pair_hash, str_pair_equal, g_free, - NULL); + g_free); new_path->introspect_children_cb = introspect_children_cb; new_path->introspect_children_data = introspect_children_data; @@ -123,9 +123,10 @@ path_free (DRoutePath *path, gpointer user_data) g_free (path->path); g_string_chunk_free (path->chunks); g_ptr_array_free (path->interfaces, TRUE); - g_ptr_array_free (path->introspection, FALSE); + g_free(g_ptr_array_free (path->introspection, FALSE)); g_hash_table_destroy (path->methods); g_hash_table_destroy (path->properties); + g_free (path); } static void * @@ -154,6 +155,7 @@ void droute_free (DRouteContext *cnx) { g_ptr_array_foreach (cnx->registered_paths, (GFunc) path_free, NULL); + g_ptr_array_free (cnx->registered_paths, TRUE); g_free (cnx); } @@ -174,7 +176,6 @@ droute_add_one (DRouteContext *cnx, const void *data) { DRoutePath *new_path; - gboolean registered; new_path = path_new (cnx, path, FALSE, (void *)data, NULL, NULL, NULL); @@ -215,7 +216,7 @@ droute_path_add_interface(DRoutePath *path, itf = g_string_chunk_insert (path->chunks, name); g_ptr_array_add (path->interfaces, itf); - g_ptr_array_add (path->introspection, introspect); + g_ptr_array_add (path->introspection, (gpointer) introspect); for (; methods != NULL && methods->name != NULL; methods++) { @@ -264,7 +265,12 @@ impl_prop_GetAll (DBusMessage *message, dbus_error_init (&error); if (!dbus_message_get_args (message, &error, DBUS_TYPE_STRING, &iface, DBUS_TYPE_INVALID)) - return dbus_message_new_error (message, DBUS_ERROR_FAILED, error.message); + { + DBusMessage *ret; + ret = dbus_message_new_error (message, DBUS_ERROR_FAILED, error.message); + dbus_error_free (&error); + return ret; + } reply = dbus_message_new_method_return (message); if (!reply) @@ -320,17 +326,26 @@ impl_prop_GetSet (DBusMessage *message, DBUS_TYPE_STRING, &(pair.two), DBUS_TYPE_INVALID)) - return dbus_message_new_error (message, DBUS_ERROR_FAILED, error.message); + { + DBusMessage *ret; + ret = dbus_message_new_error (message, DBUS_ERROR_FAILED, error.message); + dbus_error_free (&error); + } _DROUTE_DEBUG ("DRoute (handle prop): %s|%s on %s\n", pair.one, pair.two, pathstr); prop_funcs = (PropertyPair *) g_hash_table_lookup (path->properties, &pair); if (!prop_funcs) + { + DBusMessage *ret; #ifdef DBUS_ERROR_UNKNOWN_PROPERTY - return dbus_message_new_error (message, DBUS_ERROR_UNKNOWN_PROPERTY, "Property unavailable"); + ret = dbus_message_new_error (message, DBUS_ERROR_UNKNOWN_PROPERTY, "Property unavailable"); #else - return dbus_message_new_error (message, DBUS_ERROR_FAILED, "Property unavailable"); + ret = dbus_message_new_error (message, DBUS_ERROR_FAILED, "Property unavailable"); #endif + dbus_error_free (&error); + return ret; + } datum = path_get_datum (path, pathstr); if (!datum)