Refactor AccessProvider and ScopedAccessProvider 46/240346/5
authorMateusz Cegielka <m.cegielka@samsung.com>
Wed, 5 Aug 2020 11:07:53 +0000 (13:07 +0200)
committerKrzysztof Jackiewicz <k.jackiewicz@samsung.com>
Fri, 18 Sep 2020 13:45:47 +0000 (13:45 +0000)
commit0af26472074232b77cdc4fa7c0c2a8fba9cdda69
tree2bf55e7df16ff0eb5f8df846ce439071d91da57c
parentd3a1b002739780c5af61ed928f8b1f62b36b544d
Refactor AccessProvider and ScopedAccessProvider

AccessProvider is a helper class for setting up Smack rules, user id,
group id and process labels before or during a test. CKM tests also
contain different AccessProvider and ScopedAccessProvider classes, but
only use a single constructor of the latter to pretend to be an app.
These classes contain some duplicated code. Also, after the removal of
libsmack-tests, the responsibilities of these classes have shrunk to
pretending to be an app and nothing else.

I have cleaned up src/common/ AccessProvider, renamed it to AppContext
and made it flexible enough so that ScopedAccessProvider can be
implemented in terms of it and src/ckm/ AccessProvider can be removed. I
have then cleaned up ScopedAccessProvider and renamed it to
ScopedAppContext.

Change-Id: I325f7bd1d9c2ac276960530384682227cefec7da
18 files changed:
src/ckm/privileged/CMakeLists.txt
src/ckm/privileged/access_provider2.cpp [deleted file]
src/ckm/privileged/access_provider2.h [deleted file]
src/ckm/privileged/async-api.cpp
src/ckm/privileged/capi-access_control.cpp
src/ckm/privileged/initial-values.cpp
src/ckm/privileged/main.cpp
src/ckm/privileged/scoped-app-context.cpp [new file with mode: 0644]
src/ckm/privileged/scoped-app-context.h [new file with mode: 0644]
src/ckm/privileged/system-db.cpp
src/common/CMakeLists.txt
src/common/access_provider.cpp [deleted file]
src/common/app_context.cpp [new file with mode: 0644]
src/common/app_context.h [moved from src/common/access_provider.h with 51% similarity]
src/common/scoped_process_label.cpp
src/common/scoped_process_label.h
src/cynara-tests/test_cases_helpers.cpp
src/security-manager-tests/test_cases_credentials.cpp