From: Jeongmo Yang <jm80.yang@samsung.com>
Date: Mon, 7 Nov 2016 07:42:52 +0000 (+0900)
Subject: Change return value for some display settings
X-Git-Tag: accepted/tizen/common/20161109.140301^0
X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fmultimedia%2Flibmm-camcorder.git;a=commitdiff_plain;h=73dc9b79e251e88b88341b832348a0d5f7d9b8d5

Change return value for some display settings

"fakesink" is used when client uses evas surface rendering,
but, display setting is come to muse server and returned false.
For synchronization, change the return value for them.

[Version] 0.10.90
[Profile] Common
[Issue Type]
[Dependency module] N/A
[Test] [M(T) - Boot=(OK), sdb=(OK), Home=(OK), Touch=(OK), Version=tizen-mobile_20161101.3]

Change-Id: I5146a29b111c59b6649a9028dfeb5e8a6028b927
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
---

diff --git a/packaging/libmm-camcorder.spec b/packaging/libmm-camcorder.spec
index 81dd040..c67d306 100644
--- a/packaging/libmm-camcorder.spec
+++ b/packaging/libmm-camcorder.spec
@@ -1,6 +1,6 @@
 Name:       libmm-camcorder
 Summary:    Camera and recorder library
-Version:    0.10.89
+Version:    0.10.90
 Release:    0
 Group:      Multimedia/Libraries
 License:    Apache-2.0
diff --git a/src/mm_camcorder_attribute.c b/src/mm_camcorder_attribute.c
index e6c056a..af6ba6e 100644
--- a/src/mm_camcorder_attribute.c
+++ b/src/mm_camcorder_attribute.c
@@ -3801,11 +3801,11 @@ bool _mmcamcorder_commit_display_mode(MMHandleType handle, int attr_idx, const m
 	if (!strcmp(videosink_name, "xvimagesink") || !strcmp(videosink_name, "waylandsink")) {
 		_mmcam_dbg_log("Commit : display mode [%d]", value->value.i_val);
 		MMCAMCORDER_G_OBJECT_SET(sc->element[_MMCAMCORDER_VIDEOSINK_SINK].gst, "display-mode", value->value.i_val);
-		return TRUE;
 	} else {
-		_mmcam_dbg_warn("Commit : This element [%s] does not support display mode", videosink_name);
-		return FALSE;
+		_mmcam_dbg_warn("[%s] does not support display mode, but no error", videosink_name);
 	}
+
+	return TRUE;
 }
 
 
@@ -3895,11 +3895,11 @@ bool _mmcamcorder_commit_display_visible(MMHandleType handle, int attr_idx, cons
 		!strcmp(videosink_name, "evaspixmapsink") || !strcmp(videosink_name, "evasimagesink")) {
 		MMCAMCORDER_G_OBJECT_SET(sc->element[_MMCAMCORDER_VIDEOSINK_SINK].gst, "visible", value->value.i_val);
 		_mmcam_dbg_log("Set visible [%d] done.", value->value.i_val);
-		return TRUE;
 	} else {
-		_mmcam_dbg_warn("videosink[%s] does not support VISIBLE.", videosink_name);
-		return FALSE;
+		_mmcam_dbg_warn("[%s] does not support VISIBLE, but no error", videosink_name);
 	}
+
+	return TRUE;
 }
 
 
@@ -3940,11 +3940,11 @@ bool _mmcamcorder_commit_display_geometry_method(MMHandleType handle, int attr_i
 	    !strcmp(videosink_name, "evaspixmapsink") || !strcmp(videosink_name, "evasimagesink")) {
 		method = value->value.i_val;
 		MMCAMCORDER_G_OBJECT_SET(sc->element[_MMCAMCORDER_VIDEOSINK_SINK].gst, "display-geometry-method", method);
-		return TRUE;
 	} else {
-		_mmcam_dbg_warn("videosink[%s] does not support geometry method.", videosink_name);
-		return FALSE;
+		_mmcam_dbg_warn("[%s] does not support geometry method, but no error", videosink_name);
 	}
+
+	return TRUE;
 }
 
 
diff --git a/src/mm_camcorder_gstcommon.c b/src/mm_camcorder_gstcommon.c
index 317bb6b..a17cb9e 100644
--- a/src/mm_camcorder_gstcommon.c
+++ b/src/mm_camcorder_gstcommon.c
@@ -2136,11 +2136,11 @@ bool _mmcamcorder_set_display_rotation(MMHandleType handle, int display_rotate,
 			!strcmp(videosink_name, "directvideosink")) {
 			MMCAMCORDER_G_OBJECT_SET(sc->element[videosink_index].gst, "rotate", display_rotate);
 			_mmcam_dbg_log("Set display-rotate [%d] done.", display_rotate);
-			return TRUE;
 		} else {
-			_mmcam_dbg_warn("videosink[%s] does not support DISPLAY_ROTATION.", videosink_name);
-			return FALSE;
+			_mmcam_dbg_warn("[%s] does not support DISPLAY_ROTATION, but no error", videosink_name);
 		}
+
+		return TRUE;
 	} else {
 		_mmcam_dbg_err("Videosink element is null");
 		return FALSE;
@@ -2175,11 +2175,11 @@ bool _mmcamcorder_set_display_flip(MMHandleType handle, int display_flip, int vi
 			!strcmp(videosink_name, "directvideosink")) {
 			MMCAMCORDER_G_OBJECT_SET(sc->element[videosink_index].gst, "flip", display_flip);
 			_mmcam_dbg_log("Set display flip [%d] done.", display_flip);
-			return TRUE;
 		} else {
-			_mmcam_dbg_warn("videosink[%s] does not support DISPLAY_FLIP", videosink_name);
-			return FALSE;
+			_mmcam_dbg_warn("[%s] does not support DISPLAY_FLIP, but no error", videosink_name);
 		}
+
+		return TRUE;
 	} else {
 		_mmcam_dbg_err("Videosink element is null");
 		return FALSE;