Fix coverity issue - Unchecked return value 25/212925/1 accepted/tizen/unified/20190829.101447 submit/tizen/20190828.072356
authorJeongmo Yang <jm80.yang@samsung.com>
Wed, 28 Aug 2019 07:17:20 +0000 (16:17 +0900)
committerJeongmo Yang <jm80.yang@samsung.com>
Wed, 28 Aug 2019 07:17:20 +0000 (16:17 +0900)
[Version] 0.10.185
[Profile] Common
[Issue Type] Coverity

Change-Id: I19478dc28216d1fa903223df25cda0dea0ce3582
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
packaging/libmm-camcorder.spec
src/mm_camcorder_internal.c

index 54de2d5..0e347cb 100644 (file)
@@ -1,6 +1,6 @@
 Name:       libmm-camcorder
 Summary:    Camera and recorder library
-Version:    0.10.184
+Version:    0.10.185
 Release:    0
 Group:      Multimedia/Libraries
 License:    Apache-2.0
index ac131e2..0ffdb41 100644 (file)
@@ -427,8 +427,16 @@ static gint __mmcamcorder_init_configure_video_capture(mmf_camcorder_t *hcamcord
                MMCAM_CAMERA_WIDTH, &resolution_width,
                MMCAM_CAMERA_HEIGHT, &resolution_height,
                NULL);
+       if (ret != MM_ERROR_NONE) {
+               _mmcam_dbg_err("get attribute[resolution] error");
+               return MM_ERROR_CAMCORDER_INTERNAL;
+       }
 
-       mm_camcorder_get_fps_list_by_resolution((MMHandleType)hcamcorder, resolution_width, resolution_height, &fps_info);
+       ret = mm_camcorder_get_fps_list_by_resolution((MMHandleType)hcamcorder, resolution_width, resolution_height, &fps_info);
+       if (ret != MM_ERROR_NONE) {
+               _mmcam_dbg_err("get fps list failed with [%dx%d]", resolution_width, resolution_height);
+               return MM_ERROR_CAMCORDER_INTERNAL;
+       }
 
        _mmcam_dbg_log("ZeroCopy %d, UserBuffer %d, Videoconvert %d, MPPreviewCb %d",
                hcamcorder->use_zero_copy_format, hcamcorder->support_user_buffer,