From c95fb65aae3a1924bc4b54afd35fc55aac69f3b5 Mon Sep 17 00:00:00 2001 From: "minje.ahn" Date: Mon, 11 Mar 2024 11:26:35 +0900 Subject: [PATCH] Delete unreachable case If it works properly, ' album' and 'artist' are not null. Change-Id: Ie310f5f0a2ae87a85349510fcf839e282b1e8570 Signed-off-by: minje.ahn --- src/common/media-svc-album.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/common/media-svc-album.c b/src/common/media-svc-album.c index 2949270..c32f44c 100755 --- a/src/common/media-svc-album.c +++ b/src/common/media-svc-album.c @@ -29,20 +29,16 @@ int _media_svc_get_album_id(sqlite3 *handle, const char *album, const char *arti sqlite3_stmt *sql_stmt = NULL; char *sql = NULL; - media_svc_retvm_if(album == NULL, MS_MEDIA_ERR_INVALID_PARAMETER, "album is NULL"); - - if (artist) - sql = sqlite3_mprintf("SELECT album_id FROM %s WHERE name=%Q AND artist=%Q", DB_TABLE_ALBUM, album, artist); - else - sql = sqlite3_mprintf("SELECT album_id FROM %s WHERE name=%Q AND artist IS NULL", DB_TABLE_ALBUM, album); + media_svc_retvm_if(!album, MS_MEDIA_ERR_INVALID_PARAMETER, "album is NULL"); + media_svc_retvm_if(!artist, MS_MEDIA_ERR_INVALID_PARAMETER, "artist is NULL"); + sql = sqlite3_mprintf("SELECT album_id FROM %s WHERE name=%Q AND artist=%Q", DB_TABLE_ALBUM, album, artist); ret = _media_svc_sql_prepare_to_step(handle, sql, &sql_stmt); - if (ret != MS_MEDIA_ERR_NONE) { if (ret == MS_MEDIA_ERR_DB_NO_RECORD) media_svc_debug("there is no album."); else - media_svc_error("error when _media_svc_get_album_id. err = [%d]", ret); + media_svc_error("failed to get album id[%d]", ret); return ret; } -- 2.7.4