From dbf7a02303855eb95261a0d568955e7948e1f939 Mon Sep 17 00:00:00 2001 From: Lokesh Date: Wed, 14 Nov 2018 11:08:41 +0530 Subject: [PATCH] Fix for 4 Svace issues. Added /* fall through */ comments, as there was no break statement at the end of case. Change-Id: I30fa2b77c21853abf1def469a6ba467f8b1e83a7 Signed-off-by: Lokesh --- src/stc-firewall.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/stc-firewall.c b/src/stc-firewall.c index ec1f674..ff2b704 100755 --- a/src/stc-firewall.c +++ b/src/stc-firewall.c @@ -451,6 +451,7 @@ static void __fw_rule_make_params(gpointer data, gpointer user_data) switch (rule->s_ip_type) { case STC_FW_IP_RANGE: + /* fall through */ case STC_FW_IP_MASK: addr = g_try_malloc0(INET_ADDRSTRLEN); if (addr) { @@ -459,6 +460,7 @@ static void __fw_rule_make_params(gpointer data, gpointer user_data) g_variant_new_string(addr)); FREE(addr); } + /* fall through */ case STC_FW_IP_SINGLE: addr = g_try_malloc0(INET_ADDRSTRLEN); if (addr) { @@ -474,6 +476,7 @@ static void __fw_rule_make_params(gpointer data, gpointer user_data) switch (rule->d_ip_type) { case STC_FW_IP_RANGE: + /* fall through */ case STC_FW_IP_MASK: addr = g_try_malloc0(INET_ADDRSTRLEN); if (addr) { @@ -482,6 +485,7 @@ static void __fw_rule_make_params(gpointer data, gpointer user_data) g_variant_new_string(addr)); FREE(addr); } + /* fall through */ case STC_FW_IP_SINGLE: addr = g_try_malloc0(INET_ADDRSTRLEN); if (addr) { @@ -499,6 +503,7 @@ static void __fw_rule_make_params(gpointer data, gpointer user_data) switch (rule->s_ip_type) { case STC_FW_IP_RANGE: + /* fall through */ case STC_FW_IP_MASK: addr = g_try_malloc0(INET6_ADDRSTRLEN); if (addr) { @@ -507,6 +512,7 @@ static void __fw_rule_make_params(gpointer data, gpointer user_data) g_variant_new_string(addr)); FREE(addr); } + /* fall through */ case STC_FW_IP_SINGLE: addr = g_try_malloc0(INET6_ADDRSTRLEN); if (addr) { @@ -522,6 +528,7 @@ static void __fw_rule_make_params(gpointer data, gpointer user_data) switch (rule->d_ip_type) { case STC_FW_IP_RANGE: + /* fall through */ case STC_FW_IP_MASK: addr = g_try_malloc0(INET6_ADDRSTRLEN); if (addr) { @@ -530,6 +537,7 @@ static void __fw_rule_make_params(gpointer data, gpointer user_data) g_variant_new_string(addr)); FREE(addr); } + /* fall through */ case STC_FW_IP_SINGLE: addr = g_try_malloc0(INET6_ADDRSTRLEN); if (addr) { -- 2.7.4