From: Lokesh <l.kasana@samsung.com>
Date: Wed, 14 Nov 2018 08:44:56 +0000 (+0530)
Subject: Fix for 4 Svace issues.
X-Git-Tag: accepted/tizen/5.0/unified/20181122.060304~2
X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fconnectivity%2Fstc-manager.git;a=commitdiff_plain;h=0cdb43cbff4da1a25af37b00907da0e0e47c14af

Fix for 4 Svace issues.

Added /* fall through */ comments, as there was no break statement at the end of case.

Change-Id: I0ccb184201d3881aed137abfbf837ce56f3bcb70
Signed-off-by: Lokesh <l.kasana@samsung.com>
---

diff --git a/src/stc-firewall.c b/src/stc-firewall.c
index ec1f674..ff2b704 100755
--- a/src/stc-firewall.c
+++ b/src/stc-firewall.c
@@ -451,6 +451,7 @@ static void __fw_rule_make_params(gpointer data, gpointer user_data)
 
 		switch (rule->s_ip_type) {
 		case STC_FW_IP_RANGE:
+			/* fall through */
 		case STC_FW_IP_MASK:
 			addr = g_try_malloc0(INET_ADDRSTRLEN);
 			if (addr) {
@@ -459,6 +460,7 @@ static void __fw_rule_make_params(gpointer data, gpointer user_data)
 							g_variant_new_string(addr));
 				FREE(addr);
 			}
+			/* fall through */
 		case STC_FW_IP_SINGLE:
 			addr = g_try_malloc0(INET_ADDRSTRLEN);
 			if (addr) {
@@ -474,6 +476,7 @@ static void __fw_rule_make_params(gpointer data, gpointer user_data)
 
 		switch (rule->d_ip_type) {
 		case STC_FW_IP_RANGE:
+			/* fall through */
 		case STC_FW_IP_MASK:
 			addr = g_try_malloc0(INET_ADDRSTRLEN);
 			if (addr) {
@@ -482,6 +485,7 @@ static void __fw_rule_make_params(gpointer data, gpointer user_data)
 							g_variant_new_string(addr));
 				FREE(addr);
 			}
+			/* fall through */
 		case STC_FW_IP_SINGLE:
 			addr = g_try_malloc0(INET_ADDRSTRLEN);
 			if (addr) {
@@ -499,6 +503,7 @@ static void __fw_rule_make_params(gpointer data, gpointer user_data)
 
 		switch (rule->s_ip_type) {
 		case STC_FW_IP_RANGE:
+			/* fall through */
 		case STC_FW_IP_MASK:
 			addr = g_try_malloc0(INET6_ADDRSTRLEN);
 			if (addr) {
@@ -507,6 +512,7 @@ static void __fw_rule_make_params(gpointer data, gpointer user_data)
 							g_variant_new_string(addr));
 				FREE(addr);
 			}
+			/* fall through */
 		case STC_FW_IP_SINGLE:
 			addr = g_try_malloc0(INET6_ADDRSTRLEN);
 			if (addr) {
@@ -522,6 +528,7 @@ static void __fw_rule_make_params(gpointer data, gpointer user_data)
 
 		switch (rule->d_ip_type) {
 		case STC_FW_IP_RANGE:
+			/* fall through */
 		case STC_FW_IP_MASK:
 			addr = g_try_malloc0(INET6_ADDRSTRLEN);
 			if (addr) {
@@ -530,6 +537,7 @@ static void __fw_rule_make_params(gpointer data, gpointer user_data)
 							g_variant_new_string(addr));
 				FREE(addr);
 			}
+			/* fall through */
 		case STC_FW_IP_SINGLE:
 			addr = g_try_malloc0(INET6_ADDRSTRLEN);
 			if (addr) {