From fe6286f617493d2f546939f4b6e2fb935c912e2c Mon Sep 17 00:00:00 2001 From: Jihoon Jung Date: Mon, 14 Oct 2019 23:49:14 +0900 Subject: [PATCH] Fix Coverity issues - Resource leak : 1087883, 1087991, 1087992 Change-Id: Ic3191b2c5aac190d48537cc6b03ccbb5a33f2158 Signed-off-by: Jihoon Jung --- src/wifi-dpp.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/wifi-dpp.c b/src/wifi-dpp.c index fdf7a8f..5d70239 100644 --- a/src/wifi-dpp.c +++ b/src/wifi-dpp.c @@ -330,7 +330,8 @@ static gchar *__netconfig_get_p2p_address(const char *if_path) { GVariant *params = NULL; GVariant *message = NULL; - GVariant *temp = NULL; + GVariant *temp1 = NULL; + GVariant *temp2 = NULL; guchar p2p_addr[MACADDR_LEN] = {0,}; gchar address_str[MACSTR_LEN] = {0,}; @@ -348,10 +349,13 @@ static gchar *__netconfig_get_p2p_address(const char *if_path) } DEBUG_G_VARIANT("reply:", message); - temp = g_variant_get_child_value(message, 0); - temp = g_variant_get_child_value(temp, 0); - DEBUG_G_VARIANT("temp:", temp); - __ws_unpack_ay(p2p_addr, temp, MACADDR_LEN); + temp1 = g_variant_get_child_value(message, 0); + temp2 = g_variant_get_child_value(temp1, 0); + DEBUG_G_VARIANT("temp2:", temp2); + __ws_unpack_ay(p2p_addr, temp2, MACADDR_LEN); + g_variant_unref(temp1); + g_variant_unref(temp2); + g_snprintf(address_str, MACSTR_LEN, MACSTR, MAC2STR(p2p_addr)); DBG("P2P address %s", address_str); @@ -1394,6 +1398,7 @@ gboolean __save_passphrase(GKeyFile *keyfile, gchar *group_name, gchar *key, gch ret = FALSE; } else { g_key_file_set_string(keyfile, group_name, key, enc_data); + g_free(enc_data); } return ret; -- 2.7.4