platform/core/connectivity/net-config.git
5 years agoFixed memory related issues reported by valgrind. 45/195645/1 accepted/tizen_5.0_unified tizen_5.0 accepted/tizen/5.0/unified/20181218.062848 submit/tizen_5.0/20181217.051837
Niraj Kumar Goit [Fri, 7 Dec 2018 10:02:56 +0000 (15:32 +0530)]
Fixed memory related issues reported by valgrind.

==1191== Invalid read of size 4
==1191==    at 0x4AF034C: g_variant_unref (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x49677AF: ??? (in /usr/lib/libgio-2.0.so.0.5200.2)
==1191==    by 0x4A232F3: g_object_unref (in /usr/lib/libgobject-2.0.so.0.5200.2)
==1191==    by 0x4973A33: ??? (in /usr/lib/libgio-2.0.so.0.5200.2)
==1191==    by 0x497555B: ??? (in /usr/lib/libgio-2.0.so.0.5200.2)
==1191==    by 0x4928777: ??? (in /usr/lib/libgio-2.0.so.0.5200.2)
==1191==    by 0x49287AB: ??? (in /usr/lib/libgio-2.0.so.0.5200.2)
==1191==    by 0x4AB08E7: g_main_context_dispatch (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x4AB0C77: ??? (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x4AB0FD7: g_main_loop_run (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x497389F: ??? (in /usr/lib/libgio-2.0.so.0.5200.2)
==1191==    by 0x4AD9B3B: ??? (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==  Address 0x86ac014 is 20 bytes inside a block of size 24 free'd
==1191==    at 0x4846EC8: free (vg_replace_malloc.c:530)
==1191==    by 0x113FFD: __netconfig_wifi_bssid_create_interface (wifi-bssid-scan.c:454)
==1191==    by 0x113FFD: __netconfig_wifi_bssid_scan (wifi-bssid-scan.c:486)
==1191==    by 0x113FFD: handle_request_bssid_scan (wifi-bssid-scan.c:529)
==1191==    by 0x4E45AF7: ffi_call_SYSV (in /usr/lib/libffi.so.6.0.2)
==1191==  Block was alloc'd at
==1191==    at 0x48458A4: malloc (vg_replace_malloc.c:299)
==1191==    by 0x4AB61B3: g_malloc (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x4ACF4A3: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x4AF01EF: ??? (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x4AEC8E7: g_variant_builder_end (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x4AEE6C7: ??? (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x4AEE9FF: g_variant_new_va (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x4AEEAC3: g_variant_new (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x113FB7: __netconfig_wifi_bssid_create_interface (wifi-bssid-scan.c:438)
==1191==    by 0x113FB7: __netconfig_wifi_bssid_scan (wifi-bssid-scan.c:486)
==1191==    by 0x113FB7: handle_request_bssid_scan (wifi-bssid-scan.c:529)
==1191==    by 0x4E45AF7: ffi_call_SYSV (in /usr/lib/libffi.so.6.0.2)

Change-Id: If9fa9f2a0e6e2b6f201a486d333ed153c0581b98
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agog_free 'field' and 'value' if you break out of a while loop. 44/195644/1
Niraj Kumar Goit [Thu, 29 Nov 2018 13:50:30 +0000 (19:20 +0530)]
g_free 'field' and 'value' if you break out of a while loop.

g_free 'field' and 'value' if you break out of a while loop
using g_variant_iter_loop()

Change-Id: I4d76f723d9cedb3772a0f86db97152077cbfe7be
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoRemove GSource before calling g_timeout_add() 43/195643/1
Cheoleun Moon [Tue, 4 Dec 2018 23:19:04 +0000 (08:19 +0900)]
Remove GSource before calling g_timeout_add()

Change-Id: I4f7af8297b298496e31577c381fd02b1024a0f23
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>
5 years agoStart IP conflict monitoring only after default profile has been updated 30/192430/1 accepted/tizen/5.0/unified/20181107.081750 submit/tizen_5.0/20181106.114602
Abhishek Sansanwal [Tue, 23 Oct 2018 05:52:06 +0000 (11:22 +0530)]
Start IP conflict monitoring only after default profile has been updated

Signed-off-by: Abhishek Sansanwal <abhishek.s94@samsung.com>
Change-Id: I113a4f033a5bb398a494195fb4de11957cd7e7ff

5 years agoCreate temporary file to check wifi firmware state #3 29/192429/1
Seonah Moon [Mon, 22 Oct 2018 09:31:20 +0000 (18:31 +0900)]
Create temporary file to check wifi firmware state #3

Change-Id: I174f255dc49f2883b5ddc945e4375720327dc820

5 years agoCreate temporary file to check wifi firmware state #2 28/192428/1
Seonah Moon [Mon, 22 Oct 2018 09:03:40 +0000 (18:03 +0900)]
Create temporary file to check wifi firmware state #2

Change-Id: I8c2c4d287021f6b0b76fa23d947e98e32995f1c8

5 years agoCreate temporary file to check wifi firmware state 27/192427/1
Seonah Moon [Tue, 16 Oct 2018 08:32:29 +0000 (17:32 +0900)]
Create temporary file to check wifi firmware state

If net-config is finished unexpectly, it restarts.
And then wifi firmware is downloaded although it is already loaded.

This patch creates the file to check whether wifi firmware is loaded or not.

Change-Id: I4d8dbc4538d28d2c0eef7f945947bf007e47c73d

5 years agoChange signal level policy 75/190675/1 accepted/tizen/5.0/unified/20181102.015009 accepted/tizen/unified/20181010.061706 submit/tizen/20181004.140159 submit/tizen/20181005.071221 submit/tizen_5.0/20181101.000003
Jaehyun Kim [Thu, 4 Oct 2018 13:09:39 +0000 (22:09 +0900)]
Change signal level policy

Change-Id: I41b9e45518c1198b16b7208f2918999418c41ca2
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoFixed incorrect comparision and memory leaks 46/189546/2 accepted/tizen/unified/20180919.061656 submit/tizen/20180919.023413
Saurav Babu [Tue, 18 Sep 2018 11:14:04 +0000 (16:44 +0530)]
Fixed incorrect comparision and memory leaks

This patch fixes incorrect comparion for GVariantType and also fixes
memory leak reported by valgrind
==9934== 20 bytes in 2 blocks are definitely lost in loss record 1,388 of 2,620
==9934==    at 0x48458A4: malloc (vg_replace_malloc.c:299)
==9934==    by 0x4AB21B3: g_malloc (in /usr/lib/libglib-2.0.so.0.5200.2)
==9934==    by 0x4ACCF03: g_strdup (in /usr/lib/libglib-2.0.so.0.5200.2)
==9934==    by 0x123CEB: __netconfig_get_default_connection_info (network-state.c:409)
==9934==    by 0x124933: netconfig_update_default_profile (network-state.c:1210)
==9934==    by 0x1290AD: _service_signal_cb (signal-handler.c:358)
==9934==    by 0x4957997: ??? (in /usr/lib/libgio-2.0.so.0.5200.2)
==9934==    by 0x4AAC8E7: g_main_context_dispatch (in /usr/lib/libglib-2.0.so.0.5200.2)
==9934==    by 0x4AACC77: ??? (in /usr/lib/libglib-2.0.so.0.5200.2)
==9934==    by 0x4AACFD7: g_main_loop_run (in /usr/lib/libglib-2.0.so.0.5200.2)
==9934==    by 0x10F649: main (main.c:152)

Change-Id: I4e9791440ce4bc28968add19816d9e664cea9e62
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
5 years agoMerge "Added support to set and get prefix length." into tizen submit/tizen/20180918.091131
Jaehyun Kim [Tue, 18 Sep 2018 07:49:49 +0000 (07:49 +0000)]
Merge "Added support to set and get prefix length." into tizen

5 years agoFix coverity(1025915) issue. 11/189411/1
Niraj Kumar Goit [Mon, 17 Sep 2018 11:07:39 +0000 (16:37 +0530)]
Fix coverity(1025915) issue.

Added check on prefix length to fix bad bit shift issue.

Change-Id: I9402ef63b03f7e63a1a54d954c6f74e42d460330
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoAdded support to set and get prefix length. 64/189264/1
Niraj Kumar Goit [Fri, 14 Sep 2018 15:21:48 +0000 (20:51 +0530)]
Added support to set and get prefix length.

Added support to set and get prefix length from configuration file.

Change-Id: I17144c9a6a515ad8efcbc5ae2ca5199ef56cbcdb
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoRevert "Added support to add ipv6 route using netlink." 75/189075/1
Seonah Moon [Thu, 13 Sep 2018 07:15:27 +0000 (16:15 +0900)]
Revert "Added support to add ipv6 route using netlink."

This reverts commit cb573910888d91558cf3d2beb28187850eccc9ad.

Change-Id: I4e11785eb874be44dfe2988d7902aae9d1ccd514

5 years agoRevert "Added support to delete ipv6 route using netlink." 74/189074/1
Seonah Moon [Thu, 13 Sep 2018 07:14:36 +0000 (16:14 +0900)]
Revert "Added support to delete ipv6 route using netlink."

This reverts commit a259e3e99a5382699c19fc50288bf46eb03f18a4.

Change-Id: I488cb1554159ac05edfdcd6e2c8640bdf9ff78de

5 years agoMerge "Modify HAL TC to support wearable environment" into tizen accepted/tizen/unified/20180912.061658 submit/tizen/20180911.120738
Jaehyun Kim [Tue, 11 Sep 2018 12:05:59 +0000 (12:05 +0000)]
Merge "Modify HAL TC to support wearable environment" into tizen

5 years agoAdd feature check code for softap 97/188897/2
Seonah Moon [Tue, 11 Sep 2018 11:45:00 +0000 (20:45 +0900)]
Add feature check code for softap

Change-Id: If02dfe0bb3983bf0f969ddc4611fcb76583f86b7

5 years agoModify HAL TC to support wearable environment 96/188896/1
Jaehyun Kim [Tue, 11 Sep 2018 11:30:46 +0000 (20:30 +0900)]
Modify HAL TC to support wearable environment

Change-Id: I7e9d3332387ffbb51ea15e42bbad9346aa1c4c31
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoFix coverity issue (1025915). 88/188888/1
Niraj Kumar Goit [Tue, 11 Sep 2018 09:54:07 +0000 (15:24 +0530)]
Fix coverity issue (1025915).

Change-Id: I51b5cab5bc94232c7a389a5632863cb75cc23c79
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoSupport Softap feature in HAL TC 36/188836/1
Jaehyun Kim [Tue, 11 Sep 2018 04:17:50 +0000 (13:17 +0900)]
Support Softap feature in HAL TC

Change-Id: I9592e806316f725f3a5f62cf9cbd808049fbb82e
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoAdded exception handling for unsupported features in HAL TC 32/188832/1
Jaehyun Kim [Tue, 11 Sep 2018 04:09:12 +0000 (13:09 +0900)]
Added exception handling for unsupported features in HAL TC

Change-Id: I3144d40e4c2801d798c9563c468157001c74d222
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoFixed memory leaks 04/188804/1 accepted/tizen/unified/20180911.055420 submit/tizen/20180910.131901
Saurav Babu [Mon, 10 Sep 2018 10:46:34 +0000 (16:16 +0530)]
Fixed memory leaks

g_variant_builder_new() allocates memory and should be freed using
g_variant_builder_unref().
Below is the valgrind report:
==6712== 72 bytes in 1 blocks are definitely lost in loss record 2,933 of 3,062
==6712==    at 0x48458A4: malloc (vg_replace_malloc.c:299)
==6712==    by 0x4AB21B3: g_malloc (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x4ACB4A3: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x4AE82BF: g_variant_builder_new (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x1236F1: __netconfig_update_default_connection_info (network-state.c:797)
==6712==    by 0x125727: netconfig_update_default_profile (network-state.c:1206)
==6712==    by 0x12AA1D: _service_signal_cb (signal-handler.c:355)
==6712==    by 0x4957997: ??? (in /usr/lib/libgio-2.0.so.0.5200.2)
==6712==    by 0x4AAC8E7: g_main_context_dispatch (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x4AACC77: ??? (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x4AACFD7: g_main_loop_run (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x10F9F9: main (main.c:152)
==6712==
==6712== 72 bytes in 1 blocks are definitely lost in loss record 2,934 of 3,062
==6712==    at 0x48458A4: malloc (vg_replace_malloc.c:299)
==6712==    by 0x4AB21B3: g_malloc (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x4ACB4A3: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x4AE82BF: g_variant_builder_new (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x123A8D: __netconfig_update_default_connection_info (network-state.c:764)
==6712==    by 0x125923: netconfig_update_default_profile (network-state.c:1193)
==6712==    by 0x12B71F: _service_signal_cb (signal-handler.c:399)
==6712==    by 0x4957997: ??? (in /usr/lib/libgio-2.0.so.0.5200.2)
==6712==    by 0x4AAC8E7: g_main_context_dispatch (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x4AACC77: ??? (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x4AACFD7: g_main_loop_run (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x10F9F9: main (main.c:152)

Change-Id: I2306aaa418fb04d29f7f717a25c0abe4bf47dc30
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
5 years agoMerge "Fixed crash in accessing non allocated memory" into tizen accepted/tizen/unified/20180907.043103 submit/tizen/20180906.090023
Jaehyun Kim [Thu, 6 Sep 2018 08:58:31 +0000 (08:58 +0000)]
Merge "Fixed crash in accessing non allocated memory" into tizen

5 years agoFixed crash in accessing non allocated memory 64/188564/2
Saurav Babu [Thu, 6 Sep 2018 06:23:21 +0000 (11:53 +0530)]
Fixed crash in accessing non allocated memory

In _load_configuration() config->ip_info was accessed without checking
if it was allocated. This patch ensures that config->ip_info is always
allocated when passing in _load_configuration() function.

Change-Id: I61c5bc168915b9d4f4f6ba976132cfcf3836753f
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
5 years agoMerge "Fixed memory leak" into tizen submit/tizen/20180904.110831
Jaehyun Kim [Tue, 4 Sep 2018 11:07:09 +0000 (11:07 +0000)]
Merge "Fixed memory leak" into tizen

5 years agoMerge "Added support to set and get IP configuration details." into tizen
Jaehyun Kim [Tue, 4 Sep 2018 11:06:03 +0000 (11:06 +0000)]
Merge "Added support to set and get IP configuration details." into tizen

5 years agoFixed memory leak 53/188253/1
Saurav Babu [Mon, 3 Sep 2018 10:02:21 +0000 (15:32 +0530)]
Fixed memory leak

g_ascii_strdown() returns a newly allocated string and should be freed
with g_free().
Below is the valgrind report complaining about the leak
==7455== 216 bytes in 12 blocks are definitely lost in loss record 3,009 of 3,068
==7455==    at 0x48458A4: malloc (vg_replace_malloc.c:299)
==7455==    by 0x4AB11B3: g_malloc (gmem.c:94)
==7455==    by 0x4ACBF73: g_strndup (gstrfuncs.c:425)
==7455==    by 0x4ACC9A7: g_ascii_strdown (gstrfuncs.c:1517)
==7455==    by 0x12F0E7: __get_mac_address (wifi-config.c:180)
==7455==    by 0x12F0E7: __get_group_name.constprop.4 (wifi-config.c:199)
==7455==    by 0x12F75B: _load_configuration (wifi-config.c:312)
==7455==    by 0x13133D: handle_load_configuration (wifi-config.c:1052)
==7455==    by 0x4E40AF7: ffi_call_SYSV (in /usr/lib/libffi.so.6.0.2)

Change-Id: I979c0daef4572a3a77a2f75e81ccfea0c8781fe0
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
5 years agoAdded support to set and get IP configuration details. 98/186498/4
Niraj Kumar Goit [Fri, 10 Aug 2018 03:34:23 +0000 (09:04 +0530)]
Added support to set and get IP configuration details.

Change-Id: I08320822454355853883991cad0d8b0ae58f5e36
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoMerge "Fix dbus methods for mptcp" into tizen submit/tizen/20180903.045143
Jaehyun Kim [Mon, 3 Sep 2018 04:13:22 +0000 (04:13 +0000)]
Merge "Fix dbus methods for mptcp" into tizen

5 years agoChange the directory and header file name for HAL TC 43/188043/1 submit/tizen/20180831.123807
Jaehyun Kim [Thu, 30 Aug 2018 13:16:26 +0000 (22:16 +0900)]
Change the directory and header file name for HAL TC

Change-Id: Ib1b701d14d35c9c34a819c12e2c1014660f92101
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoFix dbus methods for mptcp 35/187835/3
Seonah Moon [Wed, 29 Aug 2018 01:31:14 +0000 (10:31 +0900)]
Fix dbus methods for mptcp

Change-Id: Ice73114dcbb230b02f493dba648f15b591195d24

5 years agoChange owner and group of /usr/lib/udev/rules.d/99-wifiusb-dev.rules 25/187725/1 accepted/tizen/unified/20180831.061745 submit/tizen/20180828.112014 submit/tizen/20180830.132815
INSUN PYO [Tue, 28 Aug 2018 05:23:14 +0000 (14:23 +0900)]
Change owner and group of /usr/lib/udev/rules.d/99-wifiusb-dev.rules

Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: Ib1a7e47164d8e8d1b40399bf4159058f3c26c1e9

5 years agoMerge "Added support to set private-key password." into tizen accepted/tizen/unified/20180830.060928 submit/tizen/20180829.082616
Jaehyun Kim [Fri, 24 Aug 2018 05:15:03 +0000 (05:15 +0000)]
Merge "Added support to set private-key password." into tizen

5 years agoChange the HAL TC name to same as package name 67/186967/2 accepted/tizen/unified/20180817.140757 submit/tizen/20180817.033930
Jaehyun Kim [Fri, 17 Aug 2018 02:13:11 +0000 (11:13 +0900)]
Change the HAL TC name to same as package name

Change-Id: I40fae0eeaa60dfea4147d5f2c29463a0d2ecd0f1
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoCombine the HAL TCs into one file 64/186764/1 accepted/tizen/unified/20180814.175012 submit/tizen/20180814.072804
Jaehyun Kim [Tue, 14 Aug 2018 06:59:49 +0000 (15:59 +0900)]
Combine the HAL TCs into one file

Change-Id: I3e7f8be918d088ee6b4dfe1d53223cc96a9df772
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoRename HAL TC files 47/186747/1 submit/tizen/20180814.054518
Jaehyun Kim [Tue, 14 Aug 2018 05:31:32 +0000 (14:31 +0900)]
Rename HAL TC files

Change-Id: Ie4c22435b635b2dc3e82828c3ec7957afbe51013
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoMerge "Avoid Null Check before g_free()." into tizen
taesub kim [Mon, 13 Aug 2018 08:18:47 +0000 (08:18 +0000)]
Merge "Avoid Null Check before g_free()." into tizen

5 years agoDisable TIZEN_DEBUG_ENABLE feature for wearable profile 72/186172/3 accepted/tizen/unified/20180808.063415 submit/tizen/20180808.022337
taesub.kim [Wed, 8 Aug 2018 02:04:26 +0000 (11:04 +0900)]
Disable TIZEN_DEBUG_ENABLE feature for wearable profile

Change-Id: I03950f53fcfeb3e1ef5c1c71f5423c29199edc95
Signed-off-by: Taesub Kim <taesub.kim@samsung.com>
5 years agoAdded support to set private-key password. 61/186061/1
Niraj Kumar Goit [Tue, 7 Aug 2018 05:03:59 +0000 (10:33 +0530)]
Added support to set private-key password.

Added support to set private-key password and it is valid
for EAP-TLS.
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Change-Id: I7499655f5237fea0f3fb38f39c36f67a5ee4eb96

5 years agoMerge "Don't free dbus method invocation twice" into tizen accepted/tizen/unified/20180726.140742 submit/tizen/20180726.054446
taesub kim [Thu, 26 Jul 2018 05:42:43 +0000 (05:42 +0000)]
Merge "Don't free dbus method invocation twice" into tizen

5 years agoDon't free dbus method invocation twice 32/185032/2
Saurav Babu [Wed, 25 Jul 2018 09:24:48 +0000 (14:54 +0530)]
Don't free dbus method invocation twice

Change-Id: I6b006b5c547d809acd6c4126da35cc3d80869585
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
5 years ago[Fix][stack-buffer-overflow] Use gboolean when using g_variant_get for boolean. 36/185036/1
Nishant Chaprana [Wed, 25 Jul 2018 09:52:06 +0000 (15:22 +0530)]
[Fix][stack-buffer-overflow] Use gboolean when using g_variant_get for boolean.

Description: g_variant_get API expects reference of gboolean variable
in third parameter, and we arepassing reference of bool variable.

As per Glib's documentation, gboolean is typecast of int.
=================================================================
(Reference: https://people.gnome.org/~desrt/glib-docs/glib-Basic-Types.html#gboolean)

gboolean

typedef gint   gboolean;

A standard boolean type. Variables of this type should only contain the value TRUE or FALSE.
=================================================================

Change-Id: I84f0120229a2a9eeec976b1785d5cc4d112db534
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
5 years agoAvoid Null Check before g_free(). 82/184882/1
Rahul Jain [Tue, 24 Jul 2018 05:45:10 +0000 (11:15 +0530)]
Avoid Null Check before g_free().

Change-Id: Ibebc50255f075ad0a931fc7bfc180caef1fc14a1
Signed-off-by: Bhaskar Dutta <bhaskar.d@samsung.com>
Signed-off-by: Rahul Jain <rahul.jain@samsung.com>
5 years agoMerge "Fix for CID:860302" into tizen accepted/tizen/unified/20180711.132737 submit/tizen/20180709.041434
taesub kim [Mon, 9 Jul 2018 04:13:19 +0000 (04:13 +0000)]
Merge "Fix for CID:860302" into tizen

5 years agoMerge "Fix for CID:860243" into tizen
taesub kim [Mon, 9 Jul 2018 04:13:06 +0000 (04:13 +0000)]
Merge "Fix for CID:860243" into tizen

5 years agoFix for CID:860302 17/183517/1
Abhishek Sansanwal [Fri, 6 Jul 2018 06:27:08 +0000 (11:57 +0530)]
Fix for CID:860302

Signed-off-by: Abhishek Sansanwal <abhishek.s94@samsung.com>
Change-Id: I1083261df5bf83d5dec91544c2eab9257c405232

5 years agoFix for CID:860282 05/183505/2
Abhishek Sansanwal [Fri, 6 Jul 2018 05:46:35 +0000 (11:16 +0530)]
Fix for CID:860282

Description: Call g_free on resource before return.

Signed-off-by: Abhishek Sansanwal <abhishek.s94@samsung.com>
Change-Id: I66412afbec1ad04e5e16a2edfe96f913ee1ceb1d

5 years agoMerge "Set passphrase for connman service when connecting using WPS without SSID... accepted/tizen/unified/20180709.064832 submit/tizen/20180706.050915
taesub kim [Fri, 6 Jul 2018 04:01:58 +0000 (04:01 +0000)]
Merge "Set passphrase for connman service when connecting using WPS without SSID" into tizen

5 years agoMerge "net-config:Generalize the setting of rps_cpus" into tizen
taesub kim [Fri, 6 Jul 2018 04:01:37 +0000 (04:01 +0000)]
Merge "net-config:Generalize the setting of rps_cpus" into tizen

5 years agoSet passphrase for connman service when connecting using WPS without SSID 35/183435/2
Saurav Babu [Thu, 5 Jul 2018 09:39:42 +0000 (15:09 +0530)]
Set passphrase for connman service when connecting using WPS without SSID

Change-Id: Ifb6ce45997e0f1275ae09d99418d6fac510293d4
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
5 years agoAdd exception handle for google test framework 65/183365/2
Taesoo Jun [Thu, 5 Jul 2018 02:01:16 +0000 (11:01 +0900)]
Add exception handle for google test framework

Change-Id: Ie8a465b9cbcbb0f4a055c790ee9687de63f378b5
Signed-off-by: Taesoo Jun <steve.jun@samsung.com>
5 years agoFix memory corruption in unittest 63/183363/2
Taesoo Jun [Thu, 5 Jul 2018 01:47:01 +0000 (10:47 +0900)]
Fix memory corruption in unittest

Change-Id: I075961d576735dd852939a70b276c1adbcd9a65a
Signed-off-by: Taesoo Jun <steve.jun@samsung.com>
5 years agonet-config:Generalize the setting of rps_cpus 31/183231/2
Mayank Haarit [Tue, 3 Jul 2018 11:44:36 +0000 (17:14 +0530)]
net-config:Generalize the setting of rps_cpus

This patch generalize the logic to set rps_cpus in
all receive queues of the wlan interface.

Change-Id: I2b4c2883338bcbaa989d52f9a1beac1409e2a5c7
Signed-off-by: Mayank Haarit <mayank.h@samsung.com>
5 years agoAdded dump log for connect fail #2 56/182956/1 accepted/tizen/unified/20180702.151346 submit/tizen/20180702.034741
taesub kim [Fri, 29 Jun 2018 06:50:58 +0000 (15:50 +0900)]
Added dump log for connect fail #2

Change-Id: Ied11589a7fcb26e9d285fd2304c3ae46be257567
Signed-off-by: Taesub Kim <taesub.kim@samsung.com>
5 years agoAdd a dbus rule for MPTCP 29/182629/1 accepted/tizen/unified/20180628.061157 submit/tizen/20180626.233453
chleun.moon [Tue, 26 Jun 2018 23:30:08 +0000 (08:30 +0900)]
Add a dbus rule for MPTCP

Change-Id: I211eac23a47bfdf2d827fa3359e96c9541b0b8ad
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>
5 years agoFix dbus method return value #2 20/182220/1 accepted/tizen/unified/20180622.122710 submit/tizen/20180622.032935
taesub kim [Thu, 21 Jun 2018 08:46:01 +0000 (17:46 +0900)]
Fix dbus method return value #2

Change-Id: Id2fde617f3160ef03c75ce5ebbf54043f0f94697
Signed-off-by: Taesub Kim <taesub.kim@samsung.com>
5 years agoAdded requires(tcpdump) in spec file 97/181497/1 accepted/tizen/unified/20180615.160540 submit/tizen/20180614.233117
taesub kim [Thu, 14 Jun 2018 08:45:41 +0000 (17:45 +0900)]
Added requires(tcpdump) in spec file

Change-Id: Ica164e3c5c8c19cd12a717382004ae2f035c74f7
Signed-off-by: Taesub Kim <taesub.kim@samsung.com>
5 years agoMerge "Added dump log for connect fail" into tizen accepted/tizen/unified/20180612.044202 submit/tizen/20180612.012523
taesub kim [Tue, 12 Jun 2018 00:26:53 +0000 (00:26 +0000)]
Merge "Added dump log for connect fail" into tizen

5 years agoMerge "Fix bug in Ip conflict set/get enabled API's" into tizen
taesub kim [Tue, 12 Jun 2018 00:25:28 +0000 (00:25 +0000)]
Merge "Fix bug in Ip conflict set/get enabled API's" into tizen

5 years agoMerge "Added initial code for Gtest" into tizen
taesub kim [Tue, 12 Jun 2018 00:25:13 +0000 (00:25 +0000)]
Merge "Added initial code for Gtest" into tizen

5 years agoMerge "Added support to delete ipv6 route using netlink." into tizen
taesub kim [Mon, 11 Jun 2018 23:57:05 +0000 (23:57 +0000)]
Merge "Added support to delete ipv6 route using netlink." into tizen

5 years agoMerge "Added support to add ipv6 route using netlink." into tizen
taesub kim [Mon, 11 Jun 2018 23:56:43 +0000 (23:56 +0000)]
Merge "Added support to add ipv6 route using netlink." into tizen

5 years agoAdded dump log for connect fail 89/180689/2
taesub kim [Fri, 1 Jun 2018 06:41:04 +0000 (15:41 +0900)]
Added dump log for connect fail

Change-Id: If027e6a5ddfed1ecbcc9d663ecec2fb1711fc7c8
Signed-off-by: Taesub Kim <taesub.kim@samsung.com>
5 years agoAdded initial code for Gtest 26/180226/3
Abhishek Sansanwal [Fri, 25 May 2018 11:45:09 +0000 (17:15 +0530)]
Added initial code for Gtest

Signed-off-by: Abhishek Sansanwal <abhishek.s94@samsung.com>
Change-Id: Ie1b8c8f8c9514074186c9941c2f4437269acadf0

5 years agoAdded support to delete ipv6 route using netlink. 41/180241/1
Niraj Kumar Goit [Fri, 25 May 2018 14:59:57 +0000 (20:29 +0530)]
Added support to delete ipv6 route using netlink.

Change-Id: I48ce91cf0adffdd93806529e3e77930727f963ed
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoAdded support to add ipv6 route using netlink. 38/180238/2
Niraj Kumar Goit [Fri, 25 May 2018 14:10:17 +0000 (19:40 +0530)]
Added support to add ipv6 route using netlink.

Change-Id: I65d2b3565d4a5cdab1d091e3c1d4dd8c3259a3b0
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoFix bug in Ip conflict set/get enabled API's 36/180236/1
Abhishek Sansanwal [Fri, 25 May 2018 13:55:11 +0000 (19:25 +0530)]
Fix bug in Ip conflict set/get enabled API's

After each reboot the enabled state was being misreported
if WiFi was not connected to an AP previously.

Signed-off-by: Abhishek Sansanwal <abhishek.s94@samsung.com>
Change-Id: Iadcd7c4af5a82c748e97325e04f9520a963d17ed

5 years agoSend Dbus error message to upper layer 25/179825/2
Mayank Haarit [Tue, 22 May 2018 15:06:42 +0000 (20:36 +0530)]
Send Dbus error message to upper layer

This patch is to send error message on failing nl socket calls.

Change-Id: I259f58470efbdbfead0047655f651e150be33422
Signed-off-by: Mayank Haarit <mayank.h@samsung.com>
5 years agoSet netlink scan handle in non-blocking state 16/179816/4
Mayank Haarit [Tue, 22 May 2018 11:59:45 +0000 (17:29 +0530)]
Set netlink scan handle in non-blocking state

This patch is to set nl socket handle in non-blocking
state.

Change-Id: I7bb6b295445d9967a3d9cb725d76e01b7c2a08ca
Signed-off-by: Mayank Haarit <mayank.h@samsung.com>
5 years agoSet the RPS configuration on Wi-Fi activate. 36/179736/2
Mayank Haarit [Mon, 21 May 2018 12:53:36 +0000 (18:23 +0530)]
Set the RPS configuration on Wi-Fi activate.

This patch enable RPS (Received packet steering) and specific CPUs
to process the packet for the receive queues of the wlan0 interface.

Change-Id: Ide73358ac99f49eb2c7254fe1a7026f491e58cfd
Signed-off-by: Mayank Haarit <mayank.h@samsung.com>
5 years agoMerge "ip-conflict: Don't remove already removed timer" into tizen submit/tizen/20180521.002723
taesub kim [Fri, 18 May 2018 04:56:01 +0000 (04:56 +0000)]
Merge "ip-conflict: Don't remove already removed timer" into tizen

5 years agoMerge "Fixed getting values from variant" into tizen
taesub kim [Fri, 18 May 2018 04:55:40 +0000 (04:55 +0000)]
Merge "Fixed getting values from variant" into tizen

5 years agoAdded vsie list of APs in netlink scan results 59/179259/3
Mayank Haarit [Wed, 16 May 2018 15:46:58 +0000 (21:16 +0530)]
Added vsie list of APs in netlink scan results

This patch includes below implementation :
1) Implemented funtionality to send the vsie list of APs in netlink
scan results , Previously It was sending only one vsie in netlink scan results.
2) Modified the logic to extract vsie info from the BSS infromation
elements, Previously It was checking only one of the BSS information elements.

Change-Id: I5b0d222ab1ac9c1e63373da49ea58e35ec40eba1
Signed-off-by: Mayank Haarit <mayank.h@samsung.com>
5 years agoip-conflict: Don't remove already removed timer 57/179357/1
Saurav Babu [Thu, 17 May 2018 10:05:06 +0000 (15:35 +0530)]
ip-conflict: Don't remove already removed timer

sd->timer_id is already removed in the callback function, it is not
required to remove this source again

Change-Id: I977d923ce03657d93f28fcf13472321b1b420896
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
5 years agoFixed getting values from variant 51/179351/1
Saurav Babu [Thu, 17 May 2018 08:23:19 +0000 (13:53 +0530)]
Fixed getting values from variant

Supplicant sends PropertiesChanged for multiple keys and variant of
these keys doesn't always contain string(e.g. For key Bsss variant is ao).
This patch prints variant instead of extracting string from variant

Change-Id: Ifdc6ba7619c66880db60b86bab8a90309252dca3
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
5 years agoRemove unused net-config DBus interface. 77/179077/1 accepted/tizen/unified/20180518.060603 submit/tizen/20180516.084045 submit/tizen/20180517.074625
Niraj Kumar Goit [Tue, 15 May 2018 13:57:00 +0000 (19:27 +0530)]
Remove unused net-config DBus interface.

Change-Id: I9bd89ecd1990a7e833cdcff6f7a3e71aed068598
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoRemove the log included secure information 04/179004/2 accepted/tizen/unified/20180515.163445 submit/tizen/20180515.082039
Seonah Moon [Tue, 15 May 2018 08:02:07 +0000 (17:02 +0900)]
Remove the log included secure information

Change-Id: Ib324397e244ab537cbc68f7346a5e9dc41cdcccb

5 years agoRemove unused vconf key 92/178792/1 accepted/tizen/unified/20180514.094241 submit/tizen/20180514.053629
Seonah Moon [Mon, 14 May 2018 05:26:54 +0000 (14:26 +0900)]
Remove unused vconf key

Change-Id: I6f39b248db34ecc3d62417f590d2476156b49cd9

5 years agoExclude /usr/bin/net-config.wearable from net-config rpm 22/178522/2 accepted/tizen/unified/20180511.073927 submit/tizen/20180510.091306
chleun.moon [Thu, 10 May 2018 08:34:04 +0000 (17:34 +0900)]
Exclude /usr/bin/net-config.wearable from net-config rpm

Change-Id: I63aee1d6376e06460c1cd9ef16fb647898356d3d
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>
5 years agoChange HAL TC rpm name 47/177447/1 accepted/tizen/unified/20180503.080656 submit/tizen/20180430.044726 submit/tizen/20180502.015243
Jaehyun Kim [Mon, 30 Apr 2018 04:31:17 +0000 (13:31 +0900)]
Change HAL TC rpm name

Change-Id: Ife7a176c08ee9176f9d165bfa126d700f81819e5
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoSeparate HAL TC code into a separate package 59/177359/1 accepted/tizen/unified/20180430.072140 submit/tizen/20180427.093512
Jaehyun Kim [Fri, 27 Apr 2018 09:16:15 +0000 (18:16 +0900)]
Separate HAL TC code into a separate package

Change-Id: Ic7d26b839fa950c4c4cfd79d49287a24f34b61e7
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
6 years agoRevert "Revise driver load routine" 34/176934/2 accepted/tizen/unified/20180426.145751 submit/tizen/20180425.083528 submit/tizen/20180426.014409
Seonah Moon [Tue, 24 Apr 2018 08:21:51 +0000 (17:21 +0900)]
Revert "Revise driver load routine"

Change-Id: I81661b82876b139b2f82be0588091fc212ce0285

6 years agoFix memory leak in __netconfig_netlink_scan_cb 69/175269/1 accepted/tizen/unified/20180413.073636 submit/tizen/20180413.011058
Taesoo Jun [Tue, 10 Apr 2018 04:00:29 +0000 (13:00 +0900)]
Fix memory leak in __netconfig_netlink_scan_cb

Change-Id: Ie136f4b3e39f6fdbe24b74f8d000b7d149f28e74

6 years agoFix memory leak in __netconfig_request_netlink_scan() 67/175267/1
Taesoo Jun [Tue, 10 Apr 2018 02:49:57 +0000 (11:49 +0900)]
Fix memory leak in __netconfig_request_netlink_scan()

Change-Id: I175131016b300e3ad9ffd9fce67c98b1c63d0ae3

6 years agoFixed some coverity 74/174574/1 accepted/tizen/unified/20180406.144316 submit/tizen/20180406.023145
hyunuktak [Tue, 3 Apr 2018 05:25:40 +0000 (14:25 +0900)]
Fixed some coverity

CID : 113930, 108826, 107165, 107210, 105204

Change-Id: Ic36d775ea1e782571a3b35062479593b9a754a2c
Signed-off-by: hyunuktak <hyunuk.tak@samsung.com>
6 years agoMerge "Fix a coverity for identical code" into tizen accepted/tizen/unified/20180403.060105 submit/tizen/20180329.102914
Jaehyun Kim [Thu, 29 Mar 2018 10:25:03 +0000 (10:25 +0000)]
Merge "Fix a coverity for identical code" into tizen

6 years agoFix coverity issuses. 42/174042/3
Niraj Kumar Goit [Tue, 27 Mar 2018 13:41:40 +0000 (19:11 +0530)]
Fix coverity issuses.

CID: 105915, 107014, 107561, 110117

Change-Id: Iad5807e3a5587a80614df1aeb4f9ced0ce8bd267
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
6 years agoFix a coverity for identical code 02/174102/1
hyunuktak [Wed, 28 Mar 2018 05:46:30 +0000 (14:46 +0900)]
Fix a coverity for identical code

Change-Id: I8f7f2b3d470b51563cdc09d1c3d062f106279926
Signed-off-by: hyunuktak <hyunuk.tak@samsung.com>
6 years agoMerge "Fixed some svaces for strerror" into tizen submit/tizen/20180327.123653
Jaehyun Kim [Tue, 27 Mar 2018 07:54:22 +0000 (07:54 +0000)]
Merge "Fixed some svaces for strerror" into tizen

6 years agoFixed some svaces for strerror 69/173769/1
hyunuktak [Mon, 26 Mar 2018 01:24:11 +0000 (10:24 +0900)]
Fixed some svaces for strerror

Change-Id: I3c7e629f375867d1a25654f2e2a2d4f7cf58ce81
Signed-off-by: hyunuktak <hyunuk.tak@samsung.com>
6 years agoAdd HAL TC code for wifi, wifi-direct and softap 75/172875/3
Jaehyun Kim [Fri, 16 Mar 2018 11:26:12 +0000 (20:26 +0900)]
Add HAL TC code for wifi, wifi-direct and softap

Change-Id: I26973926e41a28ab4a803f21379546437d1dd2c9
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
6 years agoMerge "Modify the netlink scan results." into tizen accepted/tizen/unified/20180322.145028 submit/tizen/20180322.015431
taesub kim [Thu, 22 Mar 2018 01:36:26 +0000 (01:36 +0000)]
Merge "Modify the netlink scan results." into tizen

6 years agoMerge "Fix parsing of the AP name if the character is korean language." into tizen
taesub kim [Thu, 22 Mar 2018 01:36:11 +0000 (01:36 +0000)]
Merge "Fix parsing of the AP name if the character is korean language." into tizen

6 years agoMerge "Parse the security and encryption mode in the netlink scan results." into...
taesub kim [Thu, 22 Mar 2018 01:35:54 +0000 (01:35 +0000)]
Merge "Parse the security and encryption mode in the netlink scan results." into tizen

6 years agoAdd login support for captive/wispr portal 02/171302/7 accepted/tizen/unified/20180320.141401 submit/tizen/20180320.043504
Milind Murhekar [Wed, 28 Feb 2018 11:41:26 +0000 (17:11 +0530)]
Add login support for captive/wispr portal

Description: This patch sets the captive/wispr portal
login credentials via connman-agent.

Change-Id: I518099ba6b86c6d0d3c2e539a10d44fd1b071d09
Signed-off-by: Milind Murhekar <m.murhekar@samsung.com>
6 years agoModify the netlink scan results. 18/172918/1
Niraj Kumar Goit [Sat, 17 Mar 2018 10:25:03 +0000 (15:55 +0530)]
Modify the netlink scan results.

Remove the duplicate SSIDs (same security type) and the EAP security type in
netlink scan results.

Change-Id: Ib6d359b652c144480f7abc4d812f8a3658425e85
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
6 years agoFix parsing of the AP name if the character is korean language. 69/172869/1
Niraj Kumar Goit [Fri, 16 Mar 2018 10:26:51 +0000 (15:56 +0530)]
Fix parsing of the AP name if the character is korean language.

Change-Id: I67e365cb7a500ba7919611d8e48ba27d9add2549
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
6 years agoParse the security and encryption mode in the netlink scan results. 68/172868/1
Niraj Kumar Goit [Fri, 16 Mar 2018 09:55:41 +0000 (15:25 +0530)]
Parse the security and encryption mode in the netlink scan results.

Change-Id: I3f16f5a09f6e1e05fbdf8ac024e66cd27fde5f45
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
6 years agoFixed some coverity 68/172768/1 submit/tizen/20180318.231541 submit/tizen/20180318.231610
hyunuktak [Fri, 16 Mar 2018 01:07:04 +0000 (10:07 +0900)]
Fixed some coverity

Resource leak
Uninitialized scalar variable
Memset fill value of '0'
Buffer not null terminated
Various

Change-Id: I265d50163bb56ada269cf7206b9d0bad333b57f6
Signed-off-by: hyunuktak <hyunuk.tak@samsung.com>
6 years agoMerge "Fix dbus method return value" into tizen
taesub kim [Wed, 14 Mar 2018 23:56:23 +0000 (23:56 +0000)]
Merge "Fix dbus method return value" into tizen

6 years agoFix dbus method return value 22/172422/3
taesub kim [Wed, 14 Mar 2018 02:12:28 +0000 (11:12 +0900)]
Fix dbus method return value

Change-Id: I43ca38d158f648ebbd02398eee414d9fa13754e5
Signed-off-by: Taesub Kim <taesub.kim@samsung.com>