From 4f09782f628087f50e8ea8febf348c98e188735e Mon Sep 17 00:00:00 2001 From: "b.mandala" Date: Wed, 26 Jul 2017 15:19:26 +0530 Subject: [PATCH] Memory leak error Change-Id: I5bc54d38aa34af5b64768a8e828695ad061cd222 Signed-off-by: b.mandala --- src/pkgmgr-server.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/pkgmgr-server.c b/src/pkgmgr-server.c index 89338ea..480b341 100644 --- a/src/pkgmgr-server.c +++ b/src/pkgmgr-server.c @@ -841,9 +841,13 @@ static int __process_install(struct backend_job *job) return -1; req_id = g_shell_quote(job->req_id); + if (!req_id) + return -1; pkgid = g_shell_quote(job->pkgid); - if (!req_id || !pkgid) + if (!pkgid) { + g_free(req_id); return -1; + } snprintf(args, sizeof(args), "%s -k %s -i %s -u %d %s", backend_cmd, req_id, pkgid, (int)job->target_uid, job->args); @@ -872,10 +876,13 @@ static int __process_mount_install(struct backend_job *job) return -1; req_id = g_shell_quote(job->req_id); + if (!req_id) + return -1; pkgid = g_shell_quote(job->pkgid); - if (!req_id || !pkgid) + if (!pkgid) { + g_free(req_id); return -1; - + } snprintf(args, sizeof(args), "%s -k %s -w %s -u %d %s", backend_cmd, req_id, pkgid, (int)job->target_uid, job->args); @@ -903,9 +910,13 @@ static int __process_reinstall(struct backend_job *job) return -1; req_id = g_shell_quote(job->req_id); + if (!req_id) + return -1; pkgid = g_shell_quote(job->pkgid); - if (!req_id || !pkgid) + if (!pkgid) { + g_free(req_id); return -1; + } snprintf(args, sizeof(args), "%s -k %s -r %s -u %d", backend_cmd, req_id, pkgid, (int)job->target_uid); -- 2.7.4