From 44cc3ae46572ea04a6b7fcc0f1a4b8a4fd0fec9b Mon Sep 17 00:00:00 2001 From: Sangyoon Jang Date: Thu, 16 Mar 2017 16:22:07 +0900 Subject: [PATCH] Adjust some log levels Use ERR level in error case. Use INFO level at handling signal. Change-Id: Ie19197df1a485aeaebe0100dc87dc6ad59da70b4 Signed-off-by: Sangyoon Jang --- src/pkgmgr-server.c | 18 +++++++++--------- src/request.c | 2 +- src/signal.c | 4 ++-- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/pkgmgr-server.c b/src/pkgmgr-server.c index 38334d9..a8be0f2 100644 --- a/src/pkgmgr-server.c +++ b/src/pkgmgr-server.c @@ -203,12 +203,12 @@ static gboolean __signal_handler(GIOChannel *io, GIOCondition cond, __set_backend_free(job->backend_slot); if (WIFSIGNALED(status)) { _send_fail_signal(job); - DBG("backend[%s][%d] exit with signal[%d]", job->backend_type, + INFO("backend[%s][%d] exit with signal[%d]", job->backend_type, pid, WTERMSIG(status)); } else if (WEXITSTATUS(status)) { - DBG("backend[%s][%d] exit with error", job->backend_type, pid); + INFO("backend[%s][%d] exit with error", job->backend_type, pid); } else { - DBG("backend[%s][%d] exit", job->backend_type, pid); + INFO("backend[%s][%d] exit", job->backend_type, pid); } if (job->extra) { @@ -570,8 +570,8 @@ static char **__generate_argv(const char *args) ret_parse = g_shell_parse_argv(args, &argcp, &argvp, &gerr); if (FALSE == ret_parse) { - DBG("Failed to split args: %s", args); - DBG("messsage: %s", gerr->message); + ERR("Failed to split args: %s", args); + ERR("messsage: %s", gerr->message); exit(1); } @@ -587,7 +587,7 @@ void __set_environment(gpointer user_data) user_ctx *ctx = (user_ctx *)user_data; if (set_environement(ctx)) - DBG("Failed to set env for the user : %d", ctx->uid); + ERR("Failed to set env for the user : %d", ctx->uid); } static int __fork_and_exec_with_args(char **argv, uid_t uid) @@ -599,7 +599,7 @@ static int __fork_and_exec_with_args(char **argv, uid_t uid) user_context = get_user_context(uid); if (!user_context) { - DBG("Failed to getenv"); + ERR("Failed to getenv"); return -1; } @@ -1677,13 +1677,13 @@ int main(int argc, char *argv[]) r = _init_backend_queue(); if (r) { - DBG("Queue Initialization Failed"); + ERR("Queue Initialization Failed"); return -1; } r = __init_backend_info(); if (r) { - DBG("backend info init failed"); + ERR("backend info init failed"); return -1; } diff --git a/src/request.c b/src/request.c index 1718376..eb67593 100644 --- a/src/request.c +++ b/src/request.c @@ -214,7 +214,7 @@ static char *__generate_reqkey(const char *pkgid) size = strlen(pkgid) + strlen(timestr) + 2; str_req_key = (char *)calloc(size, sizeof(char)); if (str_req_key == NULL) { - DBG("calloc failed"); + ERR("calloc failed"); return NULL; } snprintf(str_req_key, size, "%s_%s", pkgid, timestr); diff --git a/src/signal.c b/src/signal.c index c1efa8c..40b5d40 100644 --- a/src/signal.c +++ b/src/signal.c @@ -67,7 +67,7 @@ void _send_app_signal(uid_t uid, const char *req_id, pi = pkgmgr_installer_new(); if (!pi) { - DBG("Failure in creating the pkgmgr_installer object"); + ERR("Failure in creating the pkgmgr_installer object"); return; } @@ -98,7 +98,7 @@ void _send_app_signal(uid_t uid, const char *req_id, goto catch; break; default: - DBG("Unsupported req_type[%d]", req_type); + ERR("Unsupported req_type[%d]", req_type); goto catch; } -- 2.7.4