From 0b13b9bc2b0576b26c8fa70f26c27e109d5b4656 Mon Sep 17 00:00:00 2001 From: Sangyoon Jang Date: Mon, 22 May 2017 10:32:44 +0900 Subject: [PATCH] Fix to check invalid parameter properly Change-Id: I8343876c9c10487b980ec15a68767e10f8a9e87a Signed-off-by: Sangyoon Jang --- src/pkgmgrinfo_archiveinfo.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/pkgmgrinfo_archiveinfo.c b/src/pkgmgrinfo_archiveinfo.c index b61a24a..33c5cd3 100644 --- a/src/pkgmgrinfo_archiveinfo.c +++ b/src/pkgmgrinfo_archiveinfo.c @@ -91,7 +91,7 @@ API int pkgmgrinfo_archiveinfo_get_pkgid(pkgmgrinfo_archiveinfo_h handle, package_manager_pkg_detail_info_t *info = (package_manager_pkg_detail_info_t *)handle; - if (info == NULL || strlen(info->pkgid) == 0) { + if (info == NULL || strlen(info->pkgid) == 0 || pkgid == NULL) { _LOGE("invalid parameter"); return PMINFO_R_EINVAL; } @@ -107,7 +107,7 @@ API int pkgmgrinfo_archiveinfo_get_type(pkgmgrinfo_archiveinfo_h handle, package_manager_pkg_detail_info_t *info = (package_manager_pkg_detail_info_t *)handle; - if (info == NULL || strlen(info->pkg_type) == 0) { + if (info == NULL || strlen(info->pkg_type) == 0 || type == NULL ) { _LOGE("invalid parameter"); return PMINFO_R_EINVAL; } @@ -123,7 +123,7 @@ API int pkgmgrinfo_archiveinfo_get_version(pkgmgrinfo_archiveinfo_h handle, package_manager_pkg_detail_info_t *info = (package_manager_pkg_detail_info_t *)handle; - if (info == NULL || strlen(info->version) == 0) { + if (info == NULL || strlen(info->version) == 0 || version == NULL) { _LOGE("invalid parameter"); return PMINFO_R_EINVAL; } @@ -139,7 +139,8 @@ API int pkgmgrinfo_archiveinfo_get_api_version(pkgmgrinfo_archiveinfo_h handle, package_manager_pkg_detail_info_t *info = (package_manager_pkg_detail_info_t *)handle; - if (info == NULL || strlen(info->api_version) == 0) { + if (info == NULL || strlen(info->api_version) == 0 || + api_version == NULL) { _LOGE("invalid parameter"); return PMINFO_R_EINVAL; } @@ -155,7 +156,7 @@ API int pkgmgrinfo_archiveinfo_get_description(pkgmgrinfo_archiveinfo_h handle, package_manager_pkg_detail_info_t *info = (package_manager_pkg_detail_info_t *)handle; - if (info == NULL) { + if (info == NULL || description == NULL) { _LOGE("invalid parameter"); return PMINFO_R_EINVAL; } @@ -174,7 +175,7 @@ API int pkgmgrinfo_archiveinfo_get_label(pkgmgrinfo_archiveinfo_h handle, package_manager_pkg_detail_info_t *info = (package_manager_pkg_detail_info_t *)handle; - if (info == NULL) { + if (info == NULL || label == NULL) { _LOGE("invalid parameter"); return PMINFO_R_EINVAL; } @@ -193,7 +194,7 @@ API int pkgmgrinfo_archiveinfo_get_author(pkgmgrinfo_archiveinfo_h handle, package_manager_pkg_detail_info_t *info = (package_manager_pkg_detail_info_t *)handle; - if (info == NULL) { + if (info == NULL || author == NULL) { _LOGE("invalid parameter"); return PMINFO_R_EINVAL; } @@ -212,7 +213,7 @@ API int pkgmgrinfo_archiveinfo_get_icon(pkgmgrinfo_archiveinfo_h handle, package_manager_pkg_detail_info_t *info = (package_manager_pkg_detail_info_t *)handle; - if (info == NULL) { + if (info == NULL || icon == NULL || size == NULL) { _LOGE("invalid parameter"); return PMINFO_R_EINVAL; } -- 2.7.4