From: Ilho Kim <ilho159.kim@samsung.com>
Date: Wed, 28 Feb 2024 06:40:01 +0000 (+0900)
Subject: Fix pkgmgrinfo_plugininfo_foreach_plugininfo
X-Git-Tag: accepted/tizen/unified/20240308.174011~2
X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fappfw%2Fpkgmgr-info.git;a=commitdiff_plain;h=c160cf60ed763b84c93c2fdf411a22b58224f874

Fix pkgmgrinfo_plugininfo_foreach_plugininfo

The absence of data is not treated as an error

Change-Id: Id2b8c4ff81bb961d8fdb020ddce44060ba180e50
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
(cherry picked from commit 770125b88497bc94eabd75f4152b3a79d83b2bfa)
---

diff --git a/src/manager/pkginfo_manager.cc b/src/manager/pkginfo_manager.cc
index ad4d141..bb9463b 100644
--- a/src/manager/pkginfo_manager.cc
+++ b/src/manager/pkginfo_manager.cc
@@ -498,15 +498,15 @@ extern "C" EXPORT_API int _plugininfo_get_appids(
   std::shared_ptr<pcp::ResultParcelable> return_parcel(
       std::static_pointer_cast<pcp::ResultParcelable>(ptr));
 
+  auto& result_list = return_parcel->GetResult();
+  if (result_list.size() == 0)
+    return PMINFO_R_ENOENT;
+
   if (return_parcel->GetCol() != 1) {
     LOG(ERROR) << "Invalid result";
     return PMINFO_R_ERROR;
   }
 
-  auto& result_list = return_parcel->GetResult();
-  if (result_list.size() == 0)
-    return PMINFO_R_ENOENT;
-
   for (auto& result : result_list) {
     if (result.size() != 1) {
       LOG(ERROR) << "Invalid result";
diff --git a/src/pkgmgrinfo_plugininfo.c b/src/pkgmgrinfo_plugininfo.c
index e63ee01..8db18e4 100644
--- a/src/pkgmgrinfo_plugininfo.c
+++ b/src/pkgmgrinfo_plugininfo.c
@@ -46,7 +46,7 @@ API int pkgmgrinfo_plugininfo_foreach_plugininfo(const char *pkgid,
 
 	ret = _plugininfo_get_appids(pkgid, plugin_type, plugin_name,
 			&appid_list);
-	if (ret != PMINFO_R_OK) {
+	if (ret == PMINFO_R_ERROR) {
 		_LOGE("Fail to get plugininfo");
 		return ret;
 	}
@@ -64,6 +64,5 @@ API int pkgmgrinfo_plugininfo_foreach_plugininfo(const char *pkgid,
 
 	g_list_free_full(appid_list, free);
 
-	return ret;
-
+	return PMINFO_R_OK;
 }