Fix static analysis issue

[platform/core/appfw/pkgmgr-info.git] / src / pkgmgrinfo_certinfo.c

diff --git a/src/pkgmgrinfo_certinfo.c b/src/pkgmgrinfo_certinfo.c
index 0bcf967..3b346bc 100644 (file)
--- a/src/pkgmgrinfo_certinfo.c
+++ b/src/pkgmgrinfo_certinfo.c
@@ -8,8 +8,6 @@
 #include <sqlite3.h>
 #include <glib.h>
 
-#include <db-util.h>
-
 #include "pkgmgr-info.h"
 #include "pkgmgrinfo_debug.h"
 #include "pkgmgrinfo_private.h"
@@ -116,7 +114,7 @@ API int pkgmgrinfo_pkginfo_compare_usr_pkg_cert_info(const char *lhs_package_id,
 {
        int ret;
        sqlite3 *db;
-       const char *dbpath;
+       char *dbpath;
 
        if (lhs_package_id == NULL || rhs_package_id == NULL ||
                        compare_result == NULL) {
@@ -125,15 +123,17 @@ API int pkgmgrinfo_pkginfo_compare_usr_pkg_cert_info(const char *lhs_package_id,
        }
 
        /* open unified global cert db */
-       dbpath = getUserPkgCertDBPathUID(GLOBAL_USER);
+       dbpath = getUserPkgCertDBPath();
        if (dbpath == NULL)
                return PMINFO_R_ERROR;
 
-       ret = sqlite3_open_v2(dbpath, &db, SQLITE_OPEN_READONLY, NULL);
+       ret = __open_db(dbpath, &db, SQLITE_OPEN_READONLY);
        if (ret != SQLITE_OK) {
                _LOGE("failed to open db: %d", ret);
+               free(dbpath);
                return PMINFO_R_ERROR;
        }
+       free(dbpath);
 
        if (_pkginfo_compare_certinfo(db, lhs_package_id, rhs_package_id,
                                compare_result)) {
@@ -159,18 +159,20 @@ static int _pkginfo_get_pkgid_from_appid(uid_t uid, const char *appid,
                "SELECT package FROM package_app_info WHERE app_id=?";
        int ret;
        sqlite3 *db;
-       const char *dbpath;
+       char *dbpath;
        sqlite3_stmt *stmt;
 
        dbpath = getUserPkgParserDBPathUID(uid);
        if (dbpath == NULL)
                return PMINFO_R_ERROR;
 
-       ret = sqlite3_open_v2(dbpath, &db, SQLITE_OPEN_READONLY, NULL);
+       ret = __open_db(dbpath, &db, SQLITE_OPEN_READONLY);
        if (ret != SQLITE_OK) {
                _LOGE("failed to open db: %d", ret);
+               free(dbpath);
                return PMINFO_R_ERROR;
        }
+       free(dbpath);
 
        ret = sqlite3_prepare_v2(db, query, strlen(query), &stmt, NULL);
        if (ret != SQLITE_OK) {
@@ -356,18 +358,20 @@ static int _pkginfo_get_certinfo(const char *pkgid, pkgmgr_certinfo_x *info)
 {
        int ret;
        sqlite3 *db;
-       const char *dbpath;
+       char *dbpath;
 
        /* open unified global cert db */
-       dbpath = getUserPkgCertDBPathUID(GLOBAL_USER);
+       dbpath = getUserPkgCertDBPath();
        if (dbpath == NULL)
                return PMINFO_R_ERROR;
 
-       ret = sqlite3_open_v2(dbpath, &db, SQLITE_OPEN_READONLY, NULL);
+       ret = __open_db(dbpath, &db, SQLITE_OPEN_READONLY);
        if (ret != SQLITE_OK) {
                _LOGE("failed to open db: %d", ret);
+               free(dbpath);
                return PMINFO_R_ERROR;
        }
+       free(dbpath);
 
        ret = _pkginfo_get_certid(db, pkgid, info->cert_id);
        if (ret != PMINFO_R_OK) {
@@ -381,6 +385,8 @@ static int _pkginfo_get_certinfo(const char *pkgid, pkgmgr_certinfo_x *info)
                return ret;
        }
 
+       sqlite3_close_v2(db);
+
        return PMINFO_R_OK;
 }
 
@@ -456,6 +462,8 @@ API int pkgmgrinfo_set_cert_value(pkgmgrinfo_instcertinfo_h handle, pkgmgrinfo_i
        retvm_if(cert_type > PMINFO_SET_DISTRIBUTOR2_SIGNER_CERT, PMINFO_R_EINVAL, "Invalid certificate type\n");
        pkgmgr_instcertinfo_x *certinfo = NULL;
        certinfo = (pkgmgr_instcertinfo_x *)handle;
+       if (certinfo->cert_info[cert_type])
+               free(certinfo->cert_info[cert_type]);
        (certinfo->cert_info)[cert_type] = strdup(cert_value);
        return PMINFO_R_OK;
 }
@@ -504,7 +512,13 @@ static int _pkginfo_save_cert_info(sqlite3 *db, const char *pkgid,
        }
 
        idx = 1;
-       sqlite3_bind_text(stmt, idx++, pkgid, -1, SQLITE_STATIC);
+       ret = sqlite3_bind_text(stmt, idx++, pkgid, -1, SQLITE_STATIC);
+       if (ret != SQLITE_OK) {
+               _LOGE("bind failed: %s", sqlite3_errmsg(db));
+               sqlite3_finalize(stmt);
+               return PMINFO_R_ERROR;
+       }
+
        for (i = 0; i < MAX_CERT_TYPE; i++) {
                if (sqlite3_bind_text(stmt, idx++, cert_info[i], -1,
                                SQLITE_STATIC)) {
@@ -523,7 +537,13 @@ static int _pkginfo_save_cert_info(sqlite3 *db, const char *pkgid,
                        _LOGE("prepare error: %s", sqlite3_errmsg(db));
                        return PMINFO_R_ERROR;
                }
-               sqlite3_bind_text(stmt, 1, pkgid, -1, SQLITE_STATIC);
+
+               if (sqlite3_bind_text(stmt, 1, pkgid, -1, SQLITE_STATIC)) {
+                       _LOGE("bind error: %s", sqlite3_errmsg(db));
+                       sqlite3_finalize(stmt);
+                       return PMINFO_R_ERROR;
+               }
+
                ret = sqlite3_step(stmt);
                sqlite3_finalize(stmt);
        }
@@ -563,9 +583,24 @@ static int _pkginfo_save_cert_index_info(sqlite3 *db, char *cert_info[])
                if (cert_info[i] == NULL)
                        continue;
                idx = 1;
-               sqlite3_bind_text(stmt, idx++, cert_info[i], -1, SQLITE_STATIC);
-               sqlite3_bind_text(stmt, idx++, cert_info[i], -1, SQLITE_STATIC);
-               sqlite3_bind_text(stmt, idx++, cert_info[i], -1, SQLITE_STATIC);
+               ret = sqlite3_bind_text(stmt, idx++, cert_info[i], -1, SQLITE_STATIC);
+               if (ret != SQLITE_OK) {
+                       _LOGE("bind failed: %s", sqlite3_errmsg(db));
+                       sqlite3_finalize(stmt);
+                       return PMINFO_R_ERROR;
+               }
+               ret = sqlite3_bind_text(stmt, idx++, cert_info[i], -1, SQLITE_STATIC);
+               if (ret != SQLITE_OK) {
+                       _LOGE("bind failed: %s", sqlite3_errmsg(db));
+                       sqlite3_finalize(stmt);
+                       return PMINFO_R_ERROR;
+               }
+               ret = sqlite3_bind_text(stmt, idx++, cert_info[i], -1, SQLITE_STATIC);
+               if (ret != SQLITE_OK) {
+                       _LOGE("bind failed: %s", sqlite3_errmsg(db));
+                       sqlite3_finalize(stmt);
+                       return PMINFO_R_ERROR;
+               }
 
                ret = sqlite3_step(stmt);
                if (ret != SQLITE_DONE) {
@@ -587,7 +622,7 @@ API int pkgmgrinfo_save_certinfo(const char *pkgid, pkgmgrinfo_instcertinfo_h ha
 {
        int ret;
        sqlite3 *db;
-       const char *dbpath;
+       char *dbpath;
        pkgmgr_instcertinfo_x *info = (pkgmgr_instcertinfo_x *)handle;
 
        if (pkgid == NULL || handle == NULL) {
@@ -595,36 +630,42 @@ API int pkgmgrinfo_save_certinfo(const char *pkgid, pkgmgrinfo_instcertinfo_h ha
                return PMINFO_R_EINVAL;
        }
 
+       _check_create_cert_db();
+
        /* open unified global cert db */
-       dbpath = getUserPkgCertDBPathUID(GLOBAL_USER);
+       dbpath = getUserPkgCertDBPath();
        if (dbpath == NULL)
                return PMINFO_R_ERROR;
 
-       ret = sqlite3_open_v2(dbpath, &db, SQLITE_OPEN_READWRITE, NULL);
+       ret = __open_db(dbpath, &db, SQLITE_OPEN_READWRITE);
        if (ret != SQLITE_OK) {
                _LOGE("failed to open db: %d", ret);
+               free(dbpath);
                return PMINFO_R_ERROR;
        }
+       free(dbpath);
 
-       ret = sqlite3_exec(db, "BEGIN EXCLUSIVE", NULL, NULL, NULL);
+       ret = sqlite3_exec(db, "BEGIN DEFERRED", NULL, NULL, NULL);
        if (ret != SQLITE_OK) {
                _LOGE("failed to begin transaction");
                sqlite3_close_v2(db);
                return PMINFO_R_ERROR;
        }
 
-       _check_create_cert_db(db);
-
        if (_pkginfo_save_cert_index_info(db, info->cert_info)) {
                _LOGE("failed to save cert index info, rollback now");
-               sqlite3_exec(GET_DB(cert_db), "ROLLBACK", NULL, NULL, NULL);
+               ret = sqlite3_exec(db, "ROLLBACK", NULL, NULL, NULL);
+               if (ret != SQLITE_OK)
+                       LOGE("Rollback is failed. error(%s)", sqlite3_errmsg(db));
                sqlite3_close_v2(db);
                return PMINFO_R_ERROR;
        }
 
        if (_pkginfo_save_cert_info(db, pkgid, info->cert_info)) {
                _LOGE("failed to save cert info, rollback now");
-               sqlite3_exec(GET_DB(cert_db), "ROLLBACK", NULL, NULL, NULL);
+               ret = sqlite3_exec(db, "ROLLBACK", NULL, NULL, NULL);
+               if (ret != SQLITE_OK)
+                       LOGE("Rollback is failed. error(%s)", sqlite3_errmsg(db));
                sqlite3_close_v2(db);
                return PMINFO_R_ERROR;
        }
@@ -632,7 +673,9 @@ API int pkgmgrinfo_save_certinfo(const char *pkgid, pkgmgrinfo_instcertinfo_h ha
        ret = sqlite3_exec(db, "COMMIT", NULL, NULL, NULL);
        if (ret != SQLITE_OK) {
                _LOGE("failed to commit transaction, rollback now");
-               sqlite3_exec(GET_DB(cert_db), "ROLLBACK", NULL, NULL, NULL);
+               ret = sqlite3_exec(db, "ROLLBACK", NULL, NULL, NULL);
+               if (ret != SQLITE_OK)
+                       LOGE("Rollback is failed. error(%s)", sqlite3_errmsg(db));
                sqlite3_close_v2(db);
                return PMINFO_R_ERROR;
        }
@@ -699,7 +742,7 @@ API int pkgmgrinfo_delete_usr_certinfo(const char *pkgid, uid_t uid)
 {
        int ret;
        sqlite3 *db;
-       const char *dbpath;
+       char *dbpath;
 
        if (pkgid == NULL) {
                _LOGE("invalid parameter");
@@ -707,17 +750,19 @@ API int pkgmgrinfo_delete_usr_certinfo(const char *pkgid, uid_t uid)
        }
 
        /* open unified global cert db */
-       dbpath = getUserPkgCertDBPathUID(GLOBAL_USER);
+       dbpath = getUserPkgCertDBPath();
        if (dbpath == NULL)
                return PMINFO_R_ERROR;
 
-       ret = sqlite3_open_v2(dbpath, &db, SQLITE_OPEN_READWRITE, NULL);
+       ret = __open_db(dbpath, &db, SQLITE_OPEN_READWRITE);
        if (ret != SQLITE_OK) {
                _LOGE("failed to open db: %d", ret);
+               free(dbpath);
                return PMINFO_R_ERROR;
        }
+       free(dbpath);
 
-       ret = sqlite3_exec(db, "BEGIN EXCLUSIVE", NULL, NULL, NULL);
+       ret = sqlite3_exec(db, "BEGIN DEFERRED", NULL, NULL, NULL);
        if (ret != SQLITE_OK) {
                _LOGE("failed to begin transaction");
                sqlite3_close_v2(db);
@@ -726,7 +771,9 @@ API int pkgmgrinfo_delete_usr_certinfo(const char *pkgid, uid_t uid)
 
        if (_pkginfo_delete_certinfo(db, pkgid)) {
                _LOGE("failed to delete certinfo of %s, rollback now", pkgid);
-               sqlite3_exec(GET_DB(cert_db), "ROLLBACK", NULL, NULL, NULL);
+               ret = sqlite3_exec(db, "ROLLBACK", NULL, NULL, NULL);
+               if (ret != SQLITE_OK)
+                       LOGE("Rollback is failed. error(%s)", sqlite3_errmsg(db));
                sqlite3_close_v2(db);
                return PMINFO_R_ERROR;
        }
@@ -734,7 +781,9 @@ API int pkgmgrinfo_delete_usr_certinfo(const char *pkgid, uid_t uid)
        ret = sqlite3_exec(db, "COMMIT", NULL, NULL, NULL);
        if (ret != SQLITE_OK) {
                _LOGE("failed to commit transaction, rollback now");
-               sqlite3_exec(GET_DB(cert_db), "ROLLBACK", NULL, NULL, NULL);
+               ret = sqlite3_exec(db, "ROLLBACK", NULL, NULL, NULL);
+               if (ret != SQLITE_OK)
+                       LOGE("Rollback is failed. error(%s)", sqlite3_errmsg(db));
                sqlite3_close_v2(db);
                return PMINFO_R_ERROR;
        }