From: Sangyoon Jang <jeremy.jang@samsung.com>
Date: Fri, 15 Sep 2023 01:00:37 +0000 (+0900)
Subject: Fix static analysis issue
X-Git-Tag: accepted/tizen/8.0/unified/20231005.092959~1
X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fappfw%2Fapp-installers.git;a=commitdiff_plain;h=ff305331e68bf664841a2a92b27b4a3076e882f3

Fix static analysis issue

Change-Id: I5a4ee134eed1a76925d51cb429be8628daa2c370
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
---

diff --git a/src/common/pkgmgr_signal.cc b/src/common/pkgmgr_signal.cc
index acb2a92..78d41aa 100644
--- a/src/common/pkgmgr_signal.cc
+++ b/src/common/pkgmgr_signal.cc
@@ -81,7 +81,7 @@ bool PkgmgrSignal::SendStarted(
   if (!SendSignal(PKGMGR_INSTALLER_START_KEY_STR, key->second, type, pkgid))
     return false;
 
-  for (auto l : user_list_) {
+  for (const auto& l : user_list_) {
     key = kEventStr.find(l.second);
     if (key == kEventStr.end())
       continue;
@@ -132,7 +132,7 @@ bool PkgmgrSignal::SendFinished(
         std::to_string(static_cast<int>(result)).c_str(), type, pkgid))
       return false;
 
-    for (auto l : user_list_)
+    for (const auto& l : user_list_)
       SendSignal(l.first,
           PKGMGR_INSTALLER_ERROR_KEY_STR,
           std::to_string(static_cast<int>(result)).c_str(), type, pkgid);