Fix Svace issues

[platform/core/api/video-util.git] / src / video_util.c

diff --git a/src/video_util.c b/src/video_util.c
index 4828c13..425979f 100755 (executable)
--- a/src/video_util.c
+++ b/src/video_util.c
@@ -141,7 +141,7 @@ int __video_util_check_transcode_is_busy(video_util_s *handle, bool *is_busy)
 
 static bool __video_util_check_video_codec(video_util_video_codec_e video_codec)
 {
-       if ((video_codec < 0) || (video_codec > VIDEO_UTIL_VIDEO_CODEC_NONE)) {
+       if (video_codec > VIDEO_UTIL_VIDEO_CODEC_NONE) {
                video_util_error("invalid video_codec [%d]", video_codec);
                return false;
        }
@@ -151,7 +151,7 @@ static bool __video_util_check_video_codec(video_util_video_codec_e video_codec)
 
 static bool __video_util_check_audio_codec(video_util_audio_codec_e audio_codec)
 {
-       if ((audio_codec < 0) || (audio_codec > VIDEO_UTIL_AUDIO_CODEC_NONE)) {
+       if (audio_codec > VIDEO_UTIL_AUDIO_CODEC_NONE) {
                video_util_error("invalid audio_codec [%d]", audio_codec);
                return false;
        }
@@ -161,7 +161,7 @@ static bool __video_util_check_audio_codec(video_util_audio_codec_e audio_codec)
 
 static bool __video_util_check_file_format(video_util_file_format_e file_format)
 {
-       if ((file_format < 0) || (file_format >= VIDEO_UTIL_FILE_FORMAT_MAX)) {
+       if (file_format >= VIDEO_UTIL_FILE_FORMAT_MAX) {
                video_util_error("invalid file_format [%d]", file_format);
                return false;
        }
@@ -269,6 +269,11 @@ static int __video_util_foreach_supported_type(video_util_type_e type, video_uti
        int ret = VIDEO_UTIL_ERROR_NONE;
 
        video_util_type_cb_s *codec_cb = (video_util_type_cb_s *)calloc(1, sizeof(video_util_type_cb_s));
+       if (!codec_cb) {
+               video_util_error("Fail to allocate internal callback");
+               return VIDEO_UTIL_ERROR_OUT_OF_MEMORY;
+       }
+
        codec_cb->user_data = user_data;
        codec_cb->supported_type_cb = (video_util_supported_type_cb)callback;