From: Sangyoon Jang <jeremy.jang@samsung.com>
Date: Thu, 14 Feb 2019 03:04:09 +0000 (+0900)
Subject: Make sure the mutex unlocked before calling g_mutex_clear()
X-Git-Tag: accepted/tizen/unified/20190322.075515~4
X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fapi%2Fpackage-manager.git;a=commitdiff_plain;h=51d4cea6586d574fced41e5b3274d44f0a0ebb44

Make sure the mutex unlocked before calling g_mutex_clear()

Calling g_mutex_clear() on a locked mutex leads to undefined behaviour.

Change-Id: I90c1de3afe0ab9f0119980c1c8f603cffc26963a
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
---

diff --git a/src/package_manager.c b/src/package_manager.c
index dec09cd..214ecda 100644
--- a/src/package_manager.c
+++ b/src/package_manager.c
@@ -1026,6 +1026,8 @@ API int package_manager_destroy(package_manager_h manager)
 		     NULL);
 	}
 
+	g_mutex_trylock(&manager->mutex);
+	g_mutex_unlock(&manager->mutex);
 	g_mutex_clear(&manager->mutex);
 	pkgmgr_client_free(manager->pc);
 	g_hash_table_destroy(manager->event_info_table);