platform/core/api/metadata-editor.git
20 months agoFix heap-use-after-free in __remove_ogg_picture() 99/279799/2 accepted/tizen_7.0_unified accepted/tizen_7.0_unified_hotfix accepted/tizen_8.0_unified tizen_7.0 tizen_7.0_hotfix tizen_8.0 accepted/tizen/7.0/unified/20221110.060036 accepted/tizen/7.0/unified/hotfix/20221116.104740 accepted/tizen/8.0/unified/20231005.092754 accepted/tizen/unified/20220818.230407 submit/tizen/20220818.080154 tizen_7.0_m2_release tizen_8.0_m2_release
minje.ahn [Thu, 18 Aug 2022 05:08:41 +0000 (14:08 +0900)]
Fix heap-use-after-free in __remove_ogg_picture()

Fixed 'setAutoDelete' to 'false' so that pictureList is not freed while looking for picture.

Change-Id: I68223bfd2c2ad59b4da033665e3e7cdd857d3fe1
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
20 months agoRollback removePicture in ogg 91/279791/1
minje.ahn [Thu, 18 Aug 2022 02:47:16 +0000 (11:47 +0900)]
Rollback removePicture in ogg

Change-Id: I29a04e6eca68b02bb038014199e41f500e826e1b
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
20 months agoFix heap-use-after-free bug 65/279665/2 accepted/tizen/unified/20220817.075309 submit/tizen/20220816.000452 submit/tizen/20220816.230510
minje.ahn [Mon, 15 Aug 2022 23:31:26 +0000 (08:31 +0900)]
Fix heap-use-after-free bug

Auto-delete is set for lists in taglib.
Therefore, there is no need to free the elements to be excluded.

Change-Id: Ibfe04068e7396dcdba9da01512627473ab52bac0
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
21 months agoAdd MP4 coverart list 24/277824/7 accepted/tizen/unified/20220718.140339 submit/tizen/20220718.050845
minje.ahn [Thu, 14 Jul 2022 00:41:01 +0000 (09:41 +0900)]
Add MP4 coverart list

Change-Id: If59d435e289728c47fd490a77e64f6082d001f7c
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
21 months agoAdditional refactoring 50/277650/13
Seungbae Shin [Mon, 11 Jul 2022 12:39:16 +0000 (21:39 +0900)]
Additional refactoring

- apply factory method pattern
- make const member function whenever possible
- use member-initializer instead of constructor-initialization
- remove some duplicated codes
- add some empty lines for enhancing the readability
- remove namespace which is already using

Change-Id: I5ee8d1e4216803011de158d69a7e2a9b88f51438

21 months agoMerge duplicate code 07/277707/2 accepted/tizen/unified/20220714.135249 submit/tizen/20220714.004316
minje.ahn [Tue, 12 Jul 2022 08:03:06 +0000 (17:03 +0900)]
Merge duplicate code

Change-Id: I8d641d1f20ee5dc6997bb25edeeb10f28e0fa7b7
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
21 months agoImprove test code 57/277657/4
minje.ahn [Tue, 12 Jul 2022 00:36:38 +0000 (09:36 +0900)]
Improve test code

1. Added check for return value.
2. Fixed CC, GV defects.

Change-Id: I60f566918a0ed334e496ebb7b81d192c9727251a
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
21 months agoPicture-related code refactoring 11/277511/5 submit/tizen/20220711.084601
minje.ahn [Fri, 8 Jul 2022 02:15:59 +0000 (11:15 +0900)]
Picture-related code refactoring

Change-Id: I7bbdbec206c1363f9a8df57ae166ecc52492b836
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
22 months agoImprove picture reading function 64/277164/5
minje.ahn [Fri, 1 Jul 2022 07:05:57 +0000 (16:05 +0900)]
Improve picture reading function

Change-Id: Icdeded4a32357f6f3146e9e56102697085c84a1f
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
22 months agoRemove aul dependency 98/277098/5
minje.ahn [Thu, 30 Jun 2022 23:05:22 +0000 (08:05 +0900)]
Remove aul dependency

Change-Id: Ib8932a79682ac546aa1fb9b9dd55bef7f75a348d
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
22 months agoRename log macro 52/277052/1
minje.ahn [Thu, 30 Jun 2022 04:03:03 +0000 (13:03 +0900)]
Rename log macro

Change-Id: Ibf4a2f130f8482386bad597191c07fe7eb3033d9
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
22 months agoFix function to get extension 81/276981/6
minje.ahn [Wed, 29 Jun 2022 01:07:14 +0000 (10:07 +0900)]
Fix function to get extension

Use Taglib::String instead of char.

Change-Id: I386d9612298465ad93b148dabf4bcd324c6f5052
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
22 months agoUse FileRef instead 53/276953/9
minje.ahn [Tue, 28 Jun 2022 08:41:53 +0000 (17:41 +0900)]
Use FileRef instead

FileRef helps to respond appropriately according to each format.

Change-Id: Id2af3ca82e99c40b0dd6853c32f41c526c872e97
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
23 months agospec: Change the installation path of gcov object 28/275528/1 accepted/tizen/unified/20220528.144435 submit/tizen/20220526.064806
backto.kim [Thu, 26 May 2022 04:54:20 +0000 (13:54 +0900)]
spec: Change the installation path of gcov object

Change-Id: I145ce06690b904fd918e64139121cd272bd502df

2 years agochange library path for 64-bit errors 54/272754/1 accepted/tizen/unified/20220324.134344 submit/tizen/20220324.010316
jiyong.min [Wed, 23 Mar 2022 23:53:56 +0000 (08:53 +0900)]
change library path for 64-bit errors

Change-Id: I768731190bc5ea2451d36680efe491bd7d8e5ca8

2 years agoChange gcov object install path 95/269995/1 accepted/tizen/unified/20220128.144514 submit/tizen/20220124.032604
Jiyong Min [Mon, 24 Jan 2022 04:24:46 +0000 (13:24 +0900)]
Change gcov object install path

Change-Id: I38cda647a4735e3bb89ef668c636000603ae1dd8

2 years agoFix build error caused by using deprecated APIs 01/267901/3 accepted/tizen/unified/20211227.122833 submit/tizen/20211223.232850
Minje Ahn [Mon, 13 Dec 2021 05:42:01 +0000 (14:42 +0900)]
Fix build error caused by using deprecated APIs

Fixed build errors due to taglib upgrade (1.11.1 to 1.12)

Change-Id: Ic753ffa1a3f712b67c89e45e100d3de4a1ff0632
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
2 years agoreplace g_memdup() to g_memdup2() 00/267900/2 accepted/tizen/unified/20211222.230810 submit/tizen/20211212.233427
Jiyong Min [Mon, 13 Dec 2021 05:38:47 +0000 (14:38 +0900)]
replace g_memdup() to g_memdup2()

  - g_memdup() was removed in glib2

Change-Id: I49168c0c3a95b0523af55733e6374613561cda69

2 years agoRefactoring using abstract class for metadata file interface 04/261804/7 accepted/tizen/6.5/unified/20211028.101504 accepted/tizen/unified/20210804.043636 submit/tizen/20210803.230150 submit/tizen_6.5/20211028.161801 tizen_6.5.m2_release
Seungbae Shin [Mon, 26 Jul 2021 16:37:33 +0000 (01:37 +0900)]
Refactoring using abstract class for metadata file interface

Change-Id: Iab450bd815bb3509d447b2f7bac35610cc66294f

3 years agoRemove links in document 16/243216/1 accepted/tizen_6.0_unified accepted/tizen_6.0_unified_hotfix tizen_6.0 tizen_6.0_hotfix accepted/tizen/6.0/unified/20201030.121608 accepted/tizen/6.0/unified/hotfix/20201103.004313 accepted/tizen/6.0/unified/hotfix/20201103.051351 accepted/tizen/unified/20200906.032659 submit/tizen/20200904.051854 submit/tizen_6.0/20201029.205102 submit/tizen_6.0_hotfix/20201102.192502 submit/tizen_6.0_hotfix/20201103.114802 tizen_6.0.m2_release
jiyong.min [Fri, 4 Sep 2020 03:45:29 +0000 (12:45 +0900)]
Remove links in document

Change-Id: I620442514071a4d6aea7aedeee2a633eda1da200

3 years agoFix memory leak for invalid picture path 47/242247/3 accepted/tizen/unified/20200829.113351 submit/tizen/20200827.012435
jiyong.min [Tue, 25 Aug 2020 07:23:51 +0000 (16:23 +0900)]
Fix memory leak for invalid picture path

Change-Id: I91cc461446c8a98ecc18959a31c8d2c39b7afd5b

3 years agoFix coverity issues 47/238147/2 accepted/tizen/unified/20200709.212817 submit/tizen/20200709.031615
hj kim [Thu, 9 Jul 2020 02:57:32 +0000 (11:57 +0900)]
Fix coverity issues

dynamic_cast can be NULL

Change-Id: I8b68b6b2c0000a1dc33deb5a8665695096904b8b

3 years agoUpdate API description regarding METADATA_EDITOR_ERROR_METADATA_UPDATE_NOT_POSSIBLE 42/237542/3
hj kim [Wed, 1 Jul 2020 07:12:39 +0000 (16:12 +0900)]
Update API description regarding METADATA_EDITOR_ERROR_METADATA_UPDATE_NOT_POSSIBLE

Change-Id: I680b073fb408c05dad44cb62a6d4165ee2118c9a

3 years agoMerge "Added safe_atoi to avoid unwanted loop because of tainted int 'num'" into...
Jiyong Min [Tue, 30 Jun 2020 03:12:58 +0000 (03:12 +0000)]
Merge "Added safe_atoi to avoid unwanted loop because of tainted int 'num'" into tizen

3 years agoAdded safe_atoi to avoid unwanted loop because of tainted int 'num' 14/237314/4
jiyong.min [Mon, 29 Jun 2020 05:35:04 +0000 (14:35 +0900)]
Added safe_atoi to avoid unwanted loop because of tainted int 'num'

Change-Id: I2fc79d9b9134cbee1cfdc7887f0effc3570b158a

3 years ago[ACR-1569]Update description on supporting WAV, FLAC, OGG since 6.0 75/236975/6 accepted/tizen/unified/20200630.131158 submit/tizen/20200630.005817
hj kim [Tue, 23 Jun 2020 23:47:17 +0000 (08:47 +0900)]
[ACR-1569]Update description on supporting WAV, FLAC, OGG since 6.0

Change-Id: I323a16714b7ff51f0cd14d5321b8226d2607a95c

3 years agoFix Crash issue when removing picture in OGG 25/236025/6
hj kim [Fri, 12 Jun 2020 05:23:01 +0000 (14:23 +0900)]
Fix Crash issue when removing picture in OGG

XiphComment has removePicture() and it is used for OGG formats such as vorbis ogg or flac ogg.
When try to remove picture on those files we can use this method.
but when remove it with reference from the Picture_list[index], like a FLAC file, crash occurred.
(actually crash not occurred in this method, but after removing, if we try to access (eg. by using save() or getting picture)
the picture list which has more than 1 picture, crash occurred)
I don't know the reason why.
So anyway, modified it to use iterator.

Change-Id: I0dae724860ca3efab42d5e981b7f3fc5adf1d954

3 years agoSupport metadata editing for Ogg format 82/234982/23
hj kim [Mon, 1 Jun 2020 09:10:38 +0000 (18:10 +0900)]
Support metadata editing for Ogg format

Change-Id: Iffee36e6fc978697047c815908f05229e462ec7c

3 years agoUnify duplicated ogg codes 18/235518/10
hj kim [Fri, 5 Jun 2020 07:21:05 +0000 (16:21 +0900)]
Unify duplicated ogg codes

Change-Id: I165ff104fd429f9359db51140b926b9be8c0f6c9

3 years agoSupport metadata editing for Flac format 94/234594/20
hj kim [Wed, 27 May 2020 08:40:21 +0000 (17:40 +0900)]
Support metadata editing for Flac format

Change-Id: I64e0010a95710fcfa28c34c8467ee94973b5696f

3 years agoSupport metadata editing for Wav format 08/234408/28
hj kim [Tue, 26 May 2020 07:05:01 +0000 (16:05 +0900)]
Support metadata editing for Wav format

Change-Id: I63654c0e4bb728e5fd8b3b247626094960130a14

3 years ago[ACR-1560]Add new error METADATA_EDITOR_ERROR_METADATA_UPDATE_NOT_POSSIBLE 50/235050/24 accepted/tizen/unified/20200624.130227 submit/tizen/20200623.070108
hj kim [Tue, 2 Jun 2020 02:49:01 +0000 (11:49 +0900)]
[ACR-1560]Add new error METADATA_EDITOR_ERROR_METADATA_UPDATE_NOT_POSSIBLE

Metadata updating doesn't support for malformed files.
Before 6.0, this function returned #METADATA_EDITOR_ERROR_OPERATION_FAILED.
Since 6.0, #METADATA_EDITOR_ERROR_METADATA_UPDATE_NOT_POSSIBLE is returned in such cases.

Change-Id: I5e39c35392cac4d0b7b12a294a1e29784865eabb

3 years agoVersion up (0.1.9 -> 0.1.10) 39/235639/9 accepted/tizen/unified/20200611.134754 submit/tizen/20200611.013522
hj kim [Mon, 8 Jun 2020 08:58:45 +0000 (17:58 +0900)]
Version up (0.1.9 -> 0.1.10)

Change-Id: I9dced8f264ddd3257dc5a7732f7035353b297670

3 years agoAdd debug logs 80/235680/3
hj kim [Tue, 9 Jun 2020 00:49:01 +0000 (09:49 +0900)]
Add debug logs

Change-Id: I45aa17d23566813005ae30fc0fbdbfd4d6d36584

3 years agoadd to typecasting 'File' because crash occur for TC 14/235814/4
jiyong.min [Wed, 10 Jun 2020 03:05:48 +0000 (12:05 +0900)]
add to typecasting 'File' because crash occur for TC

  - Using 'delete _metadata->file' make crash.

Change-Id: Id1d3a318ebdc270d0ae976acc0e6043748104384

3 years agoAdd __is_valid_picture_index() and Apply color for dlog 25/235625/8
hj kim [Mon, 8 Jun 2020 06:49:46 +0000 (15:49 +0900)]
Add __is_valid_picture_index() and Apply color for dlog

to get or remove picuture, functions should check picture index.
similar picture index checking codes were duplicated for each funtions, so unified them into __is_valid_picture_index().

Change-Id: I06debb6c390aa85ab8d39e34b363d8829bee20e7

3 years agoUpdate test code 65/235165/6
hj kim [Tue, 2 Jun 2020 08:30:23 +0000 (17:30 +0900)]
Update test code

Change-Id: I4bdd697f47887f3c7848e3ba4fdfdd17e25da1c4

3 years agoReinforce description for supported formats 51/235051/5
hj kim [Tue, 2 Jun 2020 02:55:50 +0000 (11:55 +0900)]
Reinforce description for supported formats

Change-Id: If38b51e7cdeac6222f5f5e3da1fb3338318f31ba

3 years agoVersion up 06/234406/12 accepted/tizen/unified/20200605.020426 submit/tizen/20200602.021203 submit/tizen/20200603.071553
hj kim [Tue, 26 May 2020 06:35:37 +0000 (15:35 +0900)]
Version up

Change-Id: I8c054dadf932acfaa4347d972f36bf85c55f2792

3 years agoFix Wrong return values 67/234967/3
hj kim [Mon, 1 Jun 2020 07:01:11 +0000 (16:01 +0900)]
Fix Wrong return values

1. return METADATA_EDITOR_ERROR_INVALID_PARAMETER
if there is no tag when get or remove picture. because it means, picture index is wrong.

2. return METADATA_EDITOR_ERROR_NONE
if there is no tag when get metadata.

Change-Id: I831005c8b1116c421d03b7618b6503192bff3af2

3 years agoCheck file validity before using it 65/234965/1
hj kim [Mon, 1 Jun 2020 06:36:28 +0000 (15:36 +0900)]
Check file validity before using it

Change-Id: Id39a29a9a7042af3bb2e23c3cd10edad4d022ff0

3 years agoCheck dynamic_cast result before using it 22/234822/3
hj kim [Fri, 29 May 2020 05:14:32 +0000 (14:14 +0900)]
Check dynamic_cast result before using it

Change-Id: I6b32ee6ce5e9202194dfe47add16a493ee442fa3

3 years agoUnify Getting and Setting metadata related code for MP3 and Wav 18/234418/6
hj kim [Tue, 26 May 2020 08:02:40 +0000 (17:02 +0900)]
Unify Getting and Setting metadata related code for MP3 and Wav

MP3 and Wav could have metadata in ID3tag. but Wav only can save metadata in ID3v2.

Change-Id: I4da4d7cec1a94222d2bcf11f3d688e8c4a32ff79

3 years agoUnify Code for getting ID3tag to __ID3_getTwixFrameByName() 20/234420/3
hj kim [Tue, 26 May 2020 08:22:51 +0000 (17:22 +0900)]
Unify Code for getting ID3tag to __ID3_getTwixFrameByName()

Change-Id: I3dde3b8339f68e74ae5e69ca204497b3e0d6ac88

3 years agoImprove __ID3_setTwixFrameByName() API 03/234303/9
hj kim [Mon, 25 May 2020 08:57:11 +0000 (17:57 +0900)]
Improve __ID3_setTwixFrameByName() API

Change-Id: Ib82b0d175e528718ec89e840f546937c1bd3a55a

3 years agoAdd macros for debugging and add debug logs 14/234414/5
hj kim [Tue, 26 May 2020 07:34:27 +0000 (16:34 +0900)]
Add macros for debugging and add debug logs

Change-Id: I5dcd0b80f26b57d4a297898a413be863daf8062f

3 years agoRevise the internal function name __ID3_setFrameByName() to __ID3v2_setFrameByName() 98/234298/6
hj kim [Mon, 25 May 2020 07:35:15 +0000 (16:35 +0900)]
Revise the internal function name __ID3_setFrameByName() to __ID3v2_setFrameByName()

because __ID3_setFrameByName() is used only for ID3v2 tag.

Change-Id: I4bf870b5cdd1d9713101d594f7ff126e2ce03878

3 years agoBug fix of getting number of picture in tag 96/234296/5
hj kim [Mon, 25 May 2020 07:16:35 +0000 (16:16 +0900)]
Bug fix of getting number of picture in tag

if there is no tag, number should be "0".

Change-Id: I6b048dac7ad51a1eba273de62593c0851fcbcf70

3 years agoModify input parameter 93/234293/5
hj kim [Mon, 25 May 2020 06:54:10 +0000 (15:54 +0900)]
Modify input parameter

Use proper MP4:Tag instead of metadata_editor structure when get and set metadata.

Change-Id: I2c255991ce19f65606580507c4aa188e9b119f22

3 years agoRemove unnecessary parameter 90/234290/5
hj kim [Mon, 25 May 2020 06:24:08 +0000 (15:24 +0900)]
Remove unnecessary parameter

Change-Id: Ie1d7fc71dbb4fee4b49e0c0b0e0ac0043aa00f1e

3 years agoBug fix of MP4 metadata when using auto keyword 90/233990/7
hj kim [Thu, 21 May 2020 04:01:32 +0000 (13:01 +0900)]
Bug fix of MP4 metadata when using auto keyword

Change-Id: I9aac227c38061475c2ed07e15c073682428239f4

3 years agocheck NULL before getting metadata 28/233928/9
hj kim [Wed, 20 May 2020 09:45:16 +0000 (18:45 +0900)]
check NULL before getting metadata

toString() returns "", when String is NULL

Change-Id: I8a8b1da78a4747725bdf6bc8a59e6b2277bd084e

3 years agoFix invalid return of metadata_editor_append_picture() and adds debug logs. 14/233914/7
hj kim [Wed, 20 May 2020 08:00:33 +0000 (17:00 +0900)]
Fix invalid return of metadata_editor_append_picture() and adds debug logs.

metadata_editor_set_path() can return METADATA_EDITOR_ERROR_NOT_SUPPORTED for not supported file,
but other APIs should return METADATA_EDITOR_ERROR_INVALID_PARAMETER

Change-Id: I13abc82156a0c0b98867ac9078563bc18198cbea

3 years agoUpdate API description 12/233912/4
hj kim [Wed, 20 May 2020 07:55:11 +0000 (16:55 +0900)]
Update API description

Change-Id: I2758c2d122fdc3c0f271c8bce1e1bd47ab5f6b22

3 years agoUse auto keyword 45/233345/3
jiyong.min [Thu, 14 May 2020 04:17:12 +0000 (13:17 +0900)]
Use auto keyword

Change-Id: Ieb7eb0f9e9fc80e5b37aae469a17d5822317450a

3 years agoImprove __metadata_editor_get_picture_info() and User proper type for picture 40/233240/4
hj kim [Wed, 13 May 2020 07:16:40 +0000 (16:16 +0900)]
Improve __metadata_editor_get_picture_info() and User proper type for picture

Change-Id: Id81a6f64b2361d7c97b5fe95f02271b5e16af115

3 years agoUse namespace TagLib 66/233166/12
jiyong.min [Tue, 12 May 2020 23:34:34 +0000 (08:34 +0900)]
Use namespace TagLib

Change-Id: I2bcd614a3aabe1c10766934658d10b0ea8936fa4

3 years agoApply tizen coding rule 41/233141/8
hj kim [Tue, 12 May 2020 11:16:09 +0000 (20:16 +0900)]
Apply tizen coding rule

Change-Id: Ib5238374d93a580bc9b7cd9cf4d8df5b3a1afc5c

3 years agoBug fix of String Convert 19/233219/2
hj kim [Wed, 13 May 2020 06:01:22 +0000 (15:01 +0900)]
Bug fix of String Convert

String::toCString(true) convert code to UTF8. and String::toCString(false) convert to Latin.
We need UTF8 so "true" should be set to toCString().

Change-Id: Iae6071f4288e90de2068e026d3774e08ecda4518

3 years agoBug fix and improve __ID3_getTwixFrameByName() 13/233213/3
hj kim [Wed, 13 May 2020 05:25:43 +0000 (14:25 +0900)]
Bug fix and improve __ID3_getTwixFrameByName()

It's not an error situation even though there is no tag to find
String::toCString(true) convert code to UTF8. and String::toCString(false) convert to Latin.
We need UTF8 so "true" should be set to toCString().

Change-Id: Ifa7d94946bf5e6eee89cb87545a4b924db9be16d

3 years agoUse auto keyword 31/233131/2
hj kim [Tue, 12 May 2020 10:10:59 +0000 (19:10 +0900)]
Use auto keyword

Change-Id: I9d87e1c47f93554cf79867044f01260a7546e682

3 years agoBug fix of getting number of pictures. it should return '0' if there is no picture. 93/232993/7
hj kim [Mon, 11 May 2020 06:57:33 +0000 (15:57 +0900)]
Bug fix of getting number of pictures. it should return '0' if there is no picture.

Change-Id: Ia43d59c27ccc176edba963f31f0940fba7ffb6b7

3 years agoImprove metadata_editor_remove_picture() API 86/232886/9
hj kim [Fri, 8 May 2020 06:28:47 +0000 (15:28 +0900)]
Improve metadata_editor_remove_picture() API

Change-Id: Ib957753653b501d8c6b543a7e789b523db199e7a

3 years agoImprove metadata_editor_append_picture() API 34/232734/12
hj kim [Thu, 7 May 2020 09:38:27 +0000 (18:38 +0900)]
Improve metadata_editor_append_picture() API

Change-Id: I030ebb2539b49eb9a1748cd9e529dd967432d45f

3 years agoUse defines for mime 18/232718/3
hj kim [Thu, 7 May 2020 08:27:48 +0000 (17:27 +0900)]
Use defines for mime

Change-Id: I5de8de8a0f6325dab8850bd25c8ac99be79c56e9

3 years agoUse auto keyword and remove METADATA_EDITOR_ERROR_OUT_OF_MEMORY for "new" keyword 11/232711/3
hj kim [Thu, 7 May 2020 08:15:03 +0000 (17:15 +0900)]
Use auto keyword and remove METADATA_EDITOR_ERROR_OUT_OF_MEMORY for "new" keyword

Change-Id: I595c96bade904e724dc1674fcae7a5f6ac15c459

3 years agoImprove metadata_editor_get_picture() API 61/232561/6
hj kim [Wed, 6 May 2020 09:05:19 +0000 (18:05 +0900)]
Improve metadata_editor_get_picture() API

Change-Id: I05d3d5e1d8713efa6bd286b73f1489e25df7ca35

4 years agoImprove metadata_editor_create() and Bug fix of metadata_editor_destroy() 43/232543/8
hj kim [Wed, 6 May 2020 07:47:24 +0000 (16:47 +0900)]
Improve metadata_editor_create() and Bug fix of metadata_editor_destroy()

filetype can be METADATA_EDITOR_FORMAT_NOTYPE if user only create handle with metadata_editor_create() without setting path.

Change-Id: Ie4d3784da64274d1b5ba127073356f492c761b16

4 years agoApply tizen coding rule 41/232541/3
hj kim [Wed, 6 May 2020 07:42:22 +0000 (16:42 +0900)]
Apply tizen coding rule

Change-Id: I101a499fc99fea4ba36946e9327d9eebba22a4d2

4 years agoImprove metadata_editor_update_metadata() API 50/232550/3
hj kim [Wed, 6 May 2020 08:17:40 +0000 (17:17 +0900)]
Improve metadata_editor_update_metadata() API

Change-Id: I524618dd0f78bdd05e902d437419c87136925e6e

4 years agoImprove __metadata_editor_get_picture_type() API 09/232109/5
hj kim [Tue, 28 Apr 2020 08:50:25 +0000 (17:50 +0900)]
Improve __metadata_editor_get_picture_type() API

Change-Id: Ib3fb371c5fd914ca94051f8151bcf4ec035bdff3

4 years agoremove 'isReadOnly'. readOnly() of File can replace it 60/232160/3
hj kim [Tue, 28 Apr 2020 23:32:53 +0000 (08:32 +0900)]
remove 'isReadOnly'. readOnly() of File can replace it

Change-Id: I467df758aa84a3cbf47aaefcc27ac79f5370be0a

4 years agoRemove 'isOpen'. 'file' in metadata_editor_s can replace it 59/232159/4
hj kim [Tue, 28 Apr 2020 23:25:38 +0000 (08:25 +0900)]
Remove 'isOpen'. 'file' in metadata_editor_s can replace it

Change-Id: I027aa484b8173ab26a3e38a4b1986f4d04bc8cca

4 years agoImprove metadata_editor_set_path() API 58/231658/11
hj kim [Thu, 23 Apr 2020 08:38:44 +0000 (17:38 +0900)]
Improve metadata_editor_set_path() API

Change-Id: I969f3da6669f7c9c62db44af9be9321f97581a67

4 years agoImprove metadata_editor_get_picture() API 66/231666/2
hj kim [Thu, 23 Apr 2020 09:38:37 +0000 (18:38 +0900)]
Improve metadata_editor_get_picture() API

Change-Id: Ib88f27133bd411181698150036737cfb52f37808

4 years agoUpdate code for checking input parameter 60/213860/2 accepted/tizen_5.5_unified_mobile_hotfix tizen_5.5_mobile_hotfix tizen_5.5_tv accepted/tizen/5.5/unified/20191031.030610 accepted/tizen/5.5/unified/mobile/hotfix/20201027.064748 accepted/tizen/unified/20190916.111556 submit/tizen/20190916.065445 submit/tizen_5.5/20191031.000002 submit/tizen_5.5_mobile_hotfix/20201026.185102 tizen_5.5.m2_release
hj kim [Mon, 16 Sep 2019 02:22:35 +0000 (11:22 +0900)]
Update code for checking input parameter

Change-Id: I86146cc21aabea5c48b9dc26cac0bbb6ce49338d

4 years agoUpdate code to reduce Cyclomatic Complexity and DC 88/212788/2 accepted/tizen/unified/20190901.225917 submit/tizen/20190829.010946 submit/tizen/20190830.003130
hj kim [Tue, 27 Aug 2019 02:01:07 +0000 (11:01 +0900)]
Update code to reduce Cyclomatic Complexity and DC

Change-Id: I2d9ea5df5687c41329981c77df0aa6be0c0592c5

4 years agoRemove check for gcov 17/209017/3 accepted/tizen/unified/20190702.234147 submit/tizen/20190701.235505
Minje Ahn [Tue, 2 Jul 2019 01:45:02 +0000 (10:45 +0900)]
Remove check for gcov

Change-Id: I99fcdd951a0afc327f39606167262e563c20c28c
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoFix build error 80/208980/1
Minje Ahn [Tue, 2 Jul 2019 00:27:44 +0000 (09:27 +0900)]
Fix build error

Change-Id: I7e5f0b6e080785c32c2dda1bf440ced048aaab3e
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoAdd for line coverage 73/208973/1
Minje Ahn [Mon, 1 Jul 2019 23:29:04 +0000 (08:29 +0900)]
Add for line coverage

Change-Id: Ief38a15eb8a0d5ce606b11fc9e5c22353ff2aaa1
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
5 years agoChange the value for checking fread() to the number of items 06/199006/2 accepted/tizen/unified/20190207.120246 submit/tizen/20190131.041045
jiyong.min [Thu, 31 Jan 2019 23:08:42 +0000 (08:08 +0900)]
Change the value for checking fread() to the number of items

Change-Id: I95149c62b7be1b73990830bb0ffa7f10404e16de

5 years agoAdd to check the return of fread() 86/198686/2
jiyong.min [Tue, 29 Jan 2019 00:28:04 +0000 (09:28 +0900)]
Add to check the return of fread()

 - If an error occurs, the return value is a short item count.

Change-Id: I3acb7494ff53f56243ae239b6c1371eb5537478f

5 years agoFix the log position to avoid errno change. 51/197151/1 accepted/tizen/unified/20190111.055158 submit/tizen/20190109.233706
jiyong.min [Thu, 10 Jan 2019 04:24:30 +0000 (13:24 +0900)]
Fix the log position to avoid errno change.

Change-Id: Ia7d81de1f5fa4aa766e3d700497d2cadc314456e

5 years agoFix wrong PC_REQUIRED 67/192167/1 accepted/tizen/unified/20181107.081944 submit/tizen/20181105.235320
hj kim [Wed, 31 Oct 2018 06:09:54 +0000 (15:09 +0900)]
Fix wrong PC_REQUIRED

Change-Id: I7314748e4903320bdaa95a15f730223647fd4e15

5 years agoAdd gcov environment 04/189204/1 accepted/tizen/5.0/unified/20181102.013545 accepted/tizen/unified/20180920.063844 submit/tizen/20180918.081101 submit/tizen/20180919.063447 submit/tizen_5.0/20181101.000002
SeokHoon Lee [Fri, 14 Sep 2018 07:13:56 +0000 (16:13 +0900)]
Add gcov environment

Signed-off-by: SeokHoon Lee <andy.shlee@samsung.com>
Change-Id: Ie6879f3d2a8baef1b61e7f53e6acf2030b4ffaf5

5 years agoJust update api description 65/182165/1 accepted/tizen/unified/20180625.141530 submit/tizen/20180622.070254
hj kim [Thu, 21 Jun 2018 05:04:07 +0000 (14:04 +0900)]
Just update api description

Change-Id: If122aba54eec100152d2625d008398102a324a5e

6 years agoFix Coverity issues 35/173635/1 accepted/tizen/unified/20180326.075231 submit/tizen/20180323.043859
hj kim [Fri, 23 Mar 2018 00:29:37 +0000 (09:29 +0900)]
Fix Coverity issues

Change-Id: I71fb5886972dae84270b701d35eca0176175fb86

6 years agoFix typo 58/171458/1 accepted/tizen/unified/20180307.071324 submit/tizen/20180305.053300
Minje Ahn [Mon, 5 Mar 2018 05:10:07 +0000 (14:10 +0900)]
Fix typo

Change-Id: If06f721dc2c9e13f04cd8e4944b43b72d193d6df
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
6 years agoFix typo 70/169870/1 accepted/tizen/unified/20180212.140712 submit/tizen/20180212.023542
Minje Ahn [Mon, 12 Feb 2018 02:31:48 +0000 (11:31 +0900)]
Fix typo

Change-Id: I309224042e23271c4ce2142b7f5ec5135219fde5
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
6 years agoFix Doxygen mistakes 78/168178/1 accepted/tizen/unified/20180125.122853 submit/tizen/20180125.001258
hj kim [Thu, 25 Jan 2018 00:19:30 +0000 (09:19 +0900)]
Fix Doxygen mistakes

Change-Id: I2e89f110ab047dd34e1c1ecbd6e6b6b7cb853fad

6 years agoFix Doxygen mistakes 83/168083/2
hj kim [Wed, 24 Jan 2018 05:17:03 +0000 (14:17 +0900)]
Fix Doxygen mistakes

Change-Id: I5338485c225160dc101280459f4dbb01a631c0b1

6 years agoReinforce coverage 24/153624/1 accepted/tizen/unified/20171012.191742 submit/tizen/20171012.055141
Minje Ahn [Fri, 29 Sep 2017 03:06:35 +0000 (12:06 +0900)]
Reinforce coverage

Change-Id: I387ff9ec8c67a0cfc8ec787a81d42a80b33a4168
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
6 years agoMerge "Apply tizen coding rule" into tizen accepted/tizen/unified/20170913.071148 submit/tizen/20170912.034220
Jiyong Min [Tue, 12 Sep 2017 04:59:33 +0000 (04:59 +0000)]
Merge "Apply tizen coding rule" into tizen

6 years agoApply tizen coding rule 73/149273/1
Jiyong Min [Tue, 12 Sep 2017 04:25:08 +0000 (13:25 +0900)]
Apply tizen coding rule

Change-Id: I808f35cc9231b7fe41b16f3c46d1cee1a6a48148
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoRemove \n in dlog msg 22/147822/1 accepted/tizen/unified/20170907.060444 submit/tizen/20170906.051057
Haejeong Kim [Wed, 6 Sep 2017 01:22:41 +0000 (10:22 +0900)]
Remove \n in dlog msg

Change-Id: Ibef41d8fe675c1e9feac348eb6dafbe9b34acc44

6 years agoFix svace defects 66/140366/6 accepted/tizen/4.0/unified/20170816.010521 accepted/tizen/4.0/unified/20170816.014241 accepted/tizen/4.0/unified/20170828.223750 accepted/tizen/unified/20170727.190538 submit/tizen/20170726.002338 submit/tizen_4.0/20170811.094300 submit/tizen_4.0/20170814.115522 submit/tizen_4.0/20170828.100002 submit/tizen_4.0_unified/20170814.115522
Minje Ahn [Tue, 25 Jul 2017 01:43:21 +0000 (10:43 +0900)]
Fix svace defects

Change-Id: I8777be6887041dfcb3d31fc4640a1af8fa6b5590
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
6 years agoJust update debugging msg 69/139469/1 accepted/tizen/unified/20170721.202116 submit/tizen/20170721.022556
Haejeong Kim [Wed, 19 Jul 2017 05:30:57 +0000 (14:30 +0900)]
Just update debugging msg

Change-Id: I8390c2bcdb7e1be1980c4bac727d5df83b6d8aba

6 years ago[RQ170613-00147] fix invalid format argument types for dlog 10/134310/1 accepted/tizen/unified/20170630.083038 submit/tizen/20170616.053948 submit/tizen/20170711.020236
Haejeong Kim [Fri, 16 Jun 2017 02:40:23 +0000 (11:40 +0900)]
[RQ170613-00147] fix invalid format argument types for dlog

Change-Id: Ibd62b71f5308218acb3e97c6d69d942a46b8f09d

7 years agoUse license macro in spec file 76/120476/1 accepted/tizen_common accepted/tizen_ivi accepted/tizen_mobile accepted/tizen_tv accepted/tizen_wearable accepted/tizen/common/20170323.154439 accepted/tizen/ivi/20170323.085124 accepted/tizen/mobile/20170323.085034 accepted/tizen/tv/20170323.085051 accepted/tizen/unified/20170323.085143 accepted/tizen/wearable/20170323.085106 submit/tizen/20170323.063443 tizen_4.0.m1_release
Haejeong Kim [Thu, 23 Mar 2017 05:44:02 +0000 (14:44 +0900)]
Use license macro in spec file

Change-Id: I4a6f0c03cb4bd4a1701dbacf369495f0b0f9f361

7 years agofix build error 87/109087/2 accepted/tizen/common/20170109.202418 accepted/tizen/ivi/20170109.084407 accepted/tizen/mobile/20170109.084310 accepted/tizen/tv/20170109.084326 accepted/tizen/unified/20170309.031803 accepted/tizen/wearable/20170109.084347 submit/tizen/20170109.021416 submit/tizen_unified/20170308.100404
Jiyong Min [Mon, 9 Jan 2017 00:29:48 +0000 (09:29 +0900)]
fix build error
(build fails because of undefined C++11 user-defined literals)

Change-Id: If4d3caa4fd73e7881304cd33f68b536addf92549
Signed-off-by: jiyong.min <jiyong.min@samsung.com>