From: Jiyong Date: Thu, 14 Mar 2024 08:51:25 +0000 (+0900) Subject: Fix coverity issue(Resource leak) X-Git-Tag: accepted/tizen/unified/20240320.110717~3 X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fapi%2Fmedia-content.git;a=commitdiff_plain;h=0bd93e228a808ce429cb72bec5f3de85e9e868d7 Fix coverity issue(Resource leak) - The media_directory_scanning_async has been changed to free cb_data. Change-Id: I12d77e9716baefeaf5a9383c3298ec31568ec0b4 --- diff --git a/packaging/capi-content-media-content.spec b/packaging/capi-content-media-content.spec index cc1c545..9aeb6d7 100644 --- a/packaging/capi-content-media-content.spec +++ b/packaging/capi-content-media-content.spec @@ -1,6 +1,6 @@ Name: capi-content-media-content Summary: A Media content library in Tizen Native API -Version: 0.4.26 +Version: 0.4.27 Release: 0 Group: Multimedia/API License: Apache-2.0 diff --git a/src/media_content.c b/src/media_content.c index 7550c65..360a59f 100644 --- a/src/media_content.c +++ b/src/media_content.c @@ -442,8 +442,10 @@ int media_content_scan_folder_v2(const char *path, bool is_recursive, media_scan /*FIX ME. need to check ret value?*/ ret = media_directory_scanning_async(path, storage_id, is_recursive, _media_content_scan_cb_v2, cb_data, _content_get_uid()); - if (ret != MS_MEDIA_ERR_NONE) + if (ret != MS_MEDIA_ERR_NONE) { content_error("media_directory_scanning_async failed : %d", ret); + g_free(cb_data); + } return _content_error_capi(ret); } diff --git a/src/media_info.c b/src/media_info.c index e29d17c..c98e6a9 100644 --- a/src/media_info.c +++ b/src/media_info.c @@ -153,6 +153,7 @@ static int __media_info_insert_batch(const char **path_array, content_error("media_files_register failed : %d", ret); if (unlink(list_path) < 0) content_stderror("failed to delete"); + g_free(_cb_data); return _content_error_capi(ret); }