From 25c3f231bc880acad1146be13aa5e672a9ffbf81 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Jos=C3=A9=20Bollo?= Date: Mon, 15 Sep 2014 11:42:04 +0200 Subject: [PATCH] SMACK: Fix wrong copy size MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The function strncpy was copying an extra character 9 when i == len (what is possible via revoke interface). Change-Id: Ic7452da05773e620a1d7bbc55e859c25a86c65f6 Signed-off-by: José Bollo (cherry picked from commit 6c2772dd37934589785aa8baf83a18d300353f0e) Signed-off-by: Damian Hobson-Garcia --- security/smack/smack_access.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/smack/smack_access.c b/security/smack/smack_access.c index c062e94..930e548 100644 --- a/security/smack/smack_access.c +++ b/security/smack/smack_access.c @@ -432,7 +432,7 @@ char *smk_parse_smack(const char *string, int len) smack = kzalloc(i + 1, GFP_KERNEL); if (smack != NULL) { - strncpy(smack, string, i + 1); + strncpy(smack, string, i); smack[i] = '\0'; } return smack; -- 2.7.4