v4l: vb2: Fix stream start and buffer completion race
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Mon, 23 Jun 2014 21:00:22 +0000 (23:00 +0200)
committerSimon Horman <horms@verge.net.au>
Fri, 5 Dec 2014 00:24:12 +0000 (09:24 +0900)
commite7f89d697aeb862a58b2e14e3a6e8e597ec42f32
treeb601cc1b928f62ea289110f3e75408bc6df37f4d
parent1aa460e34be8960ad5ae5d27efcd95d2d3ee1c63
v4l: vb2: Fix stream start and buffer completion race

videobuf2 stores the driver streaming state internally in the queue in
the start_streaming_called variable. The state is set right after the
driver start_stream operation returns, and checked in the
vb2_buffer_done() function, typically called from the frame completion
interrupt handler. A race condition exists if the hardware finishes
processing the first frame before the start_stream operation returns.

Fix this by setting start_streaming_called to 1 before calling the
start_stream operation, and resetting it to 0 if the operation fails.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
(cherry picked from commit 752bfe5395aa0609def7292c97a37c314ace5837)
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Conflicts:
drivers/media/v4l2-core/videobuf2-core.c
drivers/media/v4l2-core/videobuf2-core.c