selinux: selinux_setprocattr()->ptrace_parent() needs rcu_read_lock()
authorOleg Nesterov <oleg@redhat.com>
Sat, 14 Dec 2013 16:33:17 +0000 (17:33 +0100)
committerPaul Moore <pmoore@redhat.com>
Mon, 16 Dec 2013 21:00:29 +0000 (16:00 -0500)
commit465954cd649a7d8cd331695bd24a16bcb5c4c716
tree8c0e5ee5d4073fb24e4b58719488da578cfe49f8
parenta5e333d34037c64c5f667dee3c418b66874ba0b0
selinux: selinux_setprocattr()->ptrace_parent() needs rcu_read_lock()

selinux_setprocattr() does ptrace_parent(p) under task_lock(p),
but task_struct->alloc_lock doesn't pin ->parent or ->ptrace,
this looks confusing and triggers the "suspicious RCU usage"
warning because ptrace_parent() does rcu_dereference_check().

And in theory this is wrong, spin_lock()->preempt_disable()
doesn't necessarily imply rcu_read_lock() we need to access
the ->parent.

Reported-by: Evan McNabb <emcnabb@redhat.com>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Paul Moore <pmoore@redhat.com>
security/selinux/hooks.c