From: Yunchao He <yunchao.he@intel.com>
Date: Tue, 16 Apr 2013 09:22:29 +0000 (+0800)
Subject: correct error definition when to-be-uninstalled widget is running
X-Git-Tag: accepted/tizen_2.1/20130425.023916~5^2~13^2
X-Git-Url: http://review.tizen.org/git/?p=framework%2Fweb%2Fwrt-installer.git;a=commitdiff_plain;h=e7e95ca773350b41221440a48bfce39b2e968f40

correct error definition when to-be-uninstalled widget is running

[Issue#] N/A
[Problem] when the to-be-uninstalled app is running, the error is AlreadyUninstalled.
[Cause] No error for this kind
[Solution] Add an correct error definition.
[SCMRequest] N/A

Change-Id: Iec7194a84efe504c665a8b2fa4a998c32d3feae9
---

diff --git a/src/jobs/widget_uninstall/task_check.cpp b/src/jobs/widget_uninstall/task_check.cpp
index 1a1f62b..aac218b 100644
--- a/src/jobs/widget_uninstall/task_check.cpp
+++ b/src/jobs/widget_uninstall/task_check.cpp
@@ -56,10 +56,8 @@ void TaskCheck::StepUninstallPreCheck()
 
     if (true == isRunning) {
         LogError("Widget is not stopped. Cannot uninstall!");
-        //TODO different error
-        ThrowMsg(Exceptions::AlreadyUninstalling,
+        ThrowMsg(Exceptions::AppIsRunning,
                  "Widget is not stopped. Cannot uninstall!");
-        //TODO or defer uninstall?
     }
 
     LogInfo("Widget Can be uninstalled. Pkgname : " << m_context.tzAppid);
diff --git a/src/jobs/widget_uninstall/widget_uninstall_errors.h b/src/jobs/widget_uninstall/widget_uninstall_errors.h
index 842896c..3f1dbf5 100644
--- a/src/jobs/widget_uninstall/widget_uninstall_errors.h
+++ b/src/jobs/widget_uninstall/widget_uninstall_errors.h
@@ -37,6 +37,7 @@ DECLARE_JOB_EXCEPTION_BASE(JobExceptionBase, Base, ErrorUnknown)
 DECLARE_JOB_EXCEPTION(Base, DatabaseFailure, ErrorWidgetUninstallationFailed)
 DECLARE_JOB_EXCEPTION(Base, AlreadyUninstalling,
         ErrorWidgetUninstallationFailed)
+DECLARE_JOB_EXCEPTION(Base, AppIsRunning, ErrorWidgetUninstallationFailed)
 DECLARE_JOB_EXCEPTION(Base, WidgetNotExist, ErrorWidgetUninstallationFailed)
 DECLARE_JOB_EXCEPTION(Base, UninstallOspSvcFailed,
         ErrorWidgetUninstallationFailed)