2012-06-22 Dirk Pranke run_webkit_tests.py failed with AttributeError(''NoneType' object has no attribute 'pid'') https://bugs.webkit.org/show_bug.cgi?id=89734 Reviewed by Ryosuke Niwa. Fix a crash in ServerProcess if you called .pid() after it crashed during a write(). We had a test for this case but the test wasn't calling pid(), just has_crashed(). Fixed the problem and the test. * Scripts/webkitpy/layout_tests/port/server_process.py: (ServerProcess.__init__): (ServerProcess.pid): (ServerProcess._start): (ServerProcess.stop): * Scripts/webkitpy/layout_tests/port/server_process_unittest.py: (FakeServerProcess._start): (TestServerProcess.test_broken_pipe): 2012-05-30 Ojan Vafai Only give lint errors for -expected.png png files that lack a checksum https://bugs.webkit.org/show_bug.cgi?id=87875 Reviewed by Tony Chang. We have other pngs in the tree, e.g. for the inspector, that legitimately lack a checksum. * Scripts/webkitpy/style/checkers/png.py: (PNGChecker.check): * Scripts/webkitpy/style/checkers/png_unittest.py: (PNGCheckerTest.test_check): 2012-05-30 Dirk Pranke nrwt: seems to leak temp dirs https://bugs.webkit.org/show_bug.cgi?id=87795 Reviewed by Ojan Vafai. There appears to be a bug where the chromium bots are creating temporary directories and not cleaning them up that started after the switch to WebKitDriver. It's possible that __del__ wasn't getting called in a timely manner (or at all), and it's generally bad style to rely on __del__ being called, so this code changes things so that we create a temp dir in driver.start() and remove it in driver.stop(). We could be paranoid and leave the __del__ code in, but there doesn't seem to be much advantage to it. If there are bugs that result in drivers being started but not stopped, we have other problems. * Scripts/webkitpy/common/system/filesystem_mock.py: (MockFileSystem.__init__): (MockFileSystem._mktemp): (MockFileSystem.mkdtemp): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitDriver.__init__): (WebKitDriver._start): (WebKitDriver.stop): * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: (WebKitDriverTest.test_check_for_driver_crash): (WebKitDriverTest): (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem): (WebKitDriverTest.test_stop_cleans_up_properly): 2012-05-30 Christophe Dumez [EFL] EFL's DRT should print the number of MessagePorts for new each new intent https://bugs.webkit.org/show_bug.cgi?id=86841 Reviewed by Adam Barth. Print the number of MessagePorts for each new intent in EFL's DRT. This output is expected by several Web Intents test cases. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: (DumpRenderTreeChrome::onFrameIntentNew): 2012-05-30 Kevin Ollivier [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled. * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 2012-05-30 Christophe Dumez [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument https://bugs.webkit.org/show_bug.cgi?id=87829 Reviewed by Adam Barth. EFL's LayoutTestController now makes uses of the new helper method in DumpRenderTreeSupportEfl in order to send the intent response. This is now needed because the Ewk_Intent_Request postResult / postFailure methods were made private. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: (LayoutTestController::sendWebIntentResponse): 2012-05-30 Xueqing Huang eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests. https://bugs.webkit.org/show_bug.cgi?id=86296 Reviewed by Tony Chang. * DumpRenderTree/win/DRTDataObject.cpp: Added. (cfHDropFormat): (cfFileNameWFormat): (cfUrlWFormat): (WCEnumFormatEtc): (WCEnumFormatEtc::WCEnumFormatEtc): (WCEnumFormatEtc::QueryInterface): (WCEnumFormatEtc::AddRef): (WCEnumFormatEtc::Release): (WCEnumFormatEtc::Next): (WCEnumFormatEtc::Skip): (WCEnumFormatEtc::Reset): (WCEnumFormatEtc::Clone): (DRTDataObject::createInstance): (DRTDataObject::DRTDataObject): (DRTDataObject::~DRTDataObject): (DRTDataObject::QueryInterface): (DRTDataObject::AddRef): (DRTDataObject::Release): (DRTDataObject::GetData): (DRTDataObject::GetDataHere): (DRTDataObject::QueryGetData): (DRTDataObject::GetCanonicalFormatEtc): (DRTDataObject::SetData): (DRTDataObject::CopyMedium): (DRTDataObject::EnumFormatEtc): (DRTDataObject::DAdvise): (DRTDataObject::DUnadvise): (DRTDataObject::EnumDAdvise): (DRTDataObject::clearData): * DumpRenderTree/win/DRTDataObject.h: Added. (DRTDataObject): * DumpRenderTree/win/DRTDropSource.cpp: Added. (DRTDropSource::DRTDropSource): (DRTDropSource::~DRTDropSource): (DRTDropSource::QueryInterface): (DRTDropSource::AddRef): (DRTDropSource::Release): (DRTDropSource::createInstance): (DRTDropSource::QueryContinueDrag): (DRTDropSource::GiveFeedback): * DumpRenderTree/win/DRTDropSource.h: Added. (DRTDropSource): * DumpRenderTree/win/DumpRenderTree.vcproj: * DumpRenderTree/win/EventSender.cpp: (beginDragWithFilesCallback): 2012-05-30 Marcelo Lira WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner. https://bugs.webkit.org/show_bug.cgi?id=58593 Adds the ability to change the pluginsEnabled flag in WebCore::Settings to WebKitTestRunner's LayoutTestController. The flag is modified via the public C API of the WebProcess. Reviewed by Darin Adler. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setPluginsEnabled): Just calls the WKBundleSetPluginsEnabled function in the public C API of WebProcess. * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 2012-05-30 Mikhail Pozdnyakov [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass https://bugs.webkit.org/show_bug.cgi?id=87848 Reviewed by Csaba Osztrogonác. The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: (DumpRenderTreeChrome::extraViews): * DumpRenderTree/efl/DumpRenderTreeChrome.h: (DumpRenderTreeChrome): 2012-05-30 Mikhail Pozdnyakov [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message https://bugs.webkit.org/show_bug.cgi?id=87833 Reviewed by Tor Arne Vestbø. Print "postProgressFinishedNotification" message if frame load finished to unskip http/tests/loading/progress-finished-callback.html. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: (DumpRenderTreeChrome::onFrameLoadFinished): 2012-05-30 Mariusz Grzegorczyk , Ryuan Choi [EFL][WK2] Fix WebKit2-EFL build https://bugs.webkit.org/show_bug.cgi?id=83693 Reviewed by Carlos Garcia Campos. * CMakeLists.txt: Guard Webkit1 related codes with ENABLE_WEBKIT. 2012-05-29 János Badics [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too (They only used to check for Skipped in platform/qt-5.0-wk1) https://bugs.webkit.org/show_bug.cgi?id=87376 Reviewed by Csaba Osztrogonác. * Scripts/old-run-webkit-tests: (buildPlatformResultHierarchy): * Scripts/webkitpy/layout_tests/port/qt.py: (QtPort.baseline_search_path): 2012-05-29 Ojan Vafai Add a linter error for pngs that lack an embedded checksum https://bugs.webkit.org/show_bug.cgi?id=87793 Reviewed by Dirk Pranke. * Scripts/read-checksum-from-png: * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py. (read_checksum): * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py. (ReadChecksumFromPngTest): (ReadChecksumFromPngTest.test_read_checksum): * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/style/checkers/png.py: (PNGChecker.check): * Scripts/webkitpy/style/checkers/png_unittest.py: (PNGCheckerTest.test_check): 2012-05-29 Stephanie Lewis https://bugs.webkit.org/show_bug.cgi?id=87720 WebProcess is often killed due to being unresponsive on the bots Reviewed by Alexey Proskuryakov. Blind attempt to improve flakiness on the bots by reducing the number of crashes due to an unresponsive process. This helped on my personal machine under stress conditions. I don't have enough cores to hit the problem under normal conditions. * WebKitTestRunner/TestController.cpp: (WTR): 2012-05-29 Dirk Pranke webkitpy: rename 'rm' to 'delete' in rebaseline scm output https://bugs.webkit.org/show_bug.cgi?id=87779 Reviewed by Eric Seidel. Update output to match the names in scm.py as per https://bugs.webkit.org/show_bug.cgi?id=87451#c26 . * Scripts/webkitpy/tool/commands/rebaseline.py: (RebaselineTest.execute): * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: (test_rebaseline_test_and_print_scm_changes): * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: (GardeningServerTest.test_rebaselineall): 2012-05-29 Stephanie Lewis https://bugs.webkit.org/show_bug.cgi?id=87711 Reviewed by Jessie Berlin. Remove Snowleopard testers so the hardware can be repurposed. The lion bots are better maintained. * BuildSlaveSupport/build.webkit.org-config/config.json: 2012-05-29 Dirk Pranke webkit-patch optimize-baselines should add/delete files in batches from the vcs https://bugs.webkit.org/show_bug.cgi?id=87538 Reviewed by Ojan Vafai. Invoking git and svn on one file at a time is kinda slow. We should batch the add and rm operations together. * Scripts/webkitpy/common/checkout/baselineoptimizer.py: (BaselineOptimizer._move_baselines): 2012-05-29 Dirk Pranke garden-o-matic should rebaseline baselines in parallel https://bugs.webkit.org/show_bug.cgi?id=87451 Reviewed by Ojan Vafai. This modifies garden-o-matic so that we will fetch all of the baselines in parallel from the bots, and then optimize the baselines serially (since that should be fairly quick and we get into trouble if we optimize in parallel due to concurrent access to the source control system). This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes) so that the files that need to be modified in the SCM are returned to garden-o-matic rather than actually added or removed. This is done so that we can run multiple rebaseline-tests in parallel (we can't modify the SCM concurrently). In order to safely return the files (as a JSON dict) I needed to shift all of the logging in rebaseline-test to use the logging module (and hence log to stderr). I also had to stub out a line in chromium.py that would get confused if the skia overrides file didn't exist in a mock checkout. * Scripts/webkitpy/common/system/executive.py: (Executive.popen): (Executive): (Executive.run_in_parallel): (_run_command_thunk): * Scripts/webkitpy/common/system/executive_mock.py: (MockExecutive.run_in_parallel): * Scripts/webkitpy/common/system/executive_unittest.py: (ExecutiveTest.test_run_in_parallel): * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumPort._expectations_file_contents): * Scripts/webkitpy/tool/commands/rebaseline.py: (AbstractRebaseliningCommand.__init__): (RebaselineTest.__init__): (RebaselineTest._copy_existing_baseline): (RebaselineTest._save_baseline): (RebaselineTest): (RebaselineTest._add_to_scm): (RebaselineTest._rebaseline_test): (RebaselineTest.execute): (RebaselineExpectations._rebaseline_port): (RebaselineExpectations.execute): (Rebaseline._builder_to_pull_from): (Rebaseline.execute): * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: (test_rebaseline_updates_expectations_file): (test_rebaseline_test): (test_rebaseline_test_and_print_scm_changes): (test_rebaseline_and_copy_test): (test_rebaseline_and_copy_test_no_existing_result): (test_rebaseline_and_copy_test_with_lion_result): (test_rebaseline_and_copy_no_overwrite_test): (test_rebaseline_expectations): * Scripts/webkitpy/tool/servers/gardeningserver.py: (GardeningHTTPRequestHandler._rebaseline_commands): (GardeningHTTPRequestHandler): (GardeningHTTPRequestHandler._files_to_add): (GardeningHTTPRequestHandler._optimize_baselines): (GardeningHTTPRequestHandler.rebaselineall): * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: (GardeningServerTest._post_to_path): (GardeningServerTest.test_rebaselineall): (GardeningServerTest.test_rebaselineall.run_command): 2012-05-29 Benjamin Poulain Fix the type of dispatch_time() offset Rubber-stamped by Joseph Pecoraro. In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time(). * DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): 2012-05-29 Arvid Nilsson 2012-05-29 Arvid Nilsson [BlackBerry] OpenGL content is not rendered on simulator https://bugs.webkit.org/show_bug.cgi?id=87721 Reviewed by George Staikos. Fixed by enabling GLES2 support in simulator builds. To experiment with building without OpenGL support, you can set the DISABLE_GLES2 environment variable to a non-empty string and rebuild. PR #150695 * Scripts/webkitdirs.pm: (blackberryCMakeArguments): 2012-05-29 David Barr Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag https://bugs.webkit.org/show_bug.cgi?id=87685 Reviewed by Eric Seidel. Add a configuration option for CSS image-resolution support, disabling it by default. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: 2012-05-29 Tor Arne Vestbø [Qt] Don't add cxx-flags to QMAKE_CFLAGS Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is valid for C++/ObjC++ but not for C [enabled by default]" Reviewed by Simon Hausmann. * qmake/mkspecs/features/unix/default_post.prf: 2012-05-29 Tor Arne Vestbø [Qt] Sync up favicon-implementation with WebView url changes in r118158 https://bugs.webkit.org/show_bug.cgi?id=87133 We now base64-encode the page url in the image-provider url, so that any normalization done by QUrl will not mess up the page-url. The logic of creating and parsing the provider-url has been moved into the image provider, to keep it in one place. We were also releasing icons (even ones we hadn't retained), which we can't do since we don't know when the icon url is no longer in use. Reviewed-by Simon Hausmann. * MiniBrowser/qt/icons/favicon.png: * MiniBrowser/qt/qml/BrowserWindow.qml: 2012-05-29 Mikhail Pozdnyakov [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function https://bugs.webkit.org/show_bug.cgi?id=87654 Reviewed by Csaba Osztrogonác. Event sender provides strings for all the key events. Also KeyEventInfo constructor parameters order was changed to simplify the case when a key event has empty string. * DumpRenderTree/efl/EventSender.cpp: (KeyEventInfo::KeyEventInfo): (keyPadNameFromJSValue): (keyNameFromJSValue): 2012-05-23 Tor Arne Vestbø [Qt] Cancel potential url-edit when going back/forward Reviewed by Kenneth Rohde Christiansen. * MiniBrowser/qt/qml/BrowserWindow.qml: 2012-05-29 Christophe Dumez [EFL] Compilation warning in DumpRenderTreeView.cpp https://bugs.webkit.org/show_bug.cgi?id=87636 Reviewed by Filip Pizlo. Fix compilation error in DumpRenderTreeView.cpp due to wrong format specifier in printf. Also fix the return type for onExceededApplicationCacheQuota callback. * DumpRenderTree/efl/DumpRenderTreeView.cpp: (onExceededApplicationCacheQuota): 2012-05-29 Hironori Bono Adding Hironori Bono to committers.py. https://bugs.webkit.org/show_bug.cgi?id=87697 * Scripts/webkitpy/common/config/committers.py: 2012-05-28 Jonathan Dong [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail https://bugs.webkit.org/show_bug.cgi?id=80135 Reviewed by Rob Buis. Implemented interface function didReceiveAuthenticationChallenge in class DumpRenderTree. Resubmit the patch reverted by r115104 after the digest infinite loop issue for BlackBerry porting get identified and fixed. Internally reviewed by Joe Mason * DumpRenderTree/blackberry/DumpRenderTree.cpp: (drtCredentialDescription): (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge): (WebKit): * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: (WebCore): (DumpRenderTree): 2012-05-25 Jesus Sanchez-Palencia WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled https://bugs.webkit.org/show_bug.cgi?id=42328 Reviewed by Eric Seidel. Removed unneeded setJavaScriptProfilingEnabled function from DRT after its move to windows.internals.settings. * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: (LayoutTestController): * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: * DumpRenderTree/chromium/DRTDevToolsAgent.h: (DRTDevToolsAgent): * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): * DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController): * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: (DumpRenderTreeChrome::resetDefaultsToConsistentValues): * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): * DumpRenderTree/mac/LayoutTestControllerMac.mm: * DumpRenderTree/qt/LayoutTestControllerQt.cpp: * DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController): * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): * DumpRenderTree/win/LayoutTestControllerWin.cpp: * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: * WebKitTestRunner/InjectedBundle/LayoutTestController.h: (LayoutTestController): 2012-05-28 Gyuyoung Kim Move allowRoundingHacks to Internals interface https://bugs.webkit.org/show_bug.cgi?id=87328 Reviewed by Hajime Morita. Remove allowRoundingHacks functions, because it is able to work in the cross-port way through the Internals interface. * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: (LayoutTestController): * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: * DumpRenderTree/mac/LayoutTestControllerMac.mm: * DumpRenderTree/win/LayoutTestControllerWin.cpp: * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 2012-05-28 Luke Macpherson Fix mac build with older XCode by defining NSEC_PER_MSEC. https://bugs.webkit.org/show_bug.cgi?id=87616 Reviewed by Hajime Morita. The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions. http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm Patch just adds a #ifndef / #define check. * DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): 2012-05-27 Sudarsana Nagineni [EFL] Enable blob support for the EFL port https://bugs.webkit.org/show_bug.cgi?id=85363 Reviewed by Hajime Morita. Enable Blob support by default for the EFL port. * Scripts/webkitperl/FeatureList.pm: 2012-05-27 Benjamin Poulain When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called https://bugs.webkit.org/show_bug.cgi?id=87582 Reviewed by Darin Adler. Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it possible to test pages in a similar way as they are loaded in Browsers. * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (setUseDeferredFrameLoadingCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: (LayoutTestController::useDeferredFrameLoading): (LayoutTestController::setUseDeferredFrameLoading): (LayoutTestController): * DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): 2012-05-27 David Barton [watchlist] Improve MathML rule https://bugs.webkit.org/show_bug.cgi?id=87592 Reviewed by Adam Barth. The old rule "filename": r".*mathml" works fine because "filename" is a prefix match, but if this changed the rule would be slow. We protect against this, clarify the rule, and make it more similar to existing rules. * Scripts/webkitpy/common/config/watchlist: 2012-05-27 David Barton [watchlist] Add myself & a rule for MathML https://bugs.webkit.org/show_bug.cgi?id=87586 Reviewed by Adam Barth. * Scripts/webkitpy/common/config/watchlist: 2012-05-26 David Kilzer Use xcrun to find path to nm for Mac port Reviewed by Dan Bernstein. * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort.nm_command): Add. Tries to find a path for the nm command using xcrun. Falls back to returning 'nm'. * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort.nm_command): Add. Returns 'nm'. (WebKitPort._webcore_symbols_string): Call self.nm_command(). 2012-05-25 Lynn Neir Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021 Reviewed by Eric Seidel. * DumpRenderTree/win/DumpRenderTree.vcproj: * DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::FrameLoadDelegate): (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld): * DumpRenderTree/win/FrameLoadDelegate.h: (FrameLoadDelegate): * DumpRenderTree/win/TextInputController.cpp: Added. (setMarkedTextCallback): (hasMarkedTextCallback): (unmarkTextCallback): (markedRangeCallback): (insertTextCallback): (firstRectForCharacterRangeCallback): (selectedRangeCallback): (TextInputController::makeWindowObject): (TextInputController::getJSClass): (TextInputController::staticValues): (TextInputController::staticFunctions): * DumpRenderTree/win/TextInputController.h: Added. (TextInputController): * DumpRenderTree/win/TextInputControllerWin.cpp: Added. (TextInputController::setMarkedText): (TextInputController::hasMarkedText): (TextInputController::unmarkText): (TextInputController::markedRange): (TextInputController::insertText): (TextInputController::firstRectForCharacterRange): (TextInputController::selectedRange): 2012-05-25 Dirk Pranke webkitpy: change scm.add(), scm.delete() to accept multiple paths https://bugs.webkit.org/show_bug.cgi?id=87528 Reviewed by Ojan Vafai. launching git or svn for individual files can be slow; this change will hand multiple paths at once to git and svn so they can be added in a batch. * Scripts/webkitpy/common/checkout/scm/git.py: (Git.add_list): (Git.delete_list): * Scripts/webkitpy/common/checkout/scm/scm.py: (SCM.add): (SCM): (SCM.add_list): (SCM.delete): (SCM.delete_list): * Scripts/webkitpy/common/checkout/scm/scm_mock.py: (MockSCM.add): (MockSCM): (MockSCM.add_list): (MockSCM.delete): (MockSCM.delete_list): * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: (_shared_test_exists): (_shared_test_added_files): (_test_delete_list): * Scripts/webkitpy/common/checkout/scm/svn.py: (SVN.add_list): (SVN.delete_list): 2012-05-25 Thiago Marcos P. Santos [NRWT] Add unit testing for perf tests on locked shards https://bugs.webkit.org/show_bug.cgi?id=87489 Reviewed by Dirk Pranke. Adding utests that makes sure that perf tests are running in locked shards and by passing --no-http won't break NRWT (r118421). * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: (ShardingTests): (ShardingTests.test_shard_by_dir): (ShardingTests.test_shard_every_file): (ShardingTests.test_shard_in_two): (ShardingTests.test_multiple_locked_shards): (LockCheckingManager): (LockCheckingManager.__init__): (LockCheckingManager.handle_finished_list): (ManagerTest.test_http_locking): (ManagerTest): (ManagerTest.test_perf_locking): * Scripts/webkitpy/layout_tests/port/test.py: 2012-05-25 Jessie Berlin [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001 https://bugs.webkit.org/show_bug.cgi?id=87511 Reviewed by Alexey Proskuryakov. Update the Windows implementation of keyDown to match the Mac one changed in r118001. * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): 2012-05-25 Ken Buchanan Adding Ken Buchanan to committers.py https://bugs.webkit.org/show_bug.cgi?id=87443 Unreviewed. Adding self to committers.py as a Committer. * Scripts/webkitpy/common/config/committers.py: 2012-05-25 Csaba Osztrogonác [Qt] Buildfix for newer Qt5 https://bugs.webkit.org/show_bug.cgi?id=87257 Reviewed by Simon Hausmann. * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming. 2012-05-25 Csaba Osztrogonác [Qt] Unreviewed fix after r118484. Enable CSS_EXCLUSIONS and CSS_REGIONS. They were enabled uncoditinally before r118484. * qmake/mkspecs/features/features.pri: 2012-05-24 Tim Horton Add feature defines for web-facing parts of CSS Regions and Exclusions https://bugs.webkit.org/show_bug.cgi?id=87442 Reviewed by Dan Bernstein. * Scripts/webkitperl/FeatureList.pm: 2012-05-24 Hironori Bono Enable grammar checking on Chromium when we paste text (Take 2) https://bugs.webkit.org/show_bug.cgi?id=74393 Reviewed by Ryosuke Niwa. This change enables grammar checking on Chromium and implements a mock grammar checker to fix a failing test. * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added. (MockGrammarCheck::checkGrammarOfString): * DumpRenderTree/chromium/MockGrammarCheck.h: Added. (WebKit): (MockGrammarCheck): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors. 2012-05-24 Sudarsana Nagineni [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference https://bugs.webkit.org/show_bug.cgi?id=86842 Reviewed by Antonio Gomes. Add support for overriding the application cache support preference through EFL's LayoutTestController. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: (LayoutTestController::overridePreference): 2012-05-24 Sudarsana Nagineni [EFL] Remove unnecessary extra call to set developer extras setting on the test startup https://bugs.webkit.org/show_bug.cgi?id=85209 Reviewed by Antonio Gomes. Set developer extras setting called twice on the test startup. Hence, removing an unnecessary extra call which set wrong value. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: (DumpRenderTreeChrome::resetDefaultsToConsistentValues): 2012-05-24 Dirk Pranke garden-o-matic should not fetch from debug bots if it also knows about the release bots https://bugs.webkit.org/show_bug.cgi?id=86916 Reviewed by Adam Barth. Note that if release and debug are failing differently, debug will be ignored ... Note: also change the use of a fake port name from "mock-port-name" to "test-mac-leopard" to make it more friendly to the port factory ("mock" actually is a real port). * Scripts/webkitpy/tool/servers/gardeningserver.py: (GardeningHTTPRequestHandler._builders_to_fetch_from): (GardeningHTTPRequestHandler.rebaselineall): * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: (GardeningServerTest.test_rebaselineall): (GardeningServerTest.test_rebaseline_new_port): 2012-05-24 Dirk Pranke nrwt: fix baseline search path for official chrome builders https://bugs.webkit.org/show_bug.cgi?id=87432 Reviewed by Tony Chang. The official chrome builders need to use the win7 and SL baseline paths, not the XP and Leopard paths. Linux is correct. * Scripts/webkitpy/layout_tests/port/google_chrome.py: (GoogleChromeMacPort.determine_full_port_name): (GoogleChromeWinPort.determine_full_port_name): * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py: (TestGoogleChromePort._verify_baseline_search_path_startswith): (TestGoogleChromePort.test_get_google_chrome_port): 2012-05-24 Thiago Marcos P. Santos [NRWT] REGRESSION(r116021): Assertion when running with --no-http https://bugs.webkit.org/show_bug.cgi?id=86800 Reviewed by Dirk Pranke. Don't launch a HTTP server with lock based only on the existence of locked shards since we now run perf on locked shards too. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager._run_tests): 2012-05-24 Jochen Eisinger Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries https://bugs.webkit.org/show_bug.cgi?id=87128 Reviewed by Dirk Pranke. * Scripts/webkitpy/layout_tests/port/base.py: (Port.driver_name): * Scripts/webkitpy/layout_tests/port/chromium_linux.py: (ChromiumLinuxPort._path_to_driver): * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: (ChromiumPortTest.test_driver_name_option): * Scripts/webkitpy/layout_tests/port/chromium_win.py: (ChromiumWinPort._path_to_driver): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): 2012-05-24 John Mellor Font Boosting: Add compile flag and runtime setting https://bugs.webkit.org/show_bug.cgi?id=87394 Reviewed by Adam Barth. Add ENABLE_FONT_BOOSTING. * Scripts/webkitperl/FeatureList.pm: * qmake/mkspecs/features/features.pri: 2012-05-24 Mikhail Pozdnyakov [EFL] [DRT] keyboard-related tests do not pass https://bugs.webkit.org/show_bug.cgi?id=85369 Reviewed by Gustavo Noronha Silva. Add SHIFT modifier for capital letters as VK_ codes do not distinguish between lows and caps and also to be consistent with other ports which send caps as lowercase letters with the shift key down. * DumpRenderTree/efl/EventSender.cpp: (keyNameFromJSValue): 2012-05-24 Alexey Proskuryakov [WK2] Let the client give local files universal access on a case by case basis https://bugs.webkit.org/show_bug.cgi?id=87174 Reviewed by Maciej Stachowiak. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): Added initialization of a new structure member to prevent build failure. 2012-05-24 Raphael Kubo da Costa [EFL] Modify keycode conversion functions to return keycodes with location information after r118001. https://bugs.webkit.org/show_bug.cgi?id=87203 Reviewed by Andreas Kling. Add the required changes to make fast/events/keydown-leftright-keys.html pass after r118001. * DumpRenderTree/efl/EventSender.cpp: (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}" into the proper X11 keysym definitions. 2012-05-24 Sheriff Bot Unreviewed, rolling out r118352. http://trac.webkit.org/changeset/118352 https://bugs.webkit.org/show_bug.cgi?id=87390 Caused 6 editing/spelling tests crash/fail on chromium in debug. (Requested by vsevik on #webkit). * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed. * DumpRenderTree/chromium/MockGrammarCheck.h: Removed. * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::finishLastTextCheck): 2012-05-24 Peter Beverloo Add John Mellor as a contributor https://bugs.webkit.org/show_bug.cgi?id=87389 Reviewed by Kenneth Rohde Christiansen. John will be working on Font Boosting and is very involved with various web-facing subjects of Chrome for Android, such as viewport. * Scripts/webkitpy/common/config/committers.py: 2012-05-24 Mikhail Pozdnyakov [EFL][DRT] LayoutTestController's setCacheModel() implementation https://bugs.webkit.org/show_bug.cgi?id=86840 Reviewed by Csaba Osztrogonác. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: (LayoutTestController::setCacheModel): Implementation added. 2012-05-24 Hironori Bono Enable grammar checking on Chromium when we paste text. https://bugs.webkit.org/show_bug.cgi?id=74393 Reviewed by Hajime Morita. This change enables grammar checking on Chromium and implements a mock grammar checker to fix a failing test. * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added. (MockGrammarCheck::checkGrammarOfString): * DumpRenderTree/chromium/MockGrammarCheck.h: Added. (WebKit): (MockGrammarCheck): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors. 2012-05-24 Csaba Osztrogonác [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304. * qmake/mkspecs/features/features.pri: 2012-05-24 Christophe Dumez [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse https://bugs.webkit.org/show_bug.cgi?id=86867 Reviewed by Adam Barth. Add implementation for sendWebIntentResponse() in EFL's LayoutTestController and add empty implementation for other ports. * DumpRenderTree/LayoutTestController.cpp: (sendWebIntentResponseCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: (LayoutTestController): * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: (LayoutTestController::sendWebIntentResponse): * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: (DumpRenderTreeChrome::currentIntentRequest): (DumpRenderTreeChrome::resetDefaultsToConsistentValues): (DumpRenderTreeChrome::onFrameIntentNew): * DumpRenderTree/efl/DumpRenderTreeChrome.h: (DumpRenderTreeChrome): * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: (LayoutTestController::sendWebIntentResponse): * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::sendWebIntentResponse): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::sendWebIntentResponse): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::sendWebIntentResponse): * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::sendWebIntentResponse): 2012-05-24 Christophe Dumez [EFL] The EFL port has no support for title directionality https://bugs.webkit.org/show_bug.cgi?id=86462 Reviewed by Gustavo Noronha Silva. Update "title,changed" signal handlers in DRT and EWebLauncher to reflect the change from const char* to Ewk_Text_With_Direction* type for the title. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: (DumpRenderTreeChrome::onTitleChanged): * EWebLauncher/main.c: (title_set): (on_title_changed): (on_key_down): 2012-05-23 Gyuyoung Kim Change EFL debug build name with more detail one https://bugs.webkit.org/show_bug.cgi?id=87254 Reviewed by Ryosuke Niwa. EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name. In addition, remove efl-linux-debug triggerable since nobody uses it. * BuildSlaveSupport/build.webkit.org-config/config.json: 2012-05-23 Kangil Han [EFL][DRT] Fix WebCore library path and rebaseline result https://bugs.webkit.org/show_bug.cgi?id=86355 Reviewed by Dirk Pranke. Currently EFL DRT uses wrong WebCore library path when running DRT. Therefore, this patch adjusted the path correctly. * Scripts/webkitpy/layout_tests/port/efl.py: (EflPort._path_to_webcore_library): 2012-05-23 Ojan Vafai add back the ability to disable flexbox https://bugs.webkit.org/show_bug.cgi?id=87147 Reviewed by Tony Chang. * Scripts/webkitperl/FeatureList.pm: 2012-05-23 Tony Chang Remove the Chromium Grid Layout bot from the waterfall https://bugs.webkit.org/show_bug.cgi?id=87311 Reviewed by Ryosuke Niwa. I removed the compiler define in r117613, so we don't need a separate bot to compile/test this code. * BuildSlaveSupport/build.webkit.org-config/config.json: 2012-05-23 Ian Vollick Add vollick to list of contributors. https://bugs.webkit.org/show_bug.cgi?id=87305 Reviewed by Adam Barth. * Scripts/webkitpy/common/config/committers.py: 2012-05-23 Xianzhu Wang [Chromium-Android] Fix chromium_android_unittest https://bugs.webkit.org/show_bug.cgi?id=87196 Reviewed by Tony Chang. Update unit tests after ChromiumAndroidPort supported apk based DumpRenderTree. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: (ChromiumAndroidPortTest): (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler. (ChromiumAndroidPortTest.test_get_last_stacktrace): (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log() (ChromiumAndroidDriverTest): (ChromiumAndroidDriverTest.setUp): (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line() (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android) 2012-05-23 Caio Marcelo de Oliveira Filho [watchlist] Add myself and create a watch rule to catch Attribute related patches https://bugs.webkit.org/show_bug.cgi?id=87303 Reviewed by Alexis Menard. * Scripts/webkitpy/common/config/watchlist: 2012-05-23 Dirk Pranke garden-o-matic should not fetch from debug bots if it also knows about the release bots https://bugs.webkit.org/show_bug.cgi?id=86916 Reviewed by Adam Barth. This change pushes all of the logic for rebaselining a cluster of failures (a list of tests failing a list of suffixes on a list of bots) onto the server, so there is a single call from the web page; we will then be able to optimize the performance of the rebaselining better. Also remove the 'optimizebaseline' entry point on garden-o-matic (and the client-side call) since we don't need it any more. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: * Scripts/webkitpy/tool/servers/gardeningserver.py: (GardeningHTTPRequestHandler.rebaselineall): * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: 2012-05-21 Ryosuke Niwa Mac DRT should be able to load external URLs for replay performance tests https://bugs.webkit.org/show_bug.cgi?id=86191 Reviewed by Alexey Proskuryakov. Let external URL requests go through if the test file is not a local file or hosted at localhost. e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or "DumpRenderTree http://localhost:8000/". * DumpRenderTree/mac/ResourceLoadDelegate.mm: (isLocalhost): (hostIsUsedBySomeTestsToGenerateError): (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): 2012-05-23 Malcolm MacLeod [wx] In wxWebKit release builds on MSW, keep release settings but also build the debug symbols for easier debugging. https://bugs.webkit.org/show_bug.cgi?id=87151 Reviewed by Kevin Ollivier. * waf/build/settings.py: (common_configure): 2012-05-23 Carlos Garcia Campos Unreviewed. Move myself to reviewers. * Scripts/webkitpy/common/config/committers.py: 2012-05-23 Dongwoo Im [EFL] Implements the registerProtocolHandler method and option. https://bugs.webkit.org/show_bug.cgi?id=73638 Reviewed by Andreas Kling. * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port. 2012-05-23 Zan Dobersek [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001 https://bugs.webkit.org/show_bug.cgi?id=87221 Reviewed by Martin Robinson. Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and rightShift key names into proper GDK key symbols. * DumpRenderTree/gtk/EventSender.cpp: (createKeyPressEvent): 2012-04-18 Tor Arne Vestbø [Qt] Make the web view's url property follow the active url https://bugs.webkit.org/show_bug.cgi?id=77554 Update the location bar in the minibrowser to behave a bit more like normal browsers in terms of when the url will change and how active focus is handled. Reviewed by Simon Hausmann. * MiniBrowser/qt/qml/BrowserWindow.qml: 2012-05-23 Oswald Buddenhagen [Qt] Remove references to $$QT_SOURCE_TREE With a modularized Qt, it's ambigious. What we really want is qtbase, which qtcore is a proxy for (we assume it will always live in qtbase). Reviewed by Tor Arne Vestbø. * DumpRenderTree/qt/DumpRenderTree.pro: 2012-05-23 Oswald Buddenhagen [Qt] Fix qmake conditional for c++-11 compat warnings Reviewed by Tor Arne Vestbø. * qmake/mkspecs/features/unix/default_post.prf: 2012-05-23 Christophe Dumez [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages https://bugs.webkit.org/show_bug.cgi?id=85956 Reviewed by Gustavo Noronha Silva. Catch new "load,provisional,failed" signal and print didFailProvisionalLoadWithError messages when LayoutTestController's dumpFrameLoadCallbacks() returns true. Also make sure the didFailLoadWithError message is not printed in case of provisional load failure. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: (DumpRenderTreeChrome::createView): (DumpRenderTreeChrome::onFrameCreated): (DumpRenderTreeChrome::onFrameProvisionalLoadFailed): (DumpRenderTreeChrome::onFrameLoadError): * DumpRenderTree/efl/DumpRenderTreeChrome.h: (DumpRenderTreeChrome): 2012-05-23 Christophe Dumez [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1) https://bugs.webkit.org/show_bug.cgi?id=86366 Reviewed by Antonio Gomes. Call Settings::setValidationMessageTimerMagnification(-1) between the tests. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: (DumpRenderTreeChrome::resetDefaultsToConsistentValues): 2012-05-22 Darin Adler * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore. * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore. 2012-05-22 Xianzhu Wang [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part) https://bugs.webkit.org/show_bug.cgi?id=86922 Because we have new platformInit() in TestShellAndroid.cpp, and we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp is split into TestShellPosix.cpp and TestShellX11.cpp. Reviewed by Kent Tamura. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr. (platformInit): * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp. * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac). (AlarmHandler): (TestShell::waitTestFinished): * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1 (openStartupDialog): from TestShellGtk.cpp (checkLayoutTestSystemDependencies): from TestShellGtk.cpp. (setupFontconfig): (platformInit): 2012-05-22 Kangil Han [EFL][DRT] Implement touch event https://bugs.webkit.org/show_bug.cgi?id=86720 Reviewed by Hajime Morita. Currently EFL DRT doesn't support touch event. Therefore, this patch enabled it and implemented some eventSender function callbacks. * DumpRenderTree/efl/EventSender.cpp: (TouchEventInfo::TouchEventInfo): (TouchEventInfo): (touchPointList): (sendTouchEvent): (addTouchPointCallback): (touchStartCallback): (updateTouchPointCallback): (touchMoveCallback): (cancelTouchPointCallback): (touchCancelCallback): (releaseTouchPointCallback): (touchEndCallback): (clearTouchPointsCallback): (setTouchModifierCallback): * Scripts/webkitperl/FeatureList.pm: 2012-05-22 Xianzhu Wang [Chromium-Android] Fix chromium_android_unittest https://bugs.webkit.org/show_bug.cgi?id=87196 Not reviewed. Temporarily disable chromium_android_unittest. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: (ChromiumAndroidPortTest): (ChromiumAndroidDriverTest): 2012-05-22 Jessie Berlin WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading https://bugs.webkit.org/show_bug.cgi?id=64313 Reviewed by Jon Honeycutt. Add it. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Make sure to generate the binding. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setDefersLoading): Call WKBundlePageSetDefersLoading. * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 2012-05-22 Xianzhu Wang [Chromium-Android] Run DumpRenderTree as an apk (python part) https://bugs.webkit.org/show_bug.cgi?id=86923 chromium_android.py is modified to support running DumpRenderTree as an apk, so that we can run the tests (e.g. video) requiring features implemented in Java on Android. Reviewed by Adam Barth. * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidPort.__init__): (ChromiumAndroidPort.default_child_processes): (ChromiumAndroidPort.check_wdiff): (ChromiumAndroidPort.check_build): (ChromiumAndroidPort.start_helper): (ChromiumAndroidPort.skipped_layout_tests): (ChromiumAndroidPort): (ChromiumAndroidPort._path_to_driver): (ChromiumAndroidPort._get_crash_log): (ChromiumAndroidPort._push_executable): (ChromiumAndroidPort._run_adb_command): (ChromiumAndroidPort._get_last_stacktrace): (ChromiumAndroidPort._get_logcat): (ChromiumAndroidPort._setup_performance): (ChromiumAndroidDriver): (ChromiumAndroidDriver.__init__): (ChromiumAndroidDriver._command_wrapper): (ChromiumAndroidDriver.cmd_line): (ChromiumAndroidDriver._file_exists_on_device): (ChromiumAndroidDriver._deadlock_detector): (ChromiumAndroidDriver._start): (ChromiumAndroidDriver.run_test): (ChromiumAndroidDriver.stop): (ChromiumAndroidDriver._write_command_and_read_line): (ChromiumAndroidDriver._output_image): (ChromiumAndroidDriver._get_stderr): 2012-05-22 Joshua Bell [Chromium] Reverting r118084 - webkit_tests failing on chromium mac. Unreviewed gardening. * Scripts/webkitpy/layout_tests/port/base.py: (Port.driver_name): * Scripts/webkitpy/layout_tests/port/chromium_linux.py: (ChromiumLinuxPort._path_to_driver): * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: (ChromiumPortTest.test_overrides_and_builder_names): * Scripts/webkitpy/layout_tests/port/chromium_win.py: (ChromiumWinPort._path_to_driver): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): 2012-05-22 Xianzhu Wang [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp https://bugs.webkit.org/show_bug.cgi?id=87176 Reviewed by Tony Chang. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: * DumpRenderTree/DumpRenderTree.gypi: 2012-05-22 Jochen Eisinger [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries https://bugs.webkit.org/show_bug.cgi?id=87128 Reviewed by Dirk Pranke. * Scripts/webkitpy/layout_tests/port/base.py: (Port.driver_name): * Scripts/webkitpy/layout_tests/port/chromium_linux.py: (ChromiumLinuxPort._path_to_driver): * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: (ChromiumPortTest.test_driver_name_option): * Scripts/webkitpy/layout_tests/port/chromium_win.py: (ChromiumWinPort._path_to_driver): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): 2012-05-22 Jessie Berlin WTR fix after r118001. Rubber-stamped by Alexey Proskuryakov. Update the WTR implementation of keyDown to match the DRT one changed in r118001. * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::keyDown): 2012-05-22 Kausalya Madhusudhanan [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality. https://bugs.webkit.org/show_bug.cgi?id=86684 Reviewed by Darin Fisher. * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::numberOfPages): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::printPage): == Rolled over to ChangeLog-2012-05-22 ==