static int open_logfile (const char *pathname)
{
- return open(pathname, O_WRONLY | O_APPEND | O_CREAT, S_IRUSR | S_IWUSR);
+ return open(pathname, O_WRONLY | O_APPEND | O_CREAT, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH);
}
static void rotate_logs()
static void setup_output()
{
- if (g_output_filename == NULL) {
- g_outfd = STDOUT_FILENO;
-
- } else {
- struct stat statbuf;
+ if (g_output_filename == NULL) {
+ g_outfd = STDOUT_FILENO;
- g_outfd = open_logfile (g_output_filename);
-
- if (g_outfd < 0) {
- perror ("couldn't open output file");
- exit(-1);
- }
+ } else {
+ struct stat statbuf;
- fstat(g_outfd, &statbuf);
+ g_outfd = open_logfile (g_output_filename);
- g_out_byte_count = statbuf.st_size;
- }
+ if (g_outfd < 0) {
+ perror ("couldn't open output file");
+ exit(-1);
+ }
+ if (fstat(g_outfd, &statbuf) == -1)
+ g_out_byte_count = 0;
+ else
+ g_out_byte_count = statbuf.st_size;
+ }
}
static int set_log_format(const char * formatString)
" -r [<kbytes>] Rotate log every kbytes. (16 if unspecified). Requires -f\n"
" -n <count> Sets max number of rotated logs to <count>, default 4\n"
" -v <format> Sets the log print format, where <format> is one of:\n\n"
- " brief process tag thread raw time threadtime long\n\n"
- " -c clear (flush) the entire log and exit\n"
+ " brief(by default) process tag thread raw time threadtime long\n\n"
+ " -c clear (flush) the entire log and exit, conflicts with '-g'\n"
" -d dump the log and then exit (don't block)\n"
" -t <count> print only the most recent <count> lines (implies -d)\n"
- " -g get the size of the log's ring buffer and exit\n"
+ " -g get the size of the log's ring buffer and exit, conflicts with '-c'\n"
" -b <buffer> request alternate ring buffer\n"
" ('main' (default), 'radio', 'system')");
" F Fatal\n"
" S Silent (supress all output)\n"
"\n'*' means '*:D' and <tag> by itself means <tag>:V\n"
- "If no filterspec is found, filter defaults to '*:I'\n"
- "\nIf not specified with -v, format is set defaults to \"brief\"\n\n");
-
-
-
+ "If no filterspec is found, filter defaults to '*:I'\n\n");
}
case 'b': {
char *buf;
- if (asprintf(&buf, LOG_FILE_DIR "/%s", optarg) == -1) {
+ if (asprintf(&buf, LOG_FILE_DIR "%s", optarg) == -1) {
asprintf(stderr,"Can't malloc LOG_FILE_DIR\n");
exit(-1);
}
}
}
+ /* get log size conflicts with write mode */
+ if (getLogSize && mode != O_RDONLY) {
+ show_help(argv[0]);
+ exit(-1);
+ }
+
if (!devices) {
devices = log_devices_new("/dev/"LOGGER_LOG_MAIN);
if (devices == NULL) {