main: static-qualify default config values
authorGrant Erickson <marathon96@gmail.com>
Thu, 28 Jun 2012 00:21:18 +0000 (17:21 -0700)
committerMarcel Holtmann <marcel@holtmann.org>
Thu, 28 Jun 2012 05:49:33 +0000 (07:49 +0200)
The default configuration arrays default_auto_connect and
default_blacklist must be static-qualified. Otherwise, their
stack-allocated storage will go out of scope after parse_config
is finished and empty or commented-out DefaultAutoConnectTechnologies
or NetworkInterfaceBlacklist config entries will refer to
random stack data.

src/main.c

index fc3812f..a39adb3 100644 (file)
@@ -141,13 +141,13 @@ static void parse_config(GKeyFile *config)
        char **interfaces;
        char **str_list;
        gsize len;
-       char *default_auto_connect[] = {
+       static char *default_auto_connect[] = {
                "wifi",
                "ethernet",
                "cellular",
                NULL
        };
-       char *default_blacklist[] = {
+       static char *default_blacklist[] = {
                "vmnet",
                "vboxnet",
                "virbr",