From fa772a0a9d1be796ff23aab1ee7f59cc1aa4e620 Mon Sep 17 00:00:00 2001 From: Brendan Le Foll Date: Wed, 11 Nov 2015 16:00:12 +0000 Subject: [PATCH] FindNodejs.cmake: V8_VERSION_MAJOR is being set and MINOR/PATCH where empty This has been wrong for a while and probably not the most important but when node.js fails to be detected (typically this means runtime check on node.js has failed which hopefully is rare!) Signed-off-by: Brendan Le Foll --- cmake/modules/FindNodejs.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmake/modules/FindNodejs.cmake b/cmake/modules/FindNodejs.cmake index 51024fb..b586024 100644 --- a/cmake/modules/FindNodejs.cmake +++ b/cmake/modules/FindNodejs.cmake @@ -48,8 +48,8 @@ if (NODE_EXECUTABLE) set (NODE_VERSION_MINOR "10") set (NODE_VERSION_PATCH "30") set (V8_VERSION_MAJOR "3") - set (V8_VERSION_MAJOR "14") - set (V8_VERSION_MAJOR "5") + set (V8_VERSION_MINOR"14") + set (V8_VERSION_PATCH "5") set (V8_VERSION_STRING "3.28.72") message ("defaulted to node 0.10.30") endif () -- 2.7.4